Skip to content

Commit f707f4a

Browse files
authored
Dropped Node 16 support (#65)
Co-authored-by: ijlee2 <[email protected]>
1 parent 0c1e017 commit f707f4a

File tree

7 files changed

+227
-223
lines changed

7 files changed

+227
-223
lines changed

.eslintrc.cjs

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,17 @@
22

33
module.exports = {
44
root: true,
5-
parser: '@typescript-eslint/parser',
65
parserOptions: {
76
ecmaVersion: 'latest',
87
project: true,
98
sourceType: 'module',
109
},
11-
plugins: ['@typescript-eslint', 'simple-import-sort', 'typescript-sort-keys'],
10+
plugins: ['simple-import-sort'],
1211
extends: [
1312
'eslint:recommended',
1413
'plugin:import/recommended',
15-
'plugin:import/typescript',
1614
'plugin:n/recommended',
1715
'plugin:prettier/recommended',
18-
'plugin:typescript-sort-keys/recommended',
1916
],
2017
rules: {
2118
curly: 'error',
@@ -32,16 +29,20 @@ module.exports = {
3229
// TypeScript files
3330
{
3431
files: ['**/*.{cts,ts}'],
35-
extends: ['plugin:@typescript-eslint/recommended-type-checked'],
32+
parser: '@typescript-eslint/parser',
33+
extends: [
34+
'plugin:@typescript-eslint/recommended',
35+
'plugin:import/typescript',
36+
'plugin:typescript-sort-keys/recommended',
37+
],
3638
rules: {
3739
'@typescript-eslint/array-type': 'error',
38-
'@typescript-eslint/no-unsafe-argument': 'off',
39-
'@typescript-eslint/no-unsafe-assignment': 'off',
40+
'import/no-duplicates': 'error',
4041
},
4142
},
42-
// TypeScript and JavaScript files
43+
// JavaScript files
4344
{
44-
files: ['**/*.{cjs,cts,js,ts}'],
45+
files: ['**/*.{cjs,js}'],
4546
rules: {
4647
'import/no-duplicates': 'error',
4748
},
@@ -53,10 +54,7 @@ module.exports = {
5354
browser: false,
5455
node: true,
5556
},
56-
extends: [
57-
'plugin:@typescript-eslint/disable-type-checked',
58-
'plugin:n/recommended',
59-
],
57+
extends: ['plugin:n/recommended'],
6058
},
6159
],
6260
};

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
pull_request:
88

99
env:
10-
NODE_VERSION: 16
10+
NODE_VERSION: 18
1111

1212
jobs:
1313
lint:
@@ -16,7 +16,7 @@ jobs:
1616
timeout-minutes: 5
1717
steps:
1818
- name: Check out a copy of the repo
19-
uses: actions/checkout@v3
19+
uses: actions/checkout@v4
2020

2121
- name: Set up pnpm
2222
uses: pnpm/action-setup@v2
@@ -42,7 +42,7 @@ jobs:
4242
timeout-minutes: 5
4343
steps:
4444
- name: Check out a copy of the repo
45-
uses: actions/checkout@v3
45+
uses: actions/checkout@v4
4646

4747
- name: Set up pnpm
4848
uses: pnpm/action-setup@v2

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ You can also look at another codemod called [`ember-addon-migrator`](https://git
121121

122122
## Compatibility
123123

124-
- Node.js v16 or above
124+
- Node.js v18 or above
125125

126126

127127
## Contributing

package.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -38,28 +38,28 @@
3838
"test": "./build.sh --test && mt dist-for-testing --quiet"
3939
},
4040
"dependencies": {
41-
"@codemod-utils/blueprints": "^0.2.1",
42-
"@codemod-utils/files": "^0.5.3",
43-
"@codemod-utils/json": "^0.4.2",
41+
"@codemod-utils/blueprints": "^1.0.0",
42+
"@codemod-utils/files": "^1.0.0",
43+
"@codemod-utils/json": "^1.0.0",
4444
"strip-json-comments": "^5.0.1",
4545
"yargs": "^17.7.2"
4646
},
4747
"devDependencies": {
48-
"@babel/core": "^7.22.11",
49-
"@codemod-utils/tests": "^0.3.1",
50-
"@sondr3/minitest": "^0.1.1",
51-
"@tsconfig/node16": "^16.1.1",
48+
"@babel/core": "^7.22.17",
49+
"@codemod-utils/tests": "^1.0.0",
50+
"@sondr3/minitest": "^0.1.2",
51+
"@tsconfig/node18": "^18.2.2",
5252
"@tsconfig/strictest": "^2.0.2",
53-
"@types/node": "^16.18.47",
53+
"@types/node": "^18.17.15",
5454
"@types/yargs": "^17.0.24",
55-
"@typescript-eslint/eslint-plugin": "^6.5.0",
56-
"@typescript-eslint/parser": "^6.5.0",
55+
"@typescript-eslint/eslint-plugin": "^6.7.0",
56+
"@typescript-eslint/parser": "^6.7.0",
5757
"concurrently": "^8.2.1",
58-
"eslint": "^8.48.0",
58+
"eslint": "^8.49.0",
5959
"eslint-config-prettier": "^9.0.0",
6060
"eslint-import-resolver-typescript": "^3.6.0",
6161
"eslint-plugin-import": "^2.28.1",
62-
"eslint-plugin-n": "^16.0.2",
62+
"eslint-plugin-n": "^16.1.0",
6363
"eslint-plugin-prettier": "^5.0.0",
6464
"eslint-plugin-simple-import-sort": "^10.0.0",
6565
"eslint-plugin-typescript-sort-keys": "^3.0.0",
@@ -68,7 +68,7 @@
6868
"typescript": "^5.2.2"
6969
},
7070
"engines": {
71-
"node": "16.* || >= 18"
71+
"node": "18.* || >= 20"
7272
},
7373
"changelog": {
7474
"labels": {

0 commit comments

Comments
 (0)