Skip to content

Commit 4f72fa3

Browse files
authored
Added Ember 4.12 LTS to ember-try scenarios (#201)
* chore: Updated development dependencies * bugfix: Ignored false positives (no-redundant-role, require-valid-alt-text) * chore: Updated ember-source to 5.0.0 * chore: Added ember-lts-4.12 to ember-try scenarios --------- Co-authored-by: ijlee2 <[email protected]>
1 parent be80b6b commit 4f72fa3

File tree

12 files changed

+1136
-1559
lines changed

12 files changed

+1136
-1559
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,7 @@ jobs:
189189
scenario:
190190
- 'ember-lts-4.4'
191191
- 'ember-lts-4.8'
192+
- 'ember-lts-4.12'
192193
- 'ember-release'
193194
- 'ember-beta'
194195
- 'ember-canary'

docs-app/app/components/products/product/image.gts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,14 @@ const ProductsProductImageComponent: TOC<ProductsProductImageSignature> =
1717
<div class={{styles.placeholder-image}}></div>
1818

1919
{{else}}
20+
{{! template-lint-disable no-redundant-role }}
2021
<img
2122
alt=""
2223
class={{styles.image}}
2324
role="presentation"
2425
src={{@src}}
2526
/>
27+
{{! template-lint-enable no-redundant-role }}
2628

2729
{{/if}}
2830
</template>

docs-app/app/components/widgets/widget-1.gts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,3 @@ declare module '@glint/environment-ember-loose/registry' {
4545
'Widgets::Widget-1': typeof WidgetsWidget1Component;
4646
}
4747
}
48-

docs-app/app/components/widgets/widget-3/tour-schedule/responsive-image.gts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,15 @@ export default class WidgetsWidget3TourScheduleResponsiveImageComponent extends
2828
{{containerQuery debounce=300 onQuery=this.setImageSource}}
2929
>
3030
{{#if this.imageSource}}
31+
{{! template-lint-disable no-redundant-role }}
3132
<img
3233
alt=""
3334
class={{styles.image}}
3435
data-test-image="Concert"
3536
role="presentation"
3637
src={{this.imageSource}}
3738
/>
39+
{{! template-lint-enable no-redundant-role }}
3840
{{/if}}
3941
</div>
4042
</template>

docs-app/app/components/widgets/widget-4/memo/header.gts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,15 @@ const WidgetsWidget4MemoHeaderComponent: TOC<WidgetsWidget4MemoHeaderSignature>
3030
>
3131
{{#unless showMinimalLayout}}
3232
<div class={{styles.avatar-container}}>
33+
{{! template-lint-disable no-redundant-role }}
3334
<img
3435
alt=""
3536
class={{styles.avatar}}
3637
data-test-image="Avatar"
3738
role="presentation"
3839
src="/images/widgets/widget-4/avatar.jpg"
3940
/>
41+
{{! template-lint-enable no-redundant-role }}
4042
</div>
4143
{{/unless}}
4244

docs-app/config/ember-cli-update.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"packages": [
44
{
55
"name": "ember-cli",
6-
"version": "4.12.0",
6+
"version": "5.0.0",
77
"blueprints": [
88
{
99
"name": "app",

docs-app/package.json

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,10 @@
4444
"devDependencies": {
4545
"@ember/optional-features": "^2.0.0",
4646
"@ember/string": "^3.1.1",
47-
"@ember/test-helpers": "^3.0.3",
48-
"@embroider/compat": "^3.0.1",
49-
"@embroider/core": "^3.0.1",
50-
"@embroider/macros": "^1.11.0",
47+
"@ember/test-helpers": "^3.1.0",
48+
"@embroider/compat": "^3.0.2",
49+
"@embroider/core": "^3.0.2",
50+
"@embroider/macros": "^1.11.1",
5151
"@embroider/router": "^2.1.1",
5252
"@embroider/webpack": "^3.0.0",
5353
"@gavant/glint-template-types": "^0.3.3",
@@ -57,12 +57,12 @@
5757
"@glint/environment-ember-loose": "^1.0.2",
5858
"@glint/environment-ember-template-imports": "^1.0.2",
5959
"@glint/template": "^1.0.2",
60-
"@percy/cli": "^1.26.0",
60+
"@percy/cli": "^1.26.1",
6161
"@percy/ember": "^4.2.0",
6262
"@tsconfig/ember": "^2.0.0",
63-
"@types/qunit": "^2.19.5",
64-
"@typescript-eslint/eslint-plugin": "^5.59.11",
65-
"@typescript-eslint/parser": "^5.59.11",
63+
"@types/qunit": "^2.19.6",
64+
"@typescript-eslint/eslint-plugin": "^5.60.0",
65+
"@typescript-eslint/parser": "^5.60.0",
6666
"autoprefixer": "^10.4.14",
6767
"broccoli-asset-rev": "^3.0.0",
6868
"concurrently": "^8.2.0",
@@ -72,12 +72,13 @@
7272
"d3-selection": "^3.0.0",
7373
"d3-shape": "^3.2.0",
7474
"ember-a11y-refocus": "^3.0.2",
75-
"ember-a11y-testing": "^6.0.0-0",
75+
"ember-a11y-testing": "^6.1.0",
7676
"ember-auto-import": "^2.6.3",
77-
"ember-cli": "~4.12.1",
78-
"ember-cli-app-version": "^6.0.0",
77+
"ember-cli": "~5.0.0",
78+
"ember-cli-app-version": "^6.0.1",
7979
"ember-cli-babel": "^7.26.11",
80-
"ember-cli-dependency-checker": "^3.3.1",
80+
"ember-cli-clean-css": "^2.0.0",
81+
"ember-cli-dependency-checker": "^3.3.2",
8182
"ember-cli-dependency-lint": "^2.0.1",
8283
"ember-cli-htmlbars": "^6.2.0",
8384
"ember-cli-inject-live-reload": "^2.1.0",
@@ -87,15 +88,15 @@
8788
"ember-modifier": "^4.1.0",
8889
"ember-page-title": "^7.0.0",
8990
"ember-qunit": "^7.0.0",
90-
"ember-resolver": "^10.1.0",
91-
"ember-source": "~4.12.0",
91+
"ember-resolver": "^10.1.1",
92+
"ember-source": "~5.0.0",
9293
"ember-svg-jar": "^2.4.2",
9394
"ember-template-imports": "^3.4.2",
94-
"ember-template-lint": "^5.10.1",
95-
"ember-template-lint-plugin-prettier": "^4.1.1",
95+
"ember-template-lint": "^5.10.3",
96+
"ember-template-lint-plugin-prettier": "^4.2.0",
9697
"ember-test-selectors": "^6.0.0",
97-
"embroider-css-modules": "^0.1.7",
98-
"eslint": "^8.42.0",
98+
"embroider-css-modules": "^0.1.9",
99+
"eslint": "^8.43.0",
99100
"eslint-config-prettier": "^8.8.0",
100101
"eslint-plugin-ember": "^11.8.0",
101102
"eslint-plugin-n": "^16.0.0",
@@ -109,14 +110,14 @@
109110
"prettier": "^2.8.8",
110111
"qunit": "^2.19.4",
111112
"qunit-dom": "^2.0.0",
112-
"stylelint": "^15.7.0",
113+
"stylelint": "^15.9.0",
113114
"stylelint-config-standard": "^33.0.0",
114115
"stylelint-no-unsupported-browser-features": "^6.1.0",
115116
"stylelint-order": "^6.0.3",
116117
"stylelint-prettier": "^3.0.0",
117-
"type-css-modules": "^0.1.5",
118+
"type-css-modules": "^0.2.3",
118119
"typescript": "^5.1.3",
119-
"webpack": "^5.86.0"
120+
"webpack": "^5.88.0"
120121
},
121122
"engines": {
122123
"node": "16.* || >= 18"

ember-container-query/package.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -76,18 +76,18 @@
7676
"@glint/environment-ember-loose": "^1.0.2",
7777
"@glint/template": "^1.0.2",
7878
"@tsconfig/ember": "^2.0.0",
79-
"@types/ember__component": "^4.0.13",
80-
"@types/ember__destroyable": "^4.0.1",
81-
"@types/ember__object": "^4.0.5",
82-
"@types/ember__owner": "^4.0.3",
83-
"@types/ember__runloop": "^4.0.2",
84-
"@types/ember__service": "^4.0.2",
85-
"@typescript-eslint/eslint-plugin": "^5.59.11",
86-
"@typescript-eslint/parser": "^5.59.11",
79+
"@types/ember__component": "^4.0.14",
80+
"@types/ember__destroyable": "^4.0.2",
81+
"@types/ember__object": "^4.0.6",
82+
"@types/ember__owner": "^4.0.4",
83+
"@types/ember__runloop": "^4.0.3",
84+
"@types/ember__service": "^4.0.3",
85+
"@typescript-eslint/eslint-plugin": "^5.60.0",
86+
"@typescript-eslint/parser": "^5.60.0",
8787
"concurrently": "^8.2.0",
88-
"ember-template-lint": "^5.10.1",
89-
"ember-template-lint-plugin-prettier": "^4.1.1",
90-
"eslint": "^8.42.0",
88+
"ember-template-lint": "^5.10.3",
89+
"ember-template-lint-plugin-prettier": "^4.2.0",
90+
"eslint": "^8.43.0",
9191
"eslint-config-prettier": "^8.8.0",
9292
"eslint-plugin-ember": "^11.8.0",
9393
"eslint-plugin-n": "^16.0.0",

0 commit comments

Comments
 (0)