Skip to content

Commit 385c661

Browse files
committed
fix: set webhook title to None for Slack, WeCom, DingTalk, and Lark adapters.
1 parent b31f265 commit 385c661

9 files changed

+9
-12
lines changed

apps/webhook_router/src/adapters/dingtalk.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ fn dingtalk_title_from_payload(payload: &Value, msgtype: Option<&str>) -> Option
229229
.and_then(|value| value.as_str())
230230
})
231231
.map(String::from),
232-
_ => msgtype.map(String::from),
232+
_ => None,
233233
}
234234
}
235235

apps/webhook_router/src/adapters/lark.rs

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,7 @@ impl WebhookAdapter for LarkAdapter {
151151
id: event_id,
152152
source: "lark".to_string(),
153153
timestamp,
154-
title: message
155-
.get("message_type")
156-
.and_then(|value| value.as_str())
157-
.map(String::from),
154+
title: None,
158155
markdown: if content_text.is_empty() {
159156
payload.to_string()
160157
} else {

apps/webhook_router/src/adapters/slack.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ impl WebhookAdapter for SlackAdapter {
107107
id: event_id,
108108
source: "slack".to_string(),
109109
timestamp,
110-
title: event.get("type").and_then(|value| value.as_str()).map(String::from),
110+
title: None,
111111
markdown: if text.is_empty() {
112112
payload.to_string()
113113
} else {

apps/webhook_router/src/adapters/snapshots/webhook_router__adapters__dingtalk__tests__adapters_dingtalk_ingress_text.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ raw:
2222
content: "我就是我, @180xxxxxx 是不一样的烟火"
2323
source: dingtalk
2424
timestamp: 1700000000
25-
title: text
25+
title: ~

apps/webhook_router/src/adapters/snapshots/webhook_router__adapters__lark__tests__adapters_lark_ingress_text.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ raw:
1818
event_time: "1700000000000"
1919
source: lark
2020
timestamp: 1700000000
21-
title: text
21+
title: ~

apps/webhook_router/src/adapters/snapshots/webhook_router__adapters__slack__tests__adapters_slack_ingress_basic.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ raw:
1818
event_time: 1700000000
1919
source: slack
2020
timestamp: 1700000000
21-
title: message
21+
title: ~

apps/webhook_router/src/adapters/snapshots/webhook_router__adapters__wecom__tests__adapters_wecom_ingress_markdown.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ raw:
1515
msgtype: markdown
1616
source: wecom
1717
timestamp: 1700000000
18-
title: markdown
18+
title: ~

apps/webhook_router/src/adapters/snapshots/webhook_router__adapters__wecom__tests__adapters_wecom_ingress_text.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ raw:
1515
content: hello world
1616
source: wecom
1717
timestamp: 1700000000
18-
title: text
18+
title: ~

apps/webhook_router/src/adapters/wecom.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ impl WebhookAdapter for WecomAdapter {
4444
id: event_id,
4545
source: "wecom".to_string(),
4646
timestamp,
47-
title: msgtype.map(String::from),
47+
title: None,
4848
markdown: if text.is_empty() {
4949
payload.to_string()
5050
} else {

0 commit comments

Comments
 (0)