Skip to content

Commit 551ee28

Browse files
authored
Merge pull request #39 from ilikepi63/fix/error-logging-for-consume
fix: Error Logging for Consume.
2 parents 2e6f97b + 886a3d9 commit 551ee28

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "riskless"
3-
version = "0.6.2"
3+
version = "0.6.3"
44
edition = "2024"
55
description = "A pure Rust implementation of Diskless Topics"
66
license = "MIT / Apache-2.0"

src/lib.rs

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,18 +163,29 @@ pub async fn consume(
163163
.filter(|batch| batch.object_key == *object_name)
164164
.map(|batch| (res.clone(), batch))
165165
})
166+
.inspect(|val| {
167+
tracing::trace!("Result returned for query: {:#?}", val);
168+
})
166169
.filter_map(|(res, batch)| {
167170
ConsumeBatch::try_from((res, batch, &b)).ok()
168171
})
169172
.collect::<Vec<_>>();
170173

171174
batch_responses_for_object
172175
} else {
176+
tracing::trace!(
177+
"Could not retrieve bytes for given GetObject query: {}",
178+
object_name
179+
);
173180
vec![]
174181
}
175182
}
176-
Err(_err) => {
177-
// TODO: How are we going to handle errors here?
183+
Err(err) => {
184+
tracing::error!(
185+
"An error occurred trying to retrieve the object with key {}. Error: {:#?}",
186+
object_name,
187+
err
188+
);
178189
vec![]
179190
}
180191
};
@@ -186,6 +197,8 @@ pub async fn consume(
186197
{
187198
tracing::error!("Failed to send consume response: {:#?}", e);
188199
};
200+
} else {
201+
tracing::trace!("No ConsumeBatches found for query.");
189202
};
190203
});
191204
}

0 commit comments

Comments
 (0)