Fix clang compiler detection on Windows

cmb69 · cmb69 · commit 58628e0cc629 · 2025-01-14T12:36:19.000+01:00
A previous commit[1] left a "debug" statement, which causes clang builds on Windows to fail always. [1] <php@b3d6414> Closes phpGH-17450.
diff --git a/NEWS b/NEWS
@@ -59,6 +59,9 @@ PHP                                                                        NEWS
   . Fixed bug GH-15833 (Segmentation fault (access null pointer) in
     ext/spl/spl_array.c). (nielsdos)
 
+- Windows:
+  . Fixed clang compiler detection. (cmb)
+
 - Zip:
   . Fixed bug GH-17139 (Fix zip_entry_name() crash on invalid entry).
     (nielsdos)
diff --git a/win32/build/confutils.js b/win32/build/confutils.js
@@ -3125,7 +3125,7 @@ function toolset_get_compiler_name(short)
 		var command = 'cmd /c ""' + PHP_CL + '" -v"';
 		var full = execute(command + '" 2>&1"');
 
-		ERROR(full.split(/\n/)[0].replace(/\s/g, ' '));
+		return full.split(/\n/)[0].replace(/\s/g, ' ');
 	}
 
 	WARNING("Unsupported toolset");

Original file line number	Diff line number	Diff line change
`@@ -3125,7 +3125,7 @@ function toolset_get_compiler_name(short)`
`3125`	`3125`	`var command = 'cmd /c ""' + PHP_CL + '" -v"';`
`3126`	`3126`	`var full = execute(command + '" 2>&1"');`
`3127`	`3127`
`3128`		`- ERROR(full.split(/\n/)[0].replace(/\s/g, ' '));`
	`3128`	`+ return full.split(/\n/)[0].replace(/\s/g, ' ');`
`3129`	`3129`	`}`
`3130`	`3130`
`3131`	`3131`	`WARNING("Unsupported toolset");`