ext/standard: Add tests for Directory class

Author: Girgias

ext/standard/tests/directory/DirectoryClass_cannot_clone.phpt

@@ -0,0 +1,28 @@
+--TEST--
+Cannot serialize instance of Directory class constructed via Reflection.
+--FILE--
+<?php
+
+$d = dir(__DIR__);
+try {
+    $cloned = clone $d;
+    $cloned_files = [];
+    while ($row = $cloned->read()){
+        $cloned_files[] = $row;
+    }
+    var_dump(count($cloned_files));
+    echo "Using original object:\n";
+    $original_files = [];
+    while ($row = $d->read()){
+        $original_files[] = $row;
+    }
+    var_dump(count($original_files));
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+
+?>
+--EXPECT--
+int(17)
+Using original object:
+int(0)

ext/standard/tests/directory/DirectoryClass_cannot_construct.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Cannot directly instantiate Directory class.
+--FILE--
+<?php
+
+try {
+    $d = new Directory();
+    var_dump($d);
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+
+?>
+--EXPECT--
+object(Directory)#1 (0) {
+  ["path"]=>
+  uninitialized(string)
+  ["handle"]=>
+  uninitialized(mixed)
+}

ext/standard/tests/directory/DirectoryClass_cannot_serialize.phpt

@@ -0,0 +1,16 @@
+--TEST--
+Cannot serialize instance of Directory class constructed via Reflection.
+--FILE--
+<?php
+
+$d = dir(__DIR__);
+try {
+    $s = serialize($d);
+    var_dump($s);
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+
+?>
+--EXPECTF--
+string(%d) "O:9:"Directory":2:{s:4:"path";s:%d:"%s";s:6:"handle";i:%d;}"

ext/standard/tests/directory/DirectoryClass_error_001.phpt

@@ -0,0 +1,26 @@
+--TEST--
+Changing Directory::$handle property
+--FILE--
+<?php
+
+$d = dir(__DIR__);
+try {
+    $d->handle = "Havoc!";
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+var_dump($d->handle);
+
+try {
+    unset($d->handle);
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+var_dump($d->handle);
+
+?>
+--EXPECTF--
+Error: Cannot modify readonly property Directory::$handle
+resource(%d) of type (stream)
+Error: Cannot unset readonly property Directory::$handle
+resource(%d) of type (stream)

ext/standard/tests/directory/DirectoryClass_readonly_handle.phpt

@@ -0,0 +1,26 @@
+--TEST--
+Changing Directory::$handle property
+--FILE--
+<?php
+
+$d = dir(__DIR__);
+try {
+    $d->path = "Havoc!";
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+var_dump($d->path == __DIR__);
+
+try {
+    unset($d->path);
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+var_dump($d->path == __DIR__);
+
+?>
+--EXPECTF--
+Error: Cannot modify readonly property Directory::$path
+bool(true)
+Error: Cannot unset readonly property Directory::$path
+bool(true)

ext/standard/tests/directory/DirectoryClass_readonly_path.phpt

@@ -0,0 +1,30 @@
+--TEST--
+Cannot use instance of Directory class constructed via Reflection.
+--FILE--
+<?php
+
+$rc = new ReflectionClass("Directory");
+var_dump($rc->isInstantiable());
+try {
+    $d = $rc->newInstanceWithoutConstructor();
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+
+var_dump($d);
+try {
+    var_dump($d->read());
+} catch (\Throwable $e) {
+    echo $e::class, ': ', $e->getMessage(), PHP_EOL;
+}
+
+?>
+--EXPECT--
+bool(true)
+object(Directory)#2 (0) {
+  ["path"]=>
+  uninitialized(string)
+  ["handle"]=>
+  uninitialized(mixed)
+}
+Error: Unable to find my handle property

ext/standard/tests/directory/DirectoryClass_reflection_create_instance_no_construct.phpt

@@ -11,16 +11,6 @@ echo "Structure of Directory class:\n";
 $rc = new ReflectionClass("Directory");
 echo $rc;
 
-echo "Cannot instantiate a valid Directory directly:\n";
-$d = new Directory(getcwd());
-var_dump($d);
-
-try {
-    var_dump($d->read());
-} catch (\Error $e) {
-    echo $e->getMessage() . "\n";
-}
-
 ?>
 --EXPECTF--
 Structure of Directory class:
@@ -63,11 +53,3 @@ Class [ <internal%s> class Directory ] {
     }
   }
 }
-Cannot instantiate a valid Directory directly:
-object(Directory)#%d (0) {
-  ["path"]=>
-  uninitialized(string)
-  ["handle"]=>
-  uninitialized(mixed)
-}
-Unable to find my handle property