Skip to content

Commit b51ae63

Browse files
committed
Remove now redundant checks in the VM
1 parent 1097ea7 commit b51ae63

File tree

4 files changed

+141
-2487
lines changed

4 files changed

+141
-2487
lines changed

Zend/zend_compile.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -535,6 +535,7 @@ static zend_always_inline uint32_t get_temporary_variable(void) /* {{{ */
535535
}
536536
/* }}} */
537537

538+
// FIXME: Check all uses of lookup_cv() to see whether they need CHECK_VAR.
538539
static int lookup_cv(zend_string *name) /* {{{ */{
539540
zend_op_array *op_array = CG(active_op_array);
540541
int i = 0;

Zend/zend_compile.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -434,6 +434,7 @@ static zend_always_inline uint32_t zend_visibility_to_set_visibility(uint32_t vi
434434
#define ZEND_SHORT_CIRCUITING_CHAIN_EMPTY 2
435435

436436
// Must not clash with ZEND_SHORT_CIRCUITING_CHAIN_MASK
437+
// FIXME: Can we get rid of this? CHECK_VAR instruction should be inserted now instead.
437438
#define ZEND_JMP_NULL_BP_VAR_IS 4
438439

439440
char *zend_visibility_string(uint32_t fn_flags);

0 commit comments

Comments
 (0)