Adding unit tests

Author: hungryDev399

publish-subsribe/checkstyle.xml

@@ -19,34 +19,39 @@ public final class JmsUtil {
   private static Connection defaultConnection;
   private static BrokerService broker;
   private static Map<String, Connection> clientConnections = new ConcurrentHashMap<>();
-
-  static {
-    try {
-      // Start embedded broker for self-contained messaging
-      broker = new BrokerService();
-      broker.addConnector(BROKER_URL);
-      broker.setPersistent(false);  // Messages won't survive broker restart
-      broker.start();
-
-      // Default connection for non-durable subscribers
-      factory = new ActiveMQConnectionFactory(BROKER_URL);
-      defaultConnection = factory.createConnection();
-      defaultConnection.start();
-    } catch (Exception e) {
-      System.err.println("Failed to initialize JMS: " + e.getMessage());
-      throw new RuntimeException(e);
-    }
-  }
+  private static boolean isInitialized = false;
 
   private JmsUtil() {
     // Utility class, prevent instantiation
   }
 
+  public static synchronized void initialize() {
+    if (!isInitialized) {
+      try {
+        broker = new BrokerService();
+        broker.addConnector(BROKER_URL);
+        broker.setPersistent(false);
+        broker.start();
+
+        factory = new ActiveMQConnectionFactory(BROKER_URL);
+        defaultConnection = factory.createConnection();
+        defaultConnection.start();
+        isInitialized = true;
+      } catch (Exception e) {
+        System.err.println("Failed to initialize JMS: " + e.getMessage());
+        throw new RuntimeException(e);
+      }
+    }
+  }
+
   /**
    * Creates a JMS session, optionally with a client ID for durable subscriptions.
    * Each client ID gets its own dedicated connection to support durable subscribers.
    */
   public static Session createSession(String clientId) throws JMSException {
+    if (!isInitialized) {
+      initialize();
+    }
     if (clientId == null) {
       return defaultConnection.createSession(false, Session.AUTO_ACKNOWLEDGE);
     }
@@ -72,8 +77,9 @@ public static Session createSession() throws JMSException {
   /**
    * Closes all JMS resources.
    */
-  public static void closeConnection() {
+  public static synchronized void closeConnection() {
     try {
+      isInitialized = false;
       if (defaultConnection != null) {
         defaultConnection.close();
       }
@@ -90,4 +96,10 @@ public static void closeConnection() {
       System.err.println("Error closing JMS resources: " + e.getMessage());
     }
   }
+
+  public static synchronized void reset() {
+    closeConnection();
+    isInitialized = false;
+    initialize();
+  }
 }

publish-subsribe/pom.xml

@@ -0,0 +1,30 @@
+package com.hungrydev399.publishsubscribe;
+
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.AfterAll;
+import com.hungrydev399.publishsubscribe.jms.JmsUtil;
+
+/**
+ * Base class for JMS-related tests.
+ * 
+ * Provides:
+ * - Common JMS broker initialization
+ * - Resource cleanup after tests
+ * - Shared configuration for all JMS tests
+ * 
+ * Usage:
+ * - Extend this class in any test that needs JMS functionality
+ * - Ensures consistent JMS lifecycle across test classes
+ * - Prevents connection/broker issues between tests
+ */
+public abstract class TestBase {
+    @BeforeAll
+    static void initializeJms() {
+        JmsUtil.initialize();
+    }
+
+    @AfterAll
+    static void cleanupJms() {
+        JmsUtil.closeConnection();
+    }
+}

publish-subsribe/src/main/java/com/hungrydev399/publishsubscribe/jms/JmsUtil.java

@@ -0,0 +1,28 @@
+package com.hungrydev399.publishsubscribe.jms;
+
+import static org.junit.jupiter.api.Assertions.*;
+import org.junit.jupiter.api.Test;
+import javax.jms.JMSException;
+import javax.jms.Session;
+
+public class JmsUtilTest {
+    
+    @Test
+    void shouldCreateSessionWithoutClientId() throws JMSException {
+        Session session = JmsUtil.createSession();
+        assertNotNull(session);
+    }
+
+    @Test
+    void shouldCreateSessionWithClientId() throws JMSException {
+        Session session = JmsUtil.createSession("test-client");
+        assertNotNull(session);
+    }
+
+    @Test
+    void shouldCloseConnectionGracefully() {
+        JmsUtil.closeConnection();
+        // Verify no exceptions thrown
+        assertTrue(true);
+    }
+}

publish-subsribe/src/test/java/com/hungrydev399/publishsubscribe/TestBase.java

@@ -0,0 +1,31 @@
+package com.hungrydev399.publishsubscribe.model;
+
+import static org.junit.jupiter.api.Assertions.*;
+import org.junit.jupiter.api.Test;
+
+/**
+ * Tests for the Message model class.
+ * 
+ * Test coverage:
+ * - Message creation with content and topic
+ * - String representation (toString)
+ * - Getters functionality
+ */
+public class MessageTest {
+    @Test
+    void shouldCreateMessageWithContentAndTopic() {
+        Message message = new Message("Test content", "test-topic");
+        
+        assertEquals("Test content", message.getContent());
+        assertEquals("test-topic", message.getTopic());
+    }
+
+    @Test
+    void shouldGenerateCorrectToString() {
+        Message message = new Message("Test content", "test-topic");
+        String toString = message.toString();
+        
+        assertTrue(toString.contains("test-topic"));
+        assertTrue(toString.contains("Test content"));
+    }
+}

publish-subsribe/src/test/java/com/hungrydev399/publishsubscribe/jms/JmsUtilTest.java

@@ -0,0 +1,65 @@
+package com.hungrydev399.publishsubscribe.publisher;
+
+import static org.junit.jupiter.api.Assertions.*;
+import org.junit.jupiter.api.*;
+
+import com.hungrydev399.publishsubscribe.model.Message;
+import com.hungrydev399.publishsubscribe.subscriber.TopicSubscriber;
+import com.hungrydev399.publishsubscribe.subscriber.SubscriberType;
+import com.hungrydev399.publishsubscribe.TestBase;
+import com.hungrydev399.publishsubscribe.jms.JmsUtil;
+
+/**
+ * Tests for the TopicPublisher class.
+ * 
+ * Test Strategy:
+ * - Uses TestBase for JMS lifecycle management
+ * - Creates both publisher and subscriber to verify message flow
+ * - Tests null message handling
+ * - Validates resource cleanup
+ * 
+ * Test Coverage:
+ * - Message publishing functionality
+ * - Error handling (null messages)
+ * - Resource cleanup (close)
+ * - JMS connection management
+ */
+class TopicPublisherTest extends TestBase {
+    private TopicPublisher publisher;
+    private TopicSubscriber subscriber;
+    private static final String TEST_TOPIC = "TEST_TOPIC";
+    private static final String TEST_MESSAGE = "Test Message";
+
+    @BeforeEach
+    void setUp() throws Exception {
+        JmsUtil.reset(); // Reset JMS state before each test
+        publisher = new TopicPublisher(TEST_TOPIC);
+        subscriber = new TopicSubscriber("TestSub", TEST_TOPIC, SubscriberType.NONDURABLE, null);
+        Thread.sleep(100); // Allow connection setup
+    }
+
+    @AfterEach
+    void tearDown() throws Exception {
+        if (subscriber != null) {
+            subscriber.close();
+        }
+        if (publisher != null) {
+            publisher.close();
+        }
+    }
+
+    @Test
+    void shouldPublishAndReceiveMessage() throws Exception {
+        Message message = new Message(TEST_MESSAGE, TEST_TOPIC);
+        publisher.publish(message);
+
+        Thread.sleep(500); // Allow message delivery
+        // Verification is done through console output
+        assertTrue(true); // Test passes if no exceptions thrown
+    }
+
+    @Test
+    void shouldHandleNullMessage() {
+        assertThrows(NullPointerException.class, () -> publisher.publish(null));
+    }
+}

publish-subsribe/src/test/java/com/hungrydev399/publishsubscribe/model/MessageTest.java

@@ -0,0 +1,73 @@
+package com.hungrydev399.publishsubscribe.subscriber;
+
+import static org.junit.jupiter.api.Assertions.*;
+import org.junit.jupiter.api.*;
+
+import com.hungrydev399.publishsubscribe.model.Message;
+import com.hungrydev399.publishsubscribe.publisher.TopicPublisher;
+import com.hungrydev399.publishsubscribe.TestBase;
+import com.hungrydev399.publishsubscribe.jms.JmsUtil;
+
+/**
+ * Tests for the TopicSubscriber class.
+ * 
+ * Test Strategy:
+ * - Tests different subscription types (durable, non-durable)
+ * - Verifies message reception
+ * - Ensures proper resource cleanup
+ * - Uses TestBase for JMS infrastructure
+ * 
+ * Test Coverage:
+ * - Subscriber creation with different types
+ * - Message reception functionality
+ * - Resource cleanup
+ * - Subscription type verification
+ * - Error handling
+ */
+class TopicSubscriberTest extends TestBase {
+    private TopicPublisher publisher;
+    private TopicSubscriber subscriber;
+    private static final String TEST_TOPIC = "TEST_TOPIC";
+
+    @BeforeEach
+    void setUp() throws Exception {
+        JmsUtil.reset(); // Reset JMS state before each test
+        publisher = new TopicPublisher(TEST_TOPIC);
+    }
+
+    @AfterEach
+    void tearDown() throws Exception {
+        if (subscriber != null) {
+            subscriber.close();
+        }
+        if (publisher != null) {
+            publisher.close();
+        }
+    }
+
+    @Test
+    void shouldCreateNonDurableSubscriber() throws Exception {
+        subscriber = new TopicSubscriber("test", TEST_TOPIC, SubscriberType.NONDURABLE, null);
+        assertNotNull(subscriber);
+        assertEquals(SubscriberType.NONDURABLE, subscriber.getType());
+    }
+
+    @Test
+    void shouldCreateDurableSubscriber() throws Exception {
+        subscriber = new TopicSubscriber("test", TEST_TOPIC, SubscriberType.DURABLE, "client1");
+        assertNotNull(subscriber);
+        assertEquals(SubscriberType.DURABLE, subscriber.getType());
+    }
+
+    @Test
+    void shouldReceiveMessages() throws Exception {
+        subscriber = new TopicSubscriber("test", TEST_TOPIC, SubscriberType.NONDURABLE, null);
+        Thread.sleep(100); // Allow subscriber to initialize
+        
+        publisher.publish(new Message("Test message", TEST_TOPIC));
+        Thread.sleep(500); // Allow message delivery
+        
+        // Verification is done through console output
+        assertTrue(true); // Test passes if no exceptions thrown
+    }
+}