upgrade anti-corruption-layer deps

Author: iluwatar

ambassador/pom.xml

@@ -34,6 +34,14 @@
   <modelVersion>4.0.0</modelVersion>
   <artifactId>ambassador</artifactId>
   <dependencies>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-api</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>ch.qos.logback</groupId>
+      <artifactId>logback-classic</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.junit.jupiter</groupId>
       <artifactId>junit-jupiter-engine</artifactId>

anti-corruption-layer/pom.xml

@@ -45,8 +45,8 @@
       <scope>test</scope>
     </dependency>
     <dependency>
-      <groupId>junit</groupId>
-      <artifactId>junit</artifactId>
+      <groupId>org.junit.jupiter</groupId>
+      <artifactId>junit-jupiter-engine</artifactId>
       <scope>test</scope>
     </dependency>
   </dependencies>

anti-corruption-layer/src/test/java/com/iluwatar/corruption/system/AntiCorruptionLayerTest.java

@@ -30,17 +30,18 @@
 import com.iluwatar.corruption.system.modern.ModernOrder;
 import com.iluwatar.corruption.system.modern.ModernShop;
 import com.iluwatar.corruption.system.modern.Shipment;
-import org.junit.Test;
-import org.junit.runner.RunWith;
+import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.test.context.junit4.SpringRunner;
 
 import java.util.Optional;
 
 import static org.junit.jupiter.api.Assertions.*;
 
-@RunWith(SpringRunner.class)
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.springframework.test.context.junit.jupiter.SpringExtension;
+
+@ExtendWith(SpringExtension.class)
 @SpringBootTest
 public class AntiCorruptionLayerTest {
 
@@ -50,19 +51,13 @@ public class AntiCorruptionLayerTest {
     @Autowired
     private ModernShop modernShop;
 
-
     /**
      * Test the anti-corruption layer.
      * Main intention is to demonstrate how the anti-corruption layer works.
-     * <p>
      * The 2 shops (modern and legacy) should operate independently and in the same time synchronize the data.
-     * To avoid corrupting the domain models of the 2 shops, we use an anti-corruption layer
-     * that transforms one model to another under the hood.
-     *
      */
     @Test
     public void antiCorruptionLayerTest() throws ShopException {
-
         // a new order comes to the legacy shop.
         LegacyOrder legacyOrder = new LegacyOrder("1", "addr1", "item1", 1, 1);
         // place the order in the legacy shop.
@@ -71,41 +66,32 @@ public void antiCorruptionLayerTest() throws ShopException {
         Optional<LegacyOrder> legacyOrderWithIdOne = legacyShop.findOrder("1");
         assertEquals(Optional.of(legacyOrder), legacyOrderWithIdOne);
 
-        // a new order (or maybe just the same order) appears in the modern shop.
+        // a new order (or maybe just the same order) appears in the modern shop
         ModernOrder modernOrder = new ModernOrder("1", new Customer("addr1"), new Shipment("item1", 1, 1), "");
-
         // the system places it, but it checks if there is an order with the same id in the legacy shop.
         modernShop.placeOrder(modernOrder);
 
         Optional<ModernOrder> modernOrderWithIdOne = modernShop.findOrder("1");
         // there is no new order placed since there is already an order with the same id in the legacy shop.
         assertTrue(modernOrderWithIdOne.isEmpty());
-
     }
+
     /**
-     * Test the anti-corruption layer.
-     * Main intention is to demonstrate how the anti-corruption layer works.
-     * <p>
-     * This test tests the anti-corruption layer from the rule the orders should be the same in the both systems.
-     *
+     * Test the anti-corruption layer when a conflict occurs between systems.
+     * This test ensures that an exception is thrown when conflicting orders are placed.
      */
-    @Test(expected = ShopException.class)
+    @Test
     public void antiCorruptionLayerWithExTest() throws ShopException {
-
         // a new order comes to the legacy shop.
         LegacyOrder legacyOrder = new LegacyOrder("1", "addr1", "item1", 1, 1);
         // place the order in the legacy shop.
         legacyShop.placeOrder(legacyOrder);
         // the order is placed as usual since there is no other orders with the id in the both systems.
         Optional<LegacyOrder> legacyOrderWithIdOne = legacyShop.findOrder("1");
         assertEquals(Optional.of(legacyOrder), legacyOrderWithIdOne);
-
         // a new order but with the same id and different data appears in the modern shop
         ModernOrder modernOrder = new ModernOrder("1", new Customer("addr1"), new Shipment("item1", 10, 1), "");
-
         // the system rejects the order since there are 2 orders with contradiction there.
-        modernShop.placeOrder(modernOrder);
-
-
+        assertThrows(ShopException.class, () -> modernShop.placeOrder(modernOrder));
     }
-}
+}

pom.xml

@@ -37,7 +37,7 @@
   <properties>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     <sonar-maven-plugin.version>5.0.0.4389</sonar-maven-plugin.version>
-<!--    <spring-boot.version>2.7.5</spring-boot.version>-->
+    <spring-boot.version>3.4.4</spring-boot.version>
     <jacoco.version>0.8.12</jacoco.version>
     <commons-dbcp.version>1.4</commons-dbcp.version>
     <htmlunit.version>4.7.0</htmlunit.version>
@@ -67,8 +67,8 @@
     <module>active-object</module>
     <module>acyclic-visitor</module>
     <module>adapter</module>
-<!--    <module>ambassador</module>-->
-<!--    <module>anti-corruption-layer</module>-->
+    <module>ambassador</module>
+    <module>anti-corruption-layer</module>
 <!--    <module>arrange-act-assert</module>-->
 <!--    <module>async-method-invocation</module>-->
 <!--    <module>balking</module>-->
@@ -245,6 +245,18 @@
 <!--        <type>pom</type>-->
 <!--        <scope>import</scope>-->
 <!--      </dependency>-->
+
+      <dependency>
+        <groupId>org.springframework.boot</groupId>
+        <artifactId>spring-boot-starter</artifactId>
+        <version>${spring-boot.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>org.springframework.boot</groupId>
+        <artifactId>spring-boot-starter-test</artifactId>
+        <scope>test</scope>
+        <version>${spring-boot.version}</version>
+      </dependency>
       <dependency>
         <groupId>commons-dbcp</groupId>
         <artifactId>commons-dbcp</artifactId>