Skip to content

Commit d727e99

Browse files
committed
Fix Checkstyle issues
1 parent 7c11cba commit d727e99

File tree

5 files changed

+31
-24
lines changed

5 files changed

+31
-24
lines changed

service-stub/src/main/java/com/iluwatar/servicestub/App.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
package com.iluwatar.servicestub;
2+
23
import lombok.extern.slf4j.Slf4j;
34

45
/**

service-stub/src/main/java/com/iluwatar/servicestub/RealSentimentAnalysisServer.java

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
import java.util.Random;
44
import java.util.function.Supplier;
55

6+
/**
7+
* Real implementation of SentimentAnalysisServer.
8+
* Simulates random sentiment classification with processing delay.
9+
*/
10+
611
public class RealSentimentAnalysisServer implements SentimentAnalysisServer {
712
/**
813
* A real sentiment analysis implementation would analyze the input string using, e.g., NLP and
@@ -14,26 +19,26 @@ public class RealSentimentAnalysisServer implements SentimentAnalysisServer {
1419
* @return sentiment classification result (Positive, Negative, or Neutral)
1520
*/
1621

17-
private final Supplier<Integer> sentimentSupplier;
22+
private final Supplier<Integer> sentimentSupplier;
1823

19-
// Constructor
20-
public RealSentimentAnalysisServer(Supplier<Integer> sentimentSupplier) {
21-
this.sentimentSupplier = sentimentSupplier;
22-
}
24+
// Constructor
25+
public RealSentimentAnalysisServer(Supplier<Integer> sentimentSupplier) {
26+
this.sentimentSupplier = sentimentSupplier;
27+
}
2328

24-
public RealSentimentAnalysisServer() {
25-
this(() -> new Random().nextInt(3));
26-
}
29+
public RealSentimentAnalysisServer() {
30+
this(() -> new Random().nextInt(3));
31+
}
2732

28-
@Override
29-
public String analyzeSentiment(String text) {
30-
int sentiment = sentimentSupplier.get();
31-
try {
32-
Thread.sleep(5000);
33-
} catch (InterruptedException e) {
34-
Thread.currentThread().interrupt();
35-
}
36-
return sentiment == 0 ? "Positive" : sentiment == 1 ? "Negative" : "Neutral";
33+
@Override
34+
public String analyzeSentiment(String text) {
35+
int sentiment = sentimentSupplier.get();
36+
try {
37+
Thread.sleep(5000);
38+
} catch (InterruptedException e) {
39+
Thread.currentThread().interrupt();
3740
}
41+
return sentiment == 0 ? "Positive" : sentiment == 1 ? "Negative" : "Neutral";
3842
}
43+
}
3944

service-stub/src/main/java/com/iluwatar/servicestub/StubSentimentAnalysisServer.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
package com.iluwatar.servicestub;
22

3+
/**
4+
* Stub implementation of SentimentAnalysisServer.
5+
* Returns deterministic sentiment based on input keywords.
6+
*/
7+
38
public class StubSentimentAnalysisServer implements SentimentAnalysisServer {
49

510
/**
@@ -13,11 +18,9 @@ public class StubSentimentAnalysisServer implements SentimentAnalysisServer {
1318
public String analyzeSentiment(String text) {
1419
if (text.toLowerCase().contains("good")) {
1520
return "Positive";
16-
}
17-
else if (text.toLowerCase().contains("bad")) {
21+
} else if (text.toLowerCase().contains("bad")) {
1822
return "Negative";
19-
}
20-
else {
23+
} else {
2124
return "Neutral";
2225
}
2326
}
Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
11
package com.iluwatar.servicestub;
22

33
import org.junit.jupiter.api.Test;
4-
54
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
65

76
public class AppTest {
87
@Test
98
void shouldExecuteWithoutException() {
10-
assertDoesNotThrow(() -> App.main(new String[]{}));
9+
assertDoesNotThrow(() -> App.main(new String[] {}));
1110
}
1211
}

service-stub/src/test/java/com/iluwatar/servicestub/RealSentimentAnalysisServerTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import org.junit.jupiter.api.Test;
44
import static org.junit.jupiter.api.Assertions.*;
5-
import java.util.Random;
65

76
class RealSentimentAnalysisServerTest {
87

0 commit comments

Comments
 (0)