fixing more maintainability and intentionality issues

Author: rofidakhaled

entity-component-system/src/main/java/com/iluwatar/App.java

@@ -75,7 +75,6 @@ public static void main(String[] args) {
         velocity1.applyForce(0.5f, 0.0f, 0.0f);
       }
 
-      gameSystem.renderSystem();
     }
   }
 }

entity-component-system/src/main/java/com/iluwatar/Entity.java

@@ -131,6 +131,19 @@ public void addChild(Entity child) {
     }
   }
 
+  /**
+   * Finds a Child Entity in Children List.
+   *
+   * @param entityId the child entity to be removed
+   */
+  public Entity findChildEntity(UUID entityId) {
+    for (Entity child : children) {
+      if (Objects.equals(child.getEntityId(), entityId)) {
+        return child;
+      }
+    }
+    return null;
+  }
 
   /**
    * Removes a child entity from this entity.
@@ -206,15 +219,6 @@ public List<Component> getComponents() {
     return components;
   }
 
-  /**
-   * Renders the entity and its components.
-   */
-  public void renderEntity() {
-    //for (Component component : components) {
-      // Render each component
-    //}
-  }
-
   // Getters and Setters for fields
 
   /**

entity-component-system/src/main/java/com/iluwatar/GameSystem.java

@@ -108,15 +108,6 @@ public void update(float deltaTime) {
     }
   }
 
-  /**
-   * Renders the system (rendering logic can be implemented as needed).
-   */
-  public void renderSystem() {
-    //for (Entity entity : entities) {
-      // Implement rendering logic
-    //}
-  }
-
   /**
    * Sorts the entities by their distance from a given reference point in descending order.
    *

entity-component-system/src/main/java/com/iluwatar/HealthComponent.java

@@ -24,7 +24,7 @@
  */
 package com.iluwatar;
 
-import java.util.logging.Logger;
+
 
 /**
  * Abstract class representing a health component in the ECS system.

entity-component-system/src/main/java/com/iluwatar/VelocityComponent.java

@@ -24,7 +24,6 @@
  */
 package com.iluwatar;
 
-import java.util.logging.Logger;
 
 /**
  * A component that handles the velocity of an entity in 3D space.

entity-component-system/src/test/java/com/iluwatar/AppTest.java

@@ -27,8 +27,6 @@
 import static org.junit.jupiter.api.Assertions.*;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import java.io.ByteArrayOutputStream;
-import java.io.PrintStream;
 
 class AppTest {
 
@@ -108,9 +106,9 @@ void testFinalEntityStateAfterSimulation() {
     GameSystem gameSystem = new GameSystem();
     gameSystem.addEntity(entity1);
     gameSystem.addEntity(entity2);
-    TransformComponent transform1 = new TransformComponent(new float[]{5.0f, 0.0f, 0.0f},
+    TransformComponent Testtransform = new TransformComponent(new float[]{5.0f, 0.0f, 0.0f},
         new float[]{0.0f, 45.0f, 0.0f}, new float[]{1.0f, 1.0f, 1.0f});
-    entity1.setTransformComponent(transform1);
+    entity1.setTransformComponent(Testtransform);
 
     for (int i = 0; i < 10; i++) {
       gameSystem.update(1.0f / 60.0f);

entity-component-system/src/test/java/com/iluwatar/EntityTest.java

@@ -29,7 +29,7 @@
 
 import static org.junit.jupiter.api.Assertions.*;
 
-public class EntityTest {
+ class EntityTest {
 
   private Entity entity1;
   private Entity entity2;
@@ -45,7 +45,6 @@ void setUp() {
         new float[]{0.0f, 0.0f, 0.0f}, new float[]{1.0f, 1.0f, 1.0f});
     transform2 = new TransformComponent(new float[]{5.0f, 0.0f, 0.0f},
         new float[]{0.0f, 45.0f, 0.0f}, new float[]{1.0f, 1.0f, 1.0f});
-
   }
 
   @Test
@@ -131,16 +130,6 @@ void testUpdate() {
     assertNotNull(entity1, "Entity1 should be updated.");
   }
 
-  @Test
- void testRenderEntity() {
-
-    Component component = new HealthComponent(100);
-    Entity entity = new Entity("MyEntity");
-    entity.addComponent(component);
-    entity.renderEntity();
-
-    assertDoesNotThrow(() -> component.update(1.0f), "render function should not throw an exception");
-  }
 
   @Test
  void testGetName() {
@@ -220,6 +209,28 @@ void testUpdate_shouldUpdateChildEntities() {
     entity1.update(1.0f);
     assertDoesNotThrow(() -> child.update(1.0f));
   }
+
+   @Test
+   void testFindChildEntity() {
+    Entity parent = new Entity("parent");
+    Entity child = new Entity("child");
+    child.setParent(parent);
+    parent.addChild(child);
+
+     assertEquals(parent.findChildEntity(child.getEntityId()),child, "The child object should match the one found.");
+
+   }
+
+   @Test
+   void testNotFindChildEntity() {
+     Entity parent = new Entity("parent");
+     Entity child = new Entity("child");
+
+     assertNull(parent.findChildEntity(child.getEntityId()), "The child object should match the one found.");
+
+   }
+
+
 }
 
 

entity-component-system/src/test/java/com/iluwatar/GameSystemTest.java

@@ -98,14 +98,5 @@ void testSortEntitiesByDistance() {
     assertEquals(entity2, sortedEntities.get(0), "Entity2 should be closer to the reference point than Entity1.");
     assertEquals(entity1, sortedEntities.get(1), "Entity1 should be farther from the reference point than Entity2.");
   }
+ }
 
-  @Test
-void testRenderSystem() {
-
-    try {
-      gameSystem.renderSystem();
-    } catch (Exception e) {
-      fail("Render method should not throw any exceptions.");
-    }
-  }
-}

entity-component-system/src/test/java/com/iluwatar/HealthComponentTest.java

@@ -69,45 +69,45 @@ void testUpdateFunction() {
 
   @Test
     void testGetMaxHealth() {
-    HealthComponent TesthealthComponent = new HealthComponent(100f);
+    HealthComponent  testHealthComponent = new HealthComponent(100f);
 
-    assertEquals(100f, TesthealthComponent.getMaxHealth(), "Max health should be 100.");
+    assertEquals(100f,  testHealthComponent.getMaxHealth(), "Max health should be 100.");
   }
 
   @Test
     void testSetMaxHealth() {
-    HealthComponent TesthealthComponent = new HealthComponent(100f);
-    TesthealthComponent.setMaxHealth(120f);
+    HealthComponent  testHealthComponent = new HealthComponent(100f);
+     testHealthComponent.setMaxHealth(120f);
 
-    assertEquals(120f, TesthealthComponent.getMaxHealth(), "Max health should be updated to 120.");
+    assertEquals(120f,  testHealthComponent.getMaxHealth(), "Max health should be updated to 120.");
   }
 
   @Test
     void testIsAlive() {
 
-    HealthComponent TesthealthComponent = new HealthComponent(100f);
-    assertTrue(TesthealthComponent.isAlive(), "Entity should be alive initially.");
-    TesthealthComponent.applyDamage(100f);
+    HealthComponent  testHealthComponent = new HealthComponent(100f);
+    assertTrue( testHealthComponent.isAlive(), "Entity should be alive initially.");
+     testHealthComponent.applyDamage(100f);
 
-    assertFalse(TesthealthComponent.isAlive(), "Entity should be dead after taking 100 damage.");
+    assertFalse( testHealthComponent.isAlive(), "Entity should be dead after taking 100 damage.");
   }
 
   @Test
     void testSetAlive() {
 
-    HealthComponent TesthealthComponent = new HealthComponent(100f);
-    assertTrue(TesthealthComponent.isAlive(), "Entity should be alive initially.");
-    TesthealthComponent.setAlive(false);
+    HealthComponent  testHealthComponent = new HealthComponent(100f);
+    assertTrue( testHealthComponent.isAlive(), "Entity should be alive initially.");
+     testHealthComponent.setAlive(false);
 
-    assertFalse(TesthealthComponent.isAlive(), "Entity should be dead after setting alive to false.");
+    assertFalse( testHealthComponent.isAlive(), "Entity should be dead after setting alive to false.");
   }
 
   @Test
     void testSetCurrentHealth() {
-    HealthComponent TesthealthComponent = new HealthComponent(100f);
-    TesthealthComponent.setCurrentHealth(80f);
+    HealthComponent  testHealthComponent = new HealthComponent(100f);
+     testHealthComponent.setCurrentHealth(80f);
 
-    assertEquals(80f, TesthealthComponent.getCurrentHealth(), "Current health should be updated to 80.");
+    assertEquals(80f,  testHealthComponent.getCurrentHealth(), "Current health should be updated to 80.");
   }
   @Test
     void testHealthCannotGoAboveMax() {

entity-component-system/src/test/java/com/iluwatar/TransformComponentTest.java

@@ -42,15 +42,15 @@ void setUp() {
 
   @Test
     void testTransformComponentConstructor() {
-    TransformComponent Testtransform = new TransformComponent();
+    TransformComponent testTransform = new TransformComponent();
 
     float[] expectedPosition = new float[]{0.0f, 0.0f, 0.0f};
     float[] expectedRotation = new float[]{0.0f, 0.0f, 0.0f};
     float[] expectedScale = new float[]{1.0f, 1.0f, 1.0f};
 
-    assertArrayEquals(expectedPosition, transform.getPosition(), "Position should be initialized to [0.0f, 0.0f, 0.0f]");
-    assertArrayEquals(expectedRotation, transform.getRotation(), "Rotation should be initialized to [0.0f, 0.0f, 0.0f]");
-    assertArrayEquals(expectedScale, transform.getScale(), "Scale should be initialized to [1.0f, 1.0f, 1.0f]");
+    assertArrayEquals(expectedPosition, testTransform.getPosition(), "Position should be initialized to [0.0f, 0.0f, 0.0f]");
+    assertArrayEquals(expectedRotation, testTransform.getRotation(), "Rotation should be initialized to [0.0f, 0.0f, 0.0f]");
+    assertArrayEquals(expectedScale, testTransform.getScale(), "Scale should be initialized to [1.0f, 1.0f, 1.0f]");
   }
 
   @Test
@@ -90,9 +90,9 @@ void testGetScale() {
 
   @Test
     void testUpdateFunction() {
-    TransformComponent Testtransform = new TransformComponent();
+    TransformComponent testTransform = new TransformComponent();
 
-    assertDoesNotThrow(() -> transform.update(1.0f), "update function should not throw an exception");
+    assertDoesNotThrow(() -> testTransform.update(1.0f), "update function should not throw an exception");
   }
 
   @Test