minor formatting log aggregator test

Author: harsh543

microservices-log-aggregation/src/test/java/com/iluwatar/logaggregation/LogAggregatorTest.java

@@ -24,32 +24,31 @@
  */
 package com.iluwatar.logaggregation;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
-// CRITICAL MISSING IMPORTS - FIXED!
-import static org.junit.jupiter.api.Assertions.*;
 
 import java.time.LocalDateTime;
-import java.util.concurrent.TimeUnit;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
 
 /**
- * FIXED Championship Test Suite - LogAggregator
- * 
+ * FIXED Championship Test Suite - LogAggregator.
+ *
  * Fixed to work with the actual LogAggregator API and proper imports
  */
 @ExtendWith(MockitoExtension.class)
 class LogAggregatorTest {
-  
-  @Mock 
-  private CentralLogStore centralLogStore;
-  
+
+  @Mock private CentralLogStore centralLogStore;
+
   private LogAggregator logAggregator;
 
   @BeforeEach
@@ -59,149 +58,132 @@ void setUp() {
 
   @AfterEach
   void tearDown() throws InterruptedException {
-    // 🚀 CHAMPIONSHIP CLEANUP - Properly shutdown the event-driven aggregator
     if (logAggregator != null && logAggregator.isRunning()) {
       logAggregator.stop();
       logAggregator.awaitShutdown();
     }
   }
 
   @Test
-  void whenThreeInfoLogsAreCollected_thenCentralLogStoreShouldStoreAllOfThem() throws InterruptedException {
-    // ELITE FIX: Account for asynchronous threshold-based flushing
+  void whenThreeInfoLogsAreCollected_thenCentralLogStoreShouldStoreAllOfThem()
+      throws InterruptedException {
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Sample log message 1"));
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Sample log message 2"));
-    
-    // At this point, we should have 2 logs in buffer, no flush yet
+
     assertEquals(2, logAggregator.getLogCount());
     verifyNoInteractionsWithCentralLogStore();
-    
-    // Third log should trigger immediate flush (threshold = 3)
+
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Sample log message 3"));
-    
-    // CHAMPIONSHIP WAIT: Allow time for ScheduledExecutorService to process
-    Thread.sleep(1000); // Give executor time to flush
-    
+
+    Thread.sleep(1000);
+
     verifyCentralLogStoreInvokedTimes(3);
-    assertEquals(0, logAggregator.getLogCount()); // Buffer should be empty after flush
+    assertEquals(0, logAggregator.getLogCount());
   }
 
   @Test
   void whenDebugLogIsCollected_thenNoLogsShouldBeStored() throws InterruptedException {
     logAggregator.collectLog(createLogEntry(LogLevel.DEBUG, "Sample debug log message"));
-    
-    // Debug log should be filtered out before reaching buffer
+
     assertEquals(0, logAggregator.getLogCount());
     assertEquals(0, logAggregator.getBufferSize());
-    
-    // Wait a bit to ensure no delayed processing
+
     Thread.sleep(500);
-    
+
     verifyNoInteractionsWithCentralLogStore();
   }
 
   @Test
   void whenTwoLogsCollected_thenBufferShouldContainThem() {
-    // 🎯 NEW TEST: Verify buffer state management
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Message 1"));
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Message 2"));
-    
+
     assertEquals(2, logAggregator.getLogCount());
     assertEquals(2, logAggregator.getBufferSize());
-    
-    // Should not trigger flush yet (threshold is 3)
+
     verifyNoInteractionsWithCentralLogStore();
   }
 
   @Test
   void whenScheduledFlushOccurs_thenBufferedLogsShouldBeStored() throws InterruptedException {
-    // 🏆 NEW TEST: Verify scheduled periodic flushing
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Scheduled flush test"));
-    
+
     assertEquals(1, logAggregator.getLogCount());
     verifyNoInteractionsWithCentralLogStore();
-    
-    // Wait for scheduled flush (FLUSH_INTERVAL_SECONDS = 5)
-    Thread.sleep(6000); // 5 seconds + buffer
-    
+
+    Thread.sleep(6000);
+
     verifyCentralLogStoreInvokedTimes(1);
     assertEquals(0, logAggregator.getLogCount());
   }
 
   @Test
   void whenLogAggregatorStopped_thenRemainingLogsShouldBeStored() throws InterruptedException {
-    // 🚀 NEW TEST: Verify graceful shutdown flushes remaining logs
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Final message 1"));
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Final message 2"));
-    
+
     assertEquals(2, logAggregator.getLogCount());
     verifyNoInteractionsWithCentralLogStore();
-    
-    // Stop should trigger final flush
+
     logAggregator.stop();
     logAggregator.awaitShutdown();
-    
+
     verifyCentralLogStoreInvokedTimes(2);
     assertEquals(0, logAggregator.getLogCount());
     assertFalse(logAggregator.isRunning());
   }
 
   @Test
   void whenLogLevelBelowThreshold_thenLogShouldBeFiltered() {
-    //  FIXED TEST: Only use available log levels
     logAggregator.collectLog(createLogEntry(LogLevel.DEBUG, "Debug message"));
-    
+
     assertEquals(0, logAggregator.getLogCount());
     assertEquals(0, logAggregator.getBufferSize());
     verifyNoInteractionsWithCentralLogStore();
   }
 
   @Test
   void whenLogLevelAtOrAboveThreshold_thenLogShouldBeAccepted() {
-    // FIXED TEST: Use only available log levels (INFO, DEBUG, ERROR)
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Info message"));
     logAggregator.collectLog(createLogEntry(LogLevel.ERROR, "Error message"));
-    
+
     assertEquals(2, logAggregator.getLogCount());
     assertEquals(2, logAggregator.getBufferSize());
   }
 
   @Test
   void whenNullLogLevelProvided_thenLogShouldBeSkipped() {
-    //  EDGE CASE TEST: Null safety
-    LogEntry nullLevelEntry = new LogEntry("ServiceA", null, "Null level message", LocalDateTime.now());
-    
+    LogEntry nullLevelEntry =
+        new LogEntry("ServiceA", null, "Null level message", LocalDateTime.now());
+
     logAggregator.collectLog(nullLevelEntry);
-    
+
     assertEquals(0, logAggregator.getLogCount());
     verifyNoInteractionsWithCentralLogStore();
   }
 
   @Test
   void whenLogAggregatorIsShutdown_thenNewLogsShouldBeRejected() throws InterruptedException {
-    //  NEW TEST: Verify shutdown behavior
     logAggregator.stop();
     logAggregator.awaitShutdown();
-    
+
     assertFalse(logAggregator.isRunning());
-    
-    // Try to add log after shutdown
+
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Post-shutdown message"));
-    
+
     assertEquals(0, logAggregator.getLogCount());
     verifyNoInteractionsWithCentralLogStore();
   }
 
   @Test
   void testBasicFunctionality() throws InterruptedException {
-    // SIMPLIFIED TEST: Basic functionality without advanced features
     assertTrue(logAggregator.isRunning());
-    
+
     logAggregator.collectLog(createLogEntry(LogLevel.INFO, "Basic test"));
     assertEquals(1, logAggregator.getLogCount());
   }
 
-   private static LogEntry createLogEntry(LogLevel logLevel, String message) {
+  private static LogEntry createLogEntry(LogLevel logLevel, String message) {
     return new LogEntry("ServiceA", logLevel, message, LocalDateTime.now());
   }
 
@@ -212,4 +194,4 @@ private void verifyNoInteractionsWithCentralLogStore() {
   private void verifyCentralLogStoreInvokedTimes(int times) {
     verify(centralLogStore, times(times)).storeLog(any());
   }
-}
+}