Fix Singleton typo and extend reflection handling to remaining implementations #3203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR SummaryThis PR fixes a typo and extends reflection handling to several Singleton implementations. It adds exception handling to prevent instantiation via reflection in Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (2)
Files Processed (6)
- singleton/src/main/java/com/iluwatar/singleton/BillPughImplementation.java (1 hunk)
- singleton/src/main/java/com/iluwatar/singleton/InitializingOnDemandHolderIdiom.java (1 hunk)
- singleton/src/main/java/com/iluwatar/singleton/IvoryTower.java (1 hunk)
- singleton/src/test/java/com/iluwatar/singleton/EnumIvoryTowerTest.java (2 hunks)
- singleton/src/test/java/com/iluwatar/singleton/SingletonTest.java (2 hunks)
- singleton/src/test/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLockingTest.java (2 hunks)
Actionable Comments (0)
Skipped Comments (3)
-
singleton/src/main/java/com/iluwatar/singleton/BillPughImplementation.java [42-46]
readability: "Remove redundant comment."
-
singleton/src/main/java/com/iluwatar/singleton/InitializingOnDemandHolderIdiom.java [45-49]
readability: "Remove redundant comment."
-
singleton/src/main/java/com/iluwatar/singleton/IvoryTower.java [35-39]
readability: "Remove redundant comment."
smile-ab
force-pushed
the
singleton-typo-and-reflection-handling
branch
from
b8ea511 to
28bb7da
Compare
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (2)
Files Processed (6)
- singleton/src/main/java/com/iluwatar/singleton/BillPughImplementation.java (1 hunk)
- singleton/src/main/java/com/iluwatar/singleton/InitializingOnDemandHolderIdiom.java (1 hunk)
- singleton/src/main/java/com/iluwatar/singleton/IvoryTower.java (1 hunk)
- singleton/src/test/java/com/iluwatar/singleton/EnumIvoryTowerTest.java (2 hunks)
- singleton/src/test/java/com/iluwatar/singleton/SingletonTest.java (2 hunks)
- singleton/src/test/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLockingTest.java (2 hunks)
Actionable Comments (0)
Skipped Comments (3)
-
singleton/src/main/java/com/iluwatar/singleton/BillPughImplementation.java [42-46]
readability: "Remove redundant comment."
-
singleton/src/main/java/com/iluwatar/singleton/InitializingOnDemandHolderIdiom.java [45-49]
readability: "Remove redundant comment."
-
singleton/src/main/java/com/iluwatar/singleton/IvoryTower.java [35-39]
readability: "Remove redundant comment."
|
iluwatar
approved these changes
Mar 18, 2025
Owner
|
Looks good! Thank you for the contribution 🎉 @all-contributors please add @smile-ab for code |
Contributor
|
I've put up a pull request to add @smile-ab! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix typo and extend reflection handling for remaining implementations for the Singleton pattern
Issue:
#3202