Skip to content

TLS and default values documented but not implemented #7

@forbish

Description

@forbish

Hi,

Really appreciate your good work on this plugin so far. I've run across a couple of documented features that don't appear to be fully implemented:

  1. The readme shows endpoint.tls.ignoreInsecure but the public Endpoint struct has no TLS field. The internal implementation has it but it's not wired to the public API, the result being that the config is silently ignored.

  2. The readme states defaults of pollInterval=5s, connTimeout=15s but CreateConfig() returns an empty struct, causing validation errors when these fields are omitted.

I have a fix ready, tested locally, and will submit a PR shortly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions