self-review

Author: targos

demo/components/CameraFeed.tsx

@@ -11,9 +11,13 @@ export default function CameraFeed() {
     const video = videoRef.current;
     if (!video || !selectedCamera) return;
     video.srcObject = selectedCamera.stream;
-    video.addEventListener('loadedmetadata', () => {
+    const onLoadedMetadata = () => {
       video.play().catch((error: unknown) => console.error(error));
-    });
+    };
+    video.addEventListener('loadedmetadata', onLoadedMetadata);
+    return () => {
+      video.removeEventListener('loadedmetadata', onLoadedMetadata);
+    };
   }, [selectedCamera]);
   if (!selectedCamera) {
     return <UnavailableCamera />;

demo/components/CameraTransform.tsx

@@ -38,7 +38,7 @@ export default function CameraTransform(props: CameraTransformProps) {
     const video = videoRef.current as HTMLVideoElement;
     let nextFrameRequest: number;
     video.srcObject = selectedCamera.stream;
-    video.addEventListener('loadedmetadata', () => {
+    const onLoadedMetadata = () => {
       video
         .play()
         .then(() => {
@@ -71,9 +71,11 @@ export default function CameraTransform(props: CameraTransformProps) {
           nextFrameRequest = requestAnimationFrame(nextFrame);
         })
         .catch((error_: unknown) => console.error(error_));
-    });
+    };
+    video.addEventListener('loadedmetadata', onLoadedMetadata);
 
     return () => {
+      video.removeEventListener('loadedmetadata', onLoadedMetadata);
       if (nextFrameRequest) {
         cancelAnimationFrame(nextFrameRequest);
       }

src/__tests__/Image.test.ts

@@ -221,7 +221,7 @@ test('getCoordinates - with rounding', () => {
 test('getCoordinates - bad parameter', () => {
   const img = new Image(4, 5);
   // @ts-expect-error bad parameter
-  expect(() => img.getCoordinates('bad')).toThrow(/bad/);
+  expect(() => img.getCoordinates('bad')).toThrow('bad');
 });
 
 test('fill with a constant color', () => {