Use `setBlendedPixel` in draw* methods

[targos]

[EscapedGibbon]

I have a question regarding the way to fix it. Currently draw* functions use setVisiblePixel to modify values and they modify them only if the pixel is in bounds of the image. setBlendedPixel doesn't do that. So by changing the function the draw* function's behavior will change as well. Therefore my question is how to modify in a more correct way? Should I change setValue which is used in setBlendedPixel? Or should I add a check in functions themselves?
Also after I made the former modification (added check to setValue), I stumbled on the test below that doesn't pass and I wonder if such an implementation is fine.

image-js-typescript/src/__tests__/Image.test.ts

Lines 151 to 157 in ec04a57

	it('should get and set value by point', () => {
	const point = { column: 15, row: 0 };
	const img = new Image(10, 20);
	expect(img.getValueByPoint(point, 0)).toBe(0);
	img.setValueByPoint(point, 0, 50);
	expect(img.getValueByPoint(point, 0)).toBe(50);
	});

There is no error but the point coordinates modified in the test will actually be {row:1, column:5}, right?
WDYT?

[stropitek]

I haven't fully understood what you changed.

Maybe before explaining how you are going to change the code, can you explain what setBlendedPixel was doing differently than setVisiblePixel, and what you think is the correct behaviour. My understanding from your explanation is just that calling setVisiblePixel on an out of bound pixel is a noop, but not when calling setBlendedPixel.

[EscapedGibbon]

Yes. And I am not sure if it's okay to call setBlendedPixel and have the possibility to modify the value that was not intended to be modified.