Eliminate some bounds checks in IDCT (#167)

Convert a debug assert into an actual bounds check to use as an optimizer hint.

Eliminates a bunch of bounds checks and should speed things up.
Support older rustc, hence no try_from or type changes.

Author: Shnatsel

src/idct.rs

@@ -2,10 +2,7 @@
 // One example is tests/crashtest/images/imagetestsuite/b0b8914cc5f7a6eff409f16d8cc236c5.jpg
 // That's why wrapping operators are needed.
 use crate::parser::Dimensions;
-use std::{
-    convert::TryFrom,
-    num::Wrapping,
-};
+use std::{convert::TryFrom, num::Wrapping};
 
 pub(crate) fn choose_idct_size(full_size: Dimensions, requested_size: Dimensions) -> usize {
     fn scaled(len: u16, scale: usize) -> u16 { ((len as u32 * scale as u32 - 1) / 8 + 1) as u16 }
@@ -54,7 +51,6 @@ pub fn dequantize_and_idct_block_8x8(
     output_linestride: usize,
     output: &mut [u8]
 ) {
-    debug_assert_eq!(coefficients.len(), 64);
     let output = output
         .chunks_mut(output_linestride);
     dequantize_and_idct_block_8x8_inner(coefficients, quantization_table, output)
@@ -76,6 +72,9 @@ fn dequantize_and_idct_block_8x8_inner<'a, I>(
         output.len()
     );
 
+    // optimizer hint to eliminate bounds checks within loops
+    assert!(coefficients.len() == 64);
+
     let mut temp = [Wrapping(0); 64];
 
     // columns