Skip to content

Commit a86a73b

Browse files
committed
Signed url fix, default expiry
1 parent dd9b845 commit a86a73b

File tree

4 files changed

+13
-11
lines changed

4 files changed

+13
-11
lines changed

README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ allprojects {
4343
Step 2. Add the dependency on project's `build.gradle`:
4444
```
4545
dependencies {
46-
implementation 'com.github.imagekit-developer:imagekit-java:1.0.2'
46+
implementation 'com.github.imagekit-developer:imagekit-java:1.0.3'
4747
}
4848
```
4949
### Maven users
@@ -61,7 +61,7 @@ Step 2. Add the dependency in POM file:
6161
<dependency>
6262
<groupId>com.github.imagekit-developer</groupId>
6363
<artifactId>imagekit-java</artifactId>
64-
<version>1.0.2</version>
64+
<version>1.0.3</version>
6565
</dependency>
6666
```
6767

@@ -122,7 +122,7 @@ String url = ImageKit.getInstance().getUrl(options);
122122
```
123123
The result in a URL like
124124
```
125-
https://ik.imagekit.io/your_imagekit_id/tr:w-400,h-600/default-image.jpg?v=123&ik-sdk-version=java-1.0.2
125+
https://ik.imagekit.io/your_imagekit_id/tr:w-400,h-600/default-image.jpg?v=123&ik-sdk-version=java-1.0.3
126126
```
127127

128128
**2. Using full image URL**
@@ -147,7 +147,7 @@ String url = ImageKit.getInstance().getUrl(options);
147147
The results in a URL like
148148

149149
```
150-
https://ik.imagekit.io/your_imagekit_id/default-image.jpg?tr=w-400,h-600&ik-sdk-version=java-1.0.2
150+
https://ik.imagekit.io/your_imagekit_id/default-image.jpg?tr=w-400,h-600&ik-sdk-version=java-1.0.3
151151
```
152152

153153
The ```.getUrl()``` method accepts the following parameters
@@ -187,7 +187,7 @@ String url = ImageKit.getInstance().getUrl(options);
187187

188188
Sample Result URL -
189189
```
190-
https://ik.imagekit.io/your_imagekit_id/default-image.jpg?tr=h-300&w-400:rt-90&ik-sdk-version=java-1.0.2
190+
https://ik.imagekit.io/your_imagekit_id/default-image.jpg?tr=h-300&w-400:rt-90&ik-sdk-version=java-1.0.3
191191
```
192192

193193
**2. Sharpening and contrast transforms and a progressive JPG image**
@@ -215,7 +215,7 @@ String url = ImageKit.getInstance().getUrl(options);
215215
Note that because the `src` parameter was used, the transformation string gets added as a query parameter.
216216

217217
```
218-
https://ik.imagekit.io/your_imagekit_id/default-image.jpg?tr=f-jpg&pr-true&e-sharpen&e-contrast-1&ik-sdk-version=java-1.0.2
218+
https://ik.imagekit.io/your_imagekit_id/default-image.jpg?tr=f-jpg&pr-true&e-sharpen&e-contrast-1&ik-sdk-version=java-1.0.3
219219
```
220220

221221
**3. Signed URL that expires in 300 seconds with the default URL endpoint and other query parameters**
@@ -236,7 +236,7 @@ String url = ImageKit.getInstance().getUrl(options);
236236
```
237237
**Sample Result URL**
238238
```
239-
https://ik.imagekit.io/your_imagekit_id/tr:h-600,w-400/default-image.jpg?ik-t=1567358667&ik-s=f2c7cdacbe7707b71a83d49cf1c6110e3d701054&ik-sdk-version=java-1.0.2
239+
https://ik.imagekit.io/your_imagekit_id/tr:h-600,w-400/default-image.jpg?ik-t=1567358667&ik-s=f2c7cdacbe7707b71a83d49cf1c6110e3d701054&ik-sdk-version=java-1.0.3
240240
```
241241

242242
**List of transformations**

imagekit-sdk/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ plugins {
44
}
55

66
group 'io.imagekit.sdk'
7-
version '1.0.2'
7+
version '1.0.3'
88

99
sourceCompatibility = 1.8
1010

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
package io.imagekit.sdk.constants;
22

33
public class Version {
4-
public static final String VERSION_CODE="java-1.0.2";
4+
public static final String VERSION_CODE="java-1.0.3";
55
}

imagekit-sdk/src/main/java/io/imagekit/sdk/tasks/UrlGen.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,10 @@ private static void sign(String urlEndpoint, long expireSeconds, String privateK
194194
long expiryTimestamp = DEFAULT_TIMESTAMP;
195195
if (expireSeconds > 0){
196196
expiryTimestamp = ((Calendar.getInstance().getTimeInMillis()/1000)+ expireSeconds);
197-
String signature = signUrl(privateKey, tmpUri.toString(), urlEndpoint,expiryTimestamp);
198-
queryMaker.put("ik-s=" + signature);
197+
}
198+
String signature = signUrl(privateKey, tmpUri.toString(), urlEndpoint,expiryTimestamp);
199+
queryMaker.put("ik-s=" + signature);
200+
if(expiryTimestamp > 0 && expiryTimestamp != DEFAULT_TIMESTAMP) {
199201
queryMaker.put("ik-t=" + expiryTimestamp);
200202
}
201203
}

0 commit comments

Comments
 (0)