new transformations added, test coverage improved

Author: abhinavr4

constants/supportedTransforms.js

@@ -2,6 +2,18 @@ module.exports = {
     "height": "h",
     "width": "w",
     "aspectRatio": "ar",
+    "padResizeCrop": "cm-pad_resize",
+    "forcedCrop": "c-force",
+    "maxSizeCrop": "c-at_max",
+    "minSizeCrop": "c-at_least",
+    "maintainRatioCrop": "c-maintain_ratio",
+    "extractCrop": "cm-extract",
+    "padExtractCrop": "cm-pad_extract",
+    "autoSmartCrop": "fo-auto",
+    "faceCrop": "fo-face",
+    "focusCustom": "fo-custom",
+    "xc": "xc",
+    "yc": "yc",
     "quality": "q",
     "crop": "c",
     "cropMode": "cm",
@@ -13,7 +25,6 @@ module.exports = {
     "background": "bg",
     "border": "b",
     "rotation": "rt",
-    "rotate": "rt",
     "blur": "bl",
     "named": "n",
     "overlayImage": "oi",
@@ -43,6 +54,21 @@ module.exports = {
     "overlayTextPadding": "otp",
     "overlayTextInnerAlignment": "otia",
     "overlayRadius": "or",
+    "overlayMinSizeCrop": "oic-at_least",
+    "overlayMaxSizeCrop": "oic-at_max",
+    "overlayForcedCrop": "oic-force",
+    "overlayMaintainRatioCrop": "oic-maintain_ratio",
+    "overlayExtractCrop": "oicm-extract",
+    "overlayPadExtractCrop": "oicm-pad_extract",
+    "overlayPadResizeCrop": "oicm-pad_resize",
+    "overlayFocusCrop": "oifo",
+    "overlayAutoSmartCrop": "oifo-auto",
+    "overlayFocusCustom": "oifo-custom",
+    "overlayFaceCrop": "oifo-face",
+    "oixc": "oixc",
+    "oiyc": "oiyc",
+    "oix": "oix",
+    "oiy": "oiy",
     "progressive": "pr",
     "lossless": "lo",
     "trim": "t",

libs/manage/file.js

@@ -202,8 +202,8 @@ module.exports.bulkRemoveTags = function(fileIdArray, tags, defaultOptions, call
 */
 module.exports.copyFile = function(sourceFilePath, destinationPath, defaultOptions, callback) {
 
-    if(sourceFilePath.length === 0 || typeof(sourceFilePath) !== 'string'
-        || destinationPath.length === 0 || typeof(destinationPath) !== 'string') {
+    if(typeof(destinationPath) !== 'string' || typeof(sourceFilePath) !== 'string'
+        || destinationPath.length === 0 || sourceFilePath.length === 0) {
         respond(true, errorMessages.INVALID_DIRECTORY_PATH, callback);
         return;
     }
@@ -227,8 +227,8 @@ module.exports.copyFile = function(sourceFilePath, destinationPath, defaultOptio
 */
 module.exports.moveFile = function(sourceFilePath, destinationPath, defaultOptions, callback) {
 
-    if(sourceFilePath.length === 0 || typeof(sourceFilePath) !== 'string'
-        || destinationPath.length === 0 || typeof(destinationPath) !== 'string') {
+    if(typeof(destinationPath) !== 'string' || typeof(sourceFilePath) !== 'string'
+        || destinationPath.length === 0 || sourceFilePath.length === 0) {
         respond(true, errorMessages.INVALID_DIRECTORY_PATH, callback);
         return;
     }
@@ -252,8 +252,8 @@ module.exports.moveFile = function(sourceFilePath, destinationPath, defaultOptio
 */
 module.exports.copyFolder = function(sourceFolderPath, destinationPath, defaultOptions, callback) {
 
-    if(sourceFolderPath.length === 0 || typeof(sourceFolderPath) !== 'string'
-        || destinationPath.length === 0 || typeof(destinationPath) !== 'string') {
+    if(typeof(destinationPath) !== 'string' || typeof(sourceFolderPath) !== 'string'
+        || destinationPath.length === 0 || sourceFolderPath.length === 0) {
         respond(true, errorMessages.INVALID_DIRECTORY_PATH, callback);
         return;
     }
@@ -277,8 +277,8 @@ module.exports.copyFolder = function(sourceFolderPath, destinationPath, defaultO
 */
 module.exports.moveFolder = function(sourceFolderPath, destinationPath, defaultOptions, callback) {
 
-    if(sourceFolderPath.length === 0 || typeof(sourceFolderPath) !== 'string'
-        || destinationPath.length === 0 || typeof(destinationPath) !== 'string') {
+    if(typeof(destinationPath) !== 'string' || typeof(sourceFolderPath) !== 'string'
+        || destinationPath.length === 0 || sourceFolderPath.length === 0) {
         respond(true, errorMessages.INVALID_DIRECTORY_PATH, callback);
         return;
     }
@@ -302,12 +302,12 @@ module.exports.moveFolder = function(sourceFolderPath, destinationPath, defaultO
 */
 module.exports.createFolder = function(folderName, parentFolderPath, defaultOptions, callback) {
 
-    if(folderName.length === 0 || typeof(folderName) !== 'string') {
+    if(typeof(folderName) !== 'string' || folderName.length === 0) {
         respond(true, errorMessages.INVALID_FOLDER_NAME, callback);
         return;
     }
 
-    if(parentFolderPath.length === 0 || typeof(parentFolderPath) !== 'string') {
+    if(typeof(parentFolderPath) !== 'string' || parentFolderPath.length === 0) {
         respond(true, errorMessages.INVALID_DIRECTORY_PATH, callback);
         return;
     }
@@ -331,7 +331,7 @@ module.exports.createFolder = function(folderName, parentFolderPath, defaultOpti
 */
 module.exports.deleteFolder = function(folderPath, defaultOptions, callback) {
 
-    if(folderPath.length === 0 || typeof(folderPath) !== 'string') {
+    if(typeof(folderPath) !== 'string' || folderPath.length === 0) {
         respond(true, errorMessages.INVALID_DIRECTORY_PATH, callback);
         return;
     }