threshold test coverage 95%

Author: manu4543

.nycrc

@@ -0,0 +1,4 @@
+{
+  "check-coverage": true,
+  "lines": 95
+}

README.md

@@ -97,7 +97,7 @@ The `.url()` method accepts the following parameters
 | path             | Conditional. This is the path at which the image exists. For example, `/path/to/image.jpg`. Either the `path` or `src` parameter need to be specified for URL generation. |
 | src              | Conditional. This is the complete URL of an image already mapped to ImageKit. For example, `https://ik.imagekit.io/your_imagekit_id/endpoint/path/to/image.jpg`. Either the `path` or `src` parameter need to be specified for URL generation. |
 | transformation   | Optional. An array of objects specifying the transformation to be applied in the URL. The transformation name  and the value should be specified as a key-value pair in the object. Different steps of a [chained transformation](https://docs.imagekit.io/features/image-transformations/chained-transformations) can be specified as different objects of the array. The complete list of supported transformations in the SDK and some examples of using them are given later. If you use a transformation name that is not specified in the SDK, it gets applied as it is in the URL. |
-| transformationPostion | Optional. Default value is `path` that places the transformation string as a path parameter in the URL. Can also be specified as `query` which adds the transformation string as the query parameter `tr` in the URL. If you use `src` parameter to create the URL, then the transformation string is always added as a query parameter. |
+| transformationPosition | Optional. Default value is `path` that places the transformation string as a path parameter in the URL. Can also be specified as `query` which adds the transformation string as the query parameter `tr` in the URL. If you use `src` parameter to create the URL, then the transformation string is always added as a query parameter. |
 | queryParameters  | Optional. These are the other query parameters that you want to add to the final URL. These can be any query parameters and not necessarily related to ImageKit. Especially useful, if you want to add some versioning parameter to your URLs. |
 | signed           | Optional. Boolean. Default is `false`. If set to `true`, the SDK generates a signed image URL adding the image signature to the image URL. If you are creating URL using `src` parameter instead of `path` then do correct `urlEndpoint` for this to work. Otherwise returned URL will have wrong signature |
 | expireSeconds    | Optional. Integer. Meant to be used along with the `signed` parameter to specify the time in seconds from now when the URL should expire. If specified, the URL contains the expiry timestamp in the URL and the image signature is modified accordingly. |

libs/url/builder.js

@@ -132,7 +132,7 @@ function constructTransformationString(transformation) {
             } else {
                 var value = transformation[i][key];
                 if(transformKey === "oi" || transformKey === "di") {
-                    value = removeTrailingSlash(removeLeadingSlash(value));
+                    value = urlFormatter.removeTrailingSlash(urlFormatter.removeLeadingSlash(value));
                     value = value.replace(/\//g,"@@");
                 }
                 parsedTransformStep.push([transformKey, value].join(transformationUtils.getTransformKeyValueDelimiter()));
@@ -145,20 +145,6 @@ function constructTransformationString(transformation) {
     return parsedTransforms.join(transformationUtils.getChainTransformDelimiter());
 }
 
-function removeTrailingSlash(str) {
-    if (typeof str == "string" && str[str.length - 1] == "/") {
-        str = str.substring(0, str.length - 1);
-    }
-    return str;
-}
-
-function removeLeadingSlash(str) {
-    if (typeof str == "string" && str[0] == "/") {
-        str = str.slice(1);
-    }
-    return str;
-}
-
 function getSignatureTimestamp(seconds) {
     if(!seconds) return DEFAULT_TIMESTAMP;
 

package.json

@@ -1,12 +1,12 @@
 {
   "name": "imagekit",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "Offical NodeJS SDK for ImageKit.io integration",
   "main": "index.js",
   "scripts": {
     "lint": "./node_modules/eslint/bin/eslint.js tests/ utils/phash.js",
     "lint:fix": "./node_modules/eslint/bin/eslint.js --fix tests/ utils/phash.js",
-    "test": "export NODE_ENV=test; nyc ./node_modules/mocha/bin/mocha --coverage --exit -t 40000 tests/*.js;ex=$?;unset NODE_ENV; exit $ex;",
+    "test": "export NODE_ENV=test; nyc ./node_modules/mocha/bin/mocha --exit -t 40000 tests/*.js;ex=$?;unset NODE_ENV; exit $ex;",
     "report-coverage": "nyc report --reporter=text-lcov > coverage.lcov && codecov"
   },
   "author": "ImageKit Developer <[email protected]>",

tests/upload.js

@@ -189,6 +189,24 @@ describe("File upload", function () {
         },10); 
     });
 
+    it('Success using promise', function (done) {
+        const fileOptions = {
+            fileName: "test_file_name",
+            file: "test_file_content"
+        };
+
+        const scope = nock('https://api.imagekit.io')
+            .post('/v1/files/upload')
+            .basicAuth({ user: initializationParams.privateKey, pass: '' })
+            .reply(200, uploadSuccessResponseObj)
+
+        imagekit.upload(fileOptions)
+        .then((response, error) => {
+            expect(response).to.been.deep.equal(uploadSuccessResponseObj)
+            done();
+        });
+    });
+
     it('Network error', function (done) {
         const fileOptions = {
             fileName: "test_file_name",
@@ -237,4 +255,29 @@ describe("File upload", function () {
             done();
         },10);
     });
+
+    it('Server side error promise', function (done) {
+        const fileOptions = {
+            fileName: "test_file_name",
+            file: "test_file_content"
+        };
+
+        var error = {
+            help: "For support kindly contact us at [email protected] .",
+            message: "Your account cannot be authenticated."
+        };
+
+        const scope = nock('https://api.imagekit.io')
+            .post('/v1/files/upload')
+            .basicAuth({ user: initializationParams.privateKey, pass: '' })
+            .reply(403, error)
+
+        imagekit.upload(fileOptions)
+            .then((response, error) => {
+            })
+            .catch(error => {
+                expect(error).to.been.deep.equal(error)
+                done();
+            })
+    });
 });

tests/url-generation.js

@@ -87,7 +87,7 @@ describe("URL generation", function () {
 
     });
 
-    it('should generate the correct url with path param with transformationPostion as query', function () {
+    it('should generate the correct url with path param with transformationPosition as query', function () {
         const url = imagekit.url({
             path: "/test_path.jpg",
             transformationPosition: "query",
@@ -112,7 +112,7 @@ describe("URL generation", function () {
         expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?tr=h-300%2Cw-400`);
     });
 
-    it('should generate the correct url with transformationPostion as query', function () {
+    it('should generate the correct url with transformationPosition as query', function () {
         const url = imagekit.url({
             src: "https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg",
             transformationPosition: "query",

utils/urlFormatter.js

@@ -1,11 +1,3 @@
-module.exports.addLeadingQuestionMark = function(str) {
-    if(typeof str == "string" && str[0] != "?") {
-        str = "?" + str;
-    }
-
-    return str;
-}
-
 module.exports.addLeadingSlash = function(str) {
     if(typeof str == "string" && str[0] != "/") {
         str = "/" + str;