use rstrip to conditionally remove trailing slash in netloc

Saurav Tiwary · Saurav Tiwary · commit 03fa045a4c7e · 2020-04-24T15:54:30.000+05:30
Signed-off-by: Saurav Tiwary &lt;saurav.tiwary@mindship.io&gt;
diff --git a/imagekitio/url.py b/imagekitio/url.py
@@ -114,7 +114,7 @@ def build_url(self, options: dict) -> str:
             expiry_timestamp = self.get_signature_timestamp(expire_seconds)
 
             # remove the trailing slash('/') from the netloc since `urlunparse` adds it
-            result_url_dict['netloc'] = result_url_dict['netloc'][:-1]
+            result_url_dict["netloc"].rstrip("/")
             intermediate_url = urlunparse(
                 result_url_dict.get(f, "") for f in ParseResult._fields
             )

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ def build_url(self, options: dict) -> str:`
`114`	`114`	`expiry_timestamp = self.get_signature_timestamp(expire_seconds)`
`115`	`115`
`116`	`116`	# remove the trailing slash('/') from the netloc since `urlunparse` adds it
`117`		`- result_url_dict['netloc'] = result_url_dict['netloc'][:-1]`
	`117`	`+ result_url_dict["netloc"].rstrip("/")`
`118`	`118`	`intermediate_url = urlunparse(`
`119`	`119`	`result_url_dict.get(f, "") for f in ParseResult._fields`
`120`	`120`	`)`