Skip to content

Commit 3b1d7ea

Browse files
manu4543manu4543
committed
test cases readability
1 parent d48b32b commit 3b1d7ea

File tree

3 files changed

+31
-66
lines changed

3 files changed

+31
-66
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "imagekitio-react",
3-
"version": "1.0.7",
3+
"version": "1.0.8",
44
"description": "React SDK for ImageKit.io which implements client-side upload and URL generation for use inside a react application.",
55
"scripts": {
66
"build": "rm -rf dist*;rollup -c",

‎src/components/IKImage/index.js‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,15 @@ class IKImage extends ImageKitComponent {
4242
if (lqip && lqip.active) {
4343
var quality = parseInt((lqip.quality || lqip.threshold), 10) || 20;
4444
var blur = parseInt((lqip.blur || lqip.blur), 10) || 6;
45-
options.transformation = options.transformation || [];
46-
options.transformation.push({
45+
var newTransformation = options.transformation ? [...options.transformation] : [];
46+
newTransformation.push({
4747
quality,
4848
blur
4949
})
50-
result.lqipSrc = ikClient.url(options);
50+
result.lqipSrc = ikClient.url({
51+
...options,
52+
transformation: newTransformation
53+
});
5154
}
5255

5356
return result;

‎src/test/IKImage.test.js‎

Lines changed: 24 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,7 @@ describe('IKImage', () => {
1414
describe('Absolute image path', () => {
1515
test("src with alt attribute", () => {
1616
const ikImage = shallow(<IKImage urlEndpoint={urlEndpoint} src={absolutePath} alt={'some text here'} />);
17-
// <img alt="abc" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg
18-
// ?ik-sdk-version=react-1.0.7"/>
19-
17+
2018
expect(ikImage.find('img').prop('src')).toEqual(`${absolutePath}?${global.SDK_VERSION}`);
2119
expect(ikImage.find('img').prop('alt')).toEqual('some text here');
2220

@@ -30,10 +28,8 @@ describe('IKImage', () => {
3028
queryParameters={{ version: 5, name: 'check' }}
3129
/>
3230
);
33-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg?foo=bar
34-
// &ik-sdk-version=react-1.0.7&version=5&name=check"/>
35-
36-
const transformURL = `${absolutePath}?foo=bar&${global.SDK_VERSION}&version=5&name=check`;
31+
32+
const transformURL = `${absolutePathWithQuery}&${global.SDK_VERSION}&version=5&name=check`;
3733
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
3834
});
3935

@@ -47,9 +43,7 @@ describe('IKImage', () => {
4743
width: 400
4844
}]} />
4945
);
50-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg
51-
// ?ik-sdk-version=react-1.0.7&tr=h-300%2Cw-400"/>
52-
46+
5347
const transformURL = `${absolutePath}?${global.SDK_VERSION}&tr=h-300%2Cw-400`;
5448
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
5549
});
@@ -58,9 +52,7 @@ describe('IKImage', () => {
5852
const ikImage = shallow(
5953
<IKImage urlEndpoint={urlEndpoint} lqip={{ active: true, quality: 20 }} src={absolutePath} id="lqip" />
6054
);
61-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg
62-
// ?ik-sdk-version=react-1.0.7&tr=q-20%2Cbl-6" id="lqip"/>
63-
55+
6456
const transformURL = `${absolutePath}?${global.SDK_VERSION}&tr=q-20%2Cbl-6`;
6557
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
6658
});
@@ -78,9 +70,7 @@ describe('IKImage', () => {
7870
id="lqip"
7971
/>
8072
);
81-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg
82-
// ?ik-sdk-version=react-1.0.7&tr=h-300%2Cw-400%3Aq-20%2Cbl-6" id="lqip"/>
83-
73+
8474
const transformURL = `${absolutePath}?${global.SDK_VERSION}&tr=h-300%2Cw-400%3Aq-20%2Cbl-6`;
8575
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
8676
});
@@ -89,8 +79,7 @@ describe('IKImage', () => {
8979
describe('Relative image path', () => {
9080
test("path with alt attribute", () => {
9181
const ikImage = shallow(<IKImage urlEndpoint={urlEndpoint} path={relativePath} alt={'some text here'} />);
92-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg?ik-sdk-version=react-1.0.7"/>
93-
82+
9483
expect(ikImage.find('img').prop('src')).toEqual(`${urlEndpoint}/${relativePath}?${global.SDK_VERSION}`);
9584
expect(ikImage.find('img').prop('alt')).toEqual('some text here');
9685
});
@@ -99,36 +88,30 @@ describe('IKImage', () => {
9988
const ikImage = shallow(
10089
<IKImage urlEndpoint={urlEndpoint} path={relativePath} queryParameters={{ version: 5, name: 'check' }} />
10190
);
102-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg?ik-sdk-version=react-1.0.7
103-
// &version=5&name=check"/>
104-
91+
10592
const transformURL = `${urlEndpoint}/${relativePath}?${global.SDK_VERSION}&version=5&name=check`;
10693
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
10794
});
10895

10996
test("path having leading slashes", () => {
11097
const ikImage = shallow(<IKImage urlEndpoint={urlEndpoint} path="////default-image.jpg" />);
111-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg?ik-sdk-version=react-1.0.7"/>
112-
113-
expect(ikImage.find('img').prop('src')).toEqual(`${urlEndpoint}/${relativePath}?${global.SDK_VERSION}`);
98+
99+
expect(ikImage.find('img').prop('src')).toEqual(`${urlEndpoint}/default-image.jpg?${global.SDK_VERSION}`);
114100
});
115101

116102
test("path with url endpoint having trailing slashes", () => {
117103
const ikImage = shallow(
118104
<IKImage urlEndpoint="http://ik.imagekit.io/test_imagekit_id////" path={relativePath} />
119105
);
120-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg?ik-sdk-version=react-1.0.7"/>
121-
122-
expect(ikImage.find('img').prop('src')).toEqual(`${urlEndpoint}/${relativePath}?${global.SDK_VERSION}`);
106+
107+
expect(ikImage.find('img').prop('src')).toEqual(`http://ik.imagekit.io/test_imagekit_id${relativePath}?${global.SDK_VERSION}`);
123108
});
124109

125110
test("path with lqip", () => {
126111
const ikImage = shallow(
127112
<IKImage urlEndpoint={urlEndpoint} lqip={{ active: true, quality: 20 }} path={relativePath} id="lqip" />
128113
);
129-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:q-20,bl-6/default-image.jpg?
130-
// ik-sdk-version=react-1.0.7" id="lqip"/>
131-
114+
132115
const transformURL = `${urlEndpoint}/tr:q-20,bl-6/${relativePath}?${global.SDK_VERSION}`;
133116
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
134117
expect(ikImage.find('img').prop('id')).toEqual('lqip');
@@ -141,9 +124,7 @@ describe('IKImage', () => {
141124
width: 400
142125
}]} />
143126
);
144-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:h-300,w-400/default-image.jpg
145-
// ?ik-sdk-version=react-1.0.7"/>
146-
127+
147128
const transformURL = `${urlEndpoint}/tr:h-300,w-400/${relativePath}?${global.SDK_VERSION}`;
148129
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
149130
});
@@ -161,9 +142,7 @@ describe('IKImage', () => {
161142
id="lqip"
162143
/>
163144
);
164-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:h-300,w-400:q-20,bl-6/default-image.jpg
165-
// ?ik-sdk-version=react-1.0.7" id="lqip"/>
166-
145+
167146
const transformURL = `${urlEndpoint}/tr:h-300,w-400:q-20,bl-6/${relativePath}?${global.SDK_VERSION}`;
168147
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
169148
expect(ikImage.find('img').prop('id')).toEqual('lqip');
@@ -182,9 +161,7 @@ describe('IKImage', () => {
182161
id="lqip"
183162
/>
184163
);
185-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:h-300,w-400:q-50,bl-25/sample-folder/
186-
// default-image.jpg?ik-sdk-version=react-1.0.7" id="lqip"/>
187-
164+
188165
const transformURL = `${urlEndpoint}/tr:h-300,w-400:q-50,bl-25${nestedImagePath}?${global.SDK_VERSION}`;
189166
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
190167
expect(ikImage.find('img').prop('id')).toEqual('lqip');
@@ -198,9 +175,7 @@ describe('IKImage', () => {
198175
height: 300
199176
}]} />
200177
);
201-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:h-300/default-image.jpg
202-
// ?ik-sdk-version=react-1.0.7">
203-
178+
204179
const transformURL = `${urlEndpoint}/tr:h-300/${relativePath}?${global.SDK_VERSION}`;
205180
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
206181
});
@@ -212,9 +187,7 @@ describe('IKImage', () => {
212187
width: 400
213188
}]} transformationPosition="query" />
214189
);
215-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg
216-
// ?ik-sdk-version=react-1.0.7&tr=h-300%2Cw-400">
217-
190+
218191
const transformURL = `${urlEndpoint}/${relativePath}?${global.SDK_VERSION}&tr=h-300%2Cw-400`;
219192
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
220193
});
@@ -226,9 +199,7 @@ describe('IKImage', () => {
226199
width: 400
227200
}]} transformationPosition="path" />
228201
);
229-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:h-300,w-400/default-image.jpg
230-
// ?ik-sdk-version=react-1.0.7">
231-
202+
232203
const transformURL = `${urlEndpoint}/tr:h-300,w-400/${relativePath}?${global.SDK_VERSION}`;
233204
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
234205
});
@@ -240,9 +211,7 @@ describe('IKImage', () => {
240211
width: 400
241212
}]} transformationPosition="path" />
242213
);
243-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/default-image.jpg
244-
// ?ik-sdk-version=react-1.0.7&tr=h-300%2Cw-400">
245-
214+
246215
const transformURL = `${absolutePath}?${global.SDK_VERSION}&tr=h-300%2Cw-400`;
247216
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
248217
});
@@ -256,9 +225,7 @@ describe('IKImage', () => {
256225
'rotation': 90
257226
}]} />
258227
);
259-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:h-300,w-400:rt-90/default-image.jpg
260-
// ?ik-sdk-version=react-1.0.7">
261-
228+
262229
const transformURL = `${urlEndpoint}/tr:h-300,w-400:rt-90/${relativePath}?${global.SDK_VERSION}`;
263230
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
264231
});
@@ -269,9 +236,7 @@ describe('IKImage', () => {
269236
'foo': 'bar',
270237
}]} />
271238
);
272-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:foo-bar/default-image.jpg
273-
// ?ik-sdk-version=react-1.0.7">
274-
239+
275240
const transformURL = `${urlEndpoint}/tr:foo-bar/${relativePath}?${global.SDK_VERSION}`;
276241
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
277242
});
@@ -283,9 +248,7 @@ describe('IKImage', () => {
283248
height: 300
284249
}]} />
285250
);
286-
// <img alt="" src="http://ik.imagekit.io/test_imagekit_id/tr:foo-bar,h-300/default-image.jpg
287-
// ?ik-sdk-version=react-1.0.7">
288-
251+
289252
const transformURL = `${urlEndpoint}/tr:foo-bar,h-300/${relativePath}?${global.SDK_VERSION}`;
290253
expect(ikImage.find('img').prop('src')).toEqual(transformURL);
291254
});
@@ -302,8 +265,7 @@ describe('IKImage', () => {
302265
loading="lazy"
303266
/>
304267
);
305-
// <img alt="" src="" >
306-
268+
307269
expect(ikImage.find('img').prop('src')).toEqual('');
308270
});
309271

0 commit comments

Comments
 (0)