Skip to content

Commit 755bf0d

Browse files
authored
Merge pull request #56 from prasoon0909/feat/pr-review-48-54
Feat/pr review 48 54
2 parents 1499945 + 9101ca2 commit 755bf0d

File tree

5 files changed

+30
-22
lines changed

5 files changed

+30
-22
lines changed

DEVELOPMENT.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@ bundle exec rake
1616

1717
**3. To build gem**
1818
```shell
19-
gem build imagekit.gemspec
19+
gem build imagekitio.gemspec
2020
```

README.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,18 @@ Ruby on Rails gem for [ImageKit](https://imagekit.io/) implements the new APIs a
1313
ImageKit is complete media storage, optimization, and transformation solution that comes with an [image and video CDN](https://imagekit.io/features/imagekit-infrastructure). It can be integrated with your existing infrastructure - storage like AWS S3, web servers, your CDN, and custom domain names, allowing you to deliver optimized images in minutes with minimal code changes.
1414

1515
Table of contents -
16-
* [Installation](#Installation)
17-
* [Initialization](#Initialization)
18-
- [CarrierWave](#Carrierwave)
19-
- [ActiveStorage](#activeStorage)
20-
* [URL Generation](#URL-generation)
21-
* [File Upload](#File-Upload)
22-
* [File Management](#File-Management)
23-
* [Utility Functions](#Utility-functions)
24-
* [Sample applications](#Sample-Application)
25-
* [Upgrade to 2.x](#upgrade-to-2.x)
26-
* [Support](#Support)
27-
* [Links](#Links)
16+
* [Installation](#installation)
17+
* [Initialization](#initialization)
18+
- [CarrierWave](#carrierwave)
19+
- [ActiveStorage](#activestorage)
20+
* [URL Generation](#url-generation)
21+
* [File Upload](#file-upload)
22+
* [File Management](#file-management)
23+
* [Utility Functions](#utility-functions)
24+
* [Sample applications](#sample-application)
25+
* [Upgrade to 2.x](#upgrade-to-2x)
26+
* [Support](#support)
27+
* [Links](#links)
2828

2929

3030
# Quick start guide

imagekitio.gemspec

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@ Gem::Specification.new do |spec|
2525

2626
spec.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
2727

28-
# spec.add_dependency "rails", "~> 5.2.0", ">= 5.2.0"
29-
spec.add_dependency 'carrierwave', '>= 0.7', '< 2.2'
30-
spec.add_dependency 'rest-client', '~> 2.1', ">=2.1"
31-
spec.add_dependency 'addressable', '~> 2.8'
32-
spec.add_dependency 'activestorage', '>= 5.2.0'
33-
spec.add_dependency 'multipart-post', '>= 2.1.0'
28+
spec.add_dependency "addressable", "~> 2.8"
29+
spec.add_dependency "multipart-post", ">= 2.1.0"
30+
spec.add_dependency "rest-client", "~> 2.1", ">=2.1"
31+
spec.add_development_dependency "activestorage", ">= 5.2.0"
32+
spec.add_development_dependency "carrierwave", ">= 0.7", "<= 2.2.1"
3433
spec.add_development_dependency "rails", "~> 5.2.0", ">= 5.2.0"
3534
end
Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,7 @@
1-
require_relative './service/ik_file'
2-
require_relative './service/image_kit_io_service'
1+
begin
2+
require 'active_storage'
3+
rescue LoadError
4+
puts "Add gem 'activestorage' to use this service"
5+
end
6+
require_relative './service/ik_file'
7+
require_relative './service/image_kit_io_service'

lib/carrierwave/carrierwave.rb

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
require 'carrierwave'
1+
begin
2+
require 'carrierwave'
3+
rescue LoadError
4+
puts "Add gem 'carrierwave' to use this service"
5+
end
26
require_relative './storage/imagekit_store'
37
require_relative './storage/ik_file'
48
require_relative './support/uri_filename'

0 commit comments

Comments
 (0)