Skip to content

Commit b7f7c71

Browse files
Jay ParekhJay Parekh
authored andcommitted
add check for auth parameters while initializing
1 parent 2dd1312 commit b7f7c71

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

lib/imagekit/imagekit.rb

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,15 @@ class ImageKitClient
1616
attr_reader :file
1717

1818
def initialize(private_key, public_key, url_endpoint, transformation_pos = nil, options = nil)
19+
20+
unless(private_key.is_a?(String) && public_key.is_a?(String) && url_endpoint.is_a?(String))
21+
raise ArgumentError, "ImageKit Parameters should be valid string"
22+
end
23+
24+
unless(private_key.to_s.strip.length != 0 && public_key.to_s.strip.length != 0 && url_endpoint.to_s.strip.length != 0)
25+
raise ArgumentError, "ImageKit Parameters cannot be blank"
26+
end
27+
1928
@private_key = private_key
2029
@public_key = public_key
2130
@url_endpoint = url_endpoint

test/imagekit/imagekit_test.rb

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,21 @@
33
require "rspec/autorun"
44

55
RSpec.describe "FileUploadTest" do
6+
7+
it "test_initialization_with_parameters_missing" do
8+
request_obj = double
9+
expect {
10+
ImageKit::ImageKitClient.new(" ", PUBLIC_KEY, URL_ENDPOINT)
11+
}.to raise_error(ArgumentError)
12+
end
13+
14+
it "test_initialization_with_non_string_parameters" do
15+
request_obj = double
16+
expect {
17+
ImageKit::ImageKitClient.new({RANDOM: "RANDOM"}, PUBLIC_KEY, URL_ENDPOINT)
18+
}.to raise_error(ArgumentError)
19+
end
20+
621
it "test_upload_with_valid_expected_success" do
722
request_obj = double
823
allow(ImageKitRequest)

0 commit comments

Comments
 (0)