fix bugs and add test cases

Author: bishosilwal

lib/imagekitio/api_service/file.rb

@@ -40,7 +40,6 @@ def upload(file: nil, file_name: nil, **options)
         else
           headers = @req_obj.create_headers
           payload = {multipart: true, file: file, fileName: file_name}.merge(options)
-
           url = "#{constants.BASE_URL}#{constants.UPLOAD}"
           @req_obj.request("post", url, headers, payload)
         end
@@ -155,7 +154,7 @@ def rename(file_path: nil, new_file_name: nil, **options)
           raise ArgumentError, 'parameters required'
         end
         url = "#{constants.BASE_URL}/rename"
-        payload = { 'filePath': file_path, 'newFileName': new_file_name }.merge(request_formatter(options))
+        payload = { 'filePath': file_path, 'newFileName': new_file_name }.merge(request_formatter(options)).to_json
         @req_obj.request('put', url, @req_obj.create_headers, payload)
       end
     end

lib/imagekitio/constant.rb

@@ -24,7 +24,8 @@ class << self
       def method_missing(symbol, *args)
         method_name = symbol.to_s.gsub('=', '')
         if self.const_defined? method_name
-          return self.const_get(method_name) unless args.present?
+          return self.const_get(method_name) if args.empty?
+
           self.const_set(method_name, args.first)
         else
           super

test/imagekit/api_service/file_test.rb

@@ -107,6 +107,60 @@
 
     end
 
+    it "test_upload_with_valid_expected_success_with_extensions" do
+      request_obj = double
+      allow(ImageKitIo::Request)
+        .to receive(:new)
+              .with(private_key, public_key, url_endpoint)
+              .and_return(request_obj)
+
+      allow(request_obj)
+        .to receive(:create_headers)
+              .and_return({})
+      @ac={}
+      allow(request_obj)
+        .to receive(:request){|method,url,headers,payload| @ac={method: method, url: url, headers: headers, payload:payload}}
+              .and_return({code: 200})
+      SUT = file_api_service.new(request_obj)
+      upload = SUT.upload(file: "./fake_file.jpg", file_name: "my_file_name", extensions: [
+        {
+          name: 'remove-bg',
+          options: {
+            add_shadow: true
+          }
+        }
+      ])
+      expect(@ac[:payload]['extensions']).to eq("[{\"name\":\"remove-bg\",\"options\":{\"add_shadow\":true}}]")
+      expect(upload[:code]).to eq(200)
+    end
+
+    it "test_upload_with_valid_expected_success_with_customMetadata" do
+      request_obj = double
+      allow(ImageKitIo::Request)
+        .to receive(:new)
+              .with(private_key, public_key, url_endpoint)
+              .and_return(request_obj)
+
+      allow(request_obj)
+        .to receive(:create_headers)
+              .and_return({})
+      @ac={}
+      allow(request_obj)
+        .to receive(:request){|method,url,headers,payload| @ac={method: method, url: url, headers: headers, payload:payload}}
+              .and_return({code: 200})
+      SUT = file_api_service.new(request_obj)
+      upload = SUT.upload(
+        file: "./fake_file.jpg",
+        file_name: "my_file_name",
+        custom_metadata: {
+          brand: 'Nike',
+          color: 'red'
+        }
+      )
+      expect(@ac[:payload]['customMetadata']).to eq("{\"brand\":\"Nike\",\"color\":\"red\"}")
+      expect(upload[:code]).to eq(200)
+    end
+
     it "test_upload_with_valid_expected_success" do
       request_obj = double
       allow(ImageKitIo::Request)
@@ -597,6 +651,58 @@
         SUT.update_details(file_id: "file_id", **options)
       }.to raise_error(ArgumentError)
     end
+
+    it "test_update_file_details_expected_success_with_extensions" do
+      request_obj = double
+      allow(ImageKitIo::Request)
+        .to receive(:new)
+              .with(private_key, public_key, url_endpoint)
+              .and_return(request_obj)
+
+      allow(request_obj)
+        .to receive(:create_headers)
+              .and_return({})
+      @ac={}
+      allow(request_obj)
+        .to receive(:request){|method,url,headers,payload| @ac={method: method, url: url, headers: headers, payload:payload}}
+              .and_return({code: 200})
+      SUT = file_api_service.new(request_obj)
+      upload = SUT.update_details(file_id: "file_id_xyz", extensions: [
+        {
+          'name': 'google-auto-tagging',
+          'maxTags': 5,
+          'minConfidence': 95
+        }
+      ])
+      expect(@ac[:payload]).to eq("{\"extensions\":[{\"name\":\"google-auto-tagging\",\"maxTags\":5,\"minConfidence\":95}]}")
+      expect(upload[:code]).to eq(200)
+    end
+
+    it "test_update_with_valid_expected_success_with_customMetadata" do
+      request_obj = double
+      allow(ImageKitIo::Request)
+        .to receive(:new)
+              .with(private_key, public_key, url_endpoint)
+              .and_return(request_obj)
+
+      allow(request_obj)
+        .to receive(:create_headers)
+              .and_return({})
+      @ac={}
+      allow(request_obj)
+        .to receive(:request){|method,url,headers,payload| @ac={method: method, url: url, headers: headers, payload:payload}}
+              .and_return({code: 200})
+      SUT = file_api_service.new(request_obj)
+      upload = SUT.update_details(
+        file_id: "file_id_xyz",
+        custom_metadata: {
+          brand: 'Nike',
+          color: 'red'
+        }
+      )
+      expect(@ac[:payload]).to eq("{\"customMetadata\":{\"brand\":\"Nike\",\"color\":\"red\"}}")
+      expect(upload[:code]).to eq(200)
+    end
   end
 
   describe 'TestGetRemoteFileURLMetaData' do
@@ -755,12 +861,12 @@
 
     end
 
-    it 'test_move' do
+    it 'test_rename' do
       source_file = 'test/dummy.png'
       new_name = 'my_image.png'
       resp = @sut.rename(file_path: source_file, new_file_name: new_name)
       expect(@ac[:url]).to eq("https://api.imagekit.io/v1/files/rename")
-      expect(@ac[:payload]).to eq({:filePath=>"test/dummy.png", :newFileName=>"my_image.png"})
+      expect(@ac[:payload]).to eq("{\"filePath\":\"test/dummy.png\",\"newFileName\":\"my_image.png\"}")
       expect(@ac[:method]).to eq('put')
       expect(resp[:code]).to eq(200)
     end