Minor improvements to OSO building (AcademySoftwareFoundation#2658)

- Initialize `_useOSLCmdStr` in the constructor for `OslRenderer`.
- Iterate over shared pointers by value for efficiency.  (Iterating over shared pointers by `const &` requires the creation of an additional object copy.)
- Test the value of `MATERIALX_BUILD_OSOS` before including LibsToOso.cpp in a build.

Author: jstone-lucasfilm

source/MaterialXGenOsl/CMakeLists.txt

@@ -1,17 +1,7 @@
-file(GLOB_RECURSE materialx_source
- "${CMAKE_CURRENT_SOURCE_DIR}/OslShaderGenerator.cpp"
- "${CMAKE_CURRENT_SOURCE_DIR}/OslSyntax.cpp"
- "${CMAKE_CURRENT_SOURCE_DIR}/OslNetworkShaderGenerator.cpp"
- "${CMAKE_CURRENT_SOURCE_DIR}/OslNetworkSyntax.cpp"
- "${CMAKE_CURRENT_SOURCE_DIR}/Nodes/OsoNode.cpp")
-
-file(GLOB_RECURSE materialx_headers
-  "${CMAKE_CURRENT_SOURCE_DIR}/OslShaderGenerator.h"
-  "${CMAKE_CURRENT_SOURCE_DIR}/OslSyntax.h"
-  "${CMAKE_CURRENT_SOURCE_DIR}/OslNetworkShaderGenerator.h"
-  "${CMAKE_CURRENT_SOURCE_DIR}/OslNetworkSyntax.h"
-  "${CMAKE_CURRENT_SOURCE_DIR}/Nodes/OsoNode.h"
-  "${CMAKE_CURRENT_SOURCE_DIR}/Export.h")
+file(GLOB_RECURSE materialx_source "${CMAKE_CURRENT_SOURCE_DIR}/*.cpp")
+file(GLOB_RECURSE materialx_headers "${CMAKE_CURRENT_SOURCE_DIR}/*.h*")
+
+list(REMOVE_ITEM materialx_source "${CMAKE_CURRENT_SOURCE_DIR}/LibsToOso.cpp")
 
 mx_add_library(MaterialXGenOsl
     SOURCE_FILES
@@ -25,7 +15,7 @@ mx_add_library(MaterialXGenOsl
         MATERIALX_GENOSL_EXPORTS)
 
 # FIXME: LibsToOso has a dependency on the OslRenderer.
-if (MATERIALX_BUILD_RENDER)
+if (MATERIALX_BUILD_OSOS AND MATERIALX_BUILD_RENDER)
     file(GLOB GenNodes_SRC "${CMAKE_CURRENT_SOURCE_DIR}/LibsToOso.cpp")
 
     set(MATERIALX_LIBRARIES

source/MaterialXGenOsl/LibsToOso.cpp

@@ -335,7 +335,7 @@ int main(int argc, char* const argv[])
     mx::NodeGraphPtr librariesDocGraph = librariesDoc->addNodeGraph("librariesDocGraph");
 
     // Loop over all the `NodeDef` gathered in our documents from the provided libraries.
-    for (const mx::NodeDefPtr& nodeDef : librariesDoc->getNodeDefs())
+    for (mx::NodeDefPtr nodeDef : librariesDoc->getNodeDefs())
     {
         std::string nodeName = nodeDef->getName();
 

source/MaterialXRenderOsl/OslRenderer.cpp

@@ -28,6 +28,7 @@ OslRendererPtr OslRenderer::create(unsigned int width, unsigned int height, Imag
 OslRenderer::OslRenderer(unsigned int width, unsigned int height, Image::BaseType baseType) :
     ShaderRenderer(width, height, baseType),
     _useTestRender(true),
+    _useOSLCmdStr(false),
     _raysPerPixelLit(1),
     _raysPerPixelUnlit(1)
 {