fix pint errors

imahmood · imahmood · commit c166e338c642 · 2025-04-26T15:34:10.000+03:30
diff --git a/phpstan.neon b/phpstan.neon
@@ -5,5 +5,8 @@ parameters:
     level: 7
     paths:
         - src
-    checkMissingIterableValueType: false
-    checkGenericClassInNonGenericObjectType: false
+    ignoreErrors:
+        -
+            identifier: missingType.iterableValue
+        -
+            identifier: missingType.generics
diff --git a/src/Controllers/DownloadController.php b/src/Controllers/DownloadController.php
@@ -16,7 +16,7 @@ class DownloadController extends Controller
     public function __invoke(string $disk, string $path): BinaryFileResponse
     {
         if (! Storage::disk($disk)->exists($path)) {
-            throw new FileNotFoundException();
+            throw new FileNotFoundException;
         }
 
         return response()->file(
diff --git a/src/Events/AfterMediaSaved.php b/src/Events/AfterMediaSaved.php
@@ -13,6 +13,5 @@ class AfterMediaSaved
 
     public function __construct(
         public readonly Media $media,
-    ) {
-    }
+    ) {}
 }
diff --git a/src/Events/AfterMediaUploaded.php b/src/Events/AfterMediaUploaded.php
@@ -13,6 +13,5 @@ class AfterMediaUploaded
 
     public function __construct(
         public readonly Media $media,
-    ) {
-    }
+    ) {}
 }
diff --git a/src/Exceptions/DeleteDirectoryException.php b/src/Exceptions/DeleteDirectoryException.php
@@ -5,6 +5,4 @@
 
 use Exception;
 
-class DeleteDirectoryException extends Exception
-{
-}
+class DeleteDirectoryException extends Exception {}
diff --git a/src/Exceptions/DeleteFileException.php b/src/Exceptions/DeleteFileException.php
@@ -5,6 +5,4 @@
 
 use Exception;
 
-class DeleteFileException extends Exception
-{
-}
+class DeleteFileException extends Exception {}
diff --git a/src/Exceptions/FileNotFoundException.php b/src/Exceptions/FileNotFoundException.php
@@ -5,6 +5,4 @@
 
 use Exception;
 
-class FileNotFoundException extends Exception
-{
-}
+class FileNotFoundException extends Exception {}
diff --git a/src/Exceptions/NotWritableException.php b/src/Exceptions/NotWritableException.php
@@ -5,6 +5,4 @@
 
 use Exception;
 
-class NotWritableException extends Exception
-{
-}
+class NotWritableException extends Exception {}
diff --git a/src/Exceptions/PersistenceFailedException.php b/src/Exceptions/PersistenceFailedException.php
@@ -5,6 +5,4 @@
 
 use Exception;
 
-class PersistenceFailedException extends Exception
-{
-}
+class PersistenceFailedException extends Exception {}
diff --git a/src/Exceptions/UploadException.php b/src/Exceptions/UploadException.php
@@ -5,6 +5,4 @@
 
 use Exception;
 
-class UploadException extends Exception
-{
-}
+class UploadException extends Exception {}
diff --git a/src/FileStorage.php b/src/FileStorage.php
@@ -124,7 +124,7 @@ protected function persistMedia(Media $media, ?UploadedFile $uploadedFile): Medi
             }
 
             if (! $media->save()) {
-                throw new PersistenceFailedException();
+                throw new PersistenceFailedException;
             }
 
             if ($uploadedFile) {
@@ -133,7 +133,7 @@ protected function persistMedia(Media $media, ?UploadedFile $uploadedFile): Medi
                 ]);
 
                 if (! $isUploaded) {
-                    throw new UploadException();
+                    throw new UploadException;
                 }
 
                 if ($this->queueModifiers) {
diff --git a/src/FileStorageServiceProvider.php b/src/FileStorageServiceProvider.php
@@ -45,7 +45,7 @@ protected function registerManipulator(): void
         }
 
         $this->app->singleton(Manipulator::class, function (Application $app) {
-            $manipulator = new Manipulator();
+            $manipulator = new Manipulator;
 
             foreach (config('file-storage.modifiers') as $class => $options) {
                 $manipulator->addModifier($app->make($class));
diff --git a/src/Jobs/RunModifiersJob.php b/src/Jobs/RunModifiersJob.php
@@ -18,9 +18,7 @@ class RunModifiersJob implements ShouldQueue
     /**
      * Create a new job instance.
      */
-    public function __construct(private readonly Media $media)
-    {
-    }
+    public function __construct(private readonly Media $media) {}
 
     /**
      * Execute the job.
diff --git a/src/Modifiers/DownscaleModifier.php b/src/Modifiers/DownscaleModifier.php
@@ -12,8 +12,7 @@ class DownscaleModifier implements ModifierInterface
     public function __construct(
         protected readonly Image $image,
         protected readonly array $options,
-    ) {
-    }
+    ) {}
 
     public function canHandle(Media $media): bool
     {
diff --git a/src/Modifiers/FormatModifier.php b/src/Modifiers/FormatModifier.php
@@ -15,8 +15,7 @@ public function __construct(
         protected readonly Filesystem $filesystem,
         protected readonly Image $image,
         protected readonly array $options,
-    ) {
-    }
+    ) {}
 
     public function canHandle(Media $media): bool
     {
@@ -46,7 +45,7 @@ public function handle(Media $media): Media
 
         $media->file_name = $newName;
         if (! $media->save()) {
-            throw new PersistenceFailedException();
+            throw new PersistenceFailedException;
         }
 
         $this->filesystem->deleteFile($media->disk, $originalFile);
diff --git a/src/Modifiers/PreviewModifier.php b/src/Modifiers/PreviewModifier.php
@@ -15,8 +15,7 @@ public function __construct(
         protected readonly Filesystem $filesystem,
         protected readonly Image $image,
         protected readonly array $options,
-    ) {
-    }
+    ) {}
 
     public function canHandle(Media $media): bool
     {
@@ -42,7 +41,7 @@ public function handle(Media $media): Media
         );
 
         if (! $media->save()) {
-            throw new PersistenceFailedException();
+            throw new PersistenceFailedException;
         }
 
         if ($oldPreview) {
diff --git a/tests/FileStorageTest.php b/tests/FileStorageTest.php
@@ -11,12 +11,12 @@
 
 class FileStorageTest extends TestCase
 {
-    public function testCreateMedia(): void
+    public function test_create_media(): void
     {
         $fileStorage = app(FileStorage::class);
         $media = $fileStorage->create(
             type: TestDocumentType::AVATAR,
-            relatedTo: new TestUserModel(),
+            relatedTo: new TestUserModel,
             uploadedFile: UploadedFile::fake('jpg'),
         );
 
@@ -25,7 +25,7 @@ public function testCreateMedia(): void
         $this->assertStringEndsWith('.jpg', $media->file_name);
     }
 
-    public function testUpdateMedia(): void
+    public function test_update_media(): void
     {
         /** @var \Imahmood\FileStorage\Models\Media $originalMedia */
         $originalMedia = Media::factory()->create([
@@ -38,7 +38,7 @@ public function testUpdateMedia(): void
         $fileStorage = app(FileStorage::class);
         $updatedMedia = $fileStorage->update(
             type: TestDocumentType::OTHER,
-            relatedTo: new TestUserModel(),
+            relatedTo: new TestUserModel,
             media: clone $originalMedia,
             uploadedFile: UploadedFile::fake('jpg'),
         );
@@ -49,7 +49,7 @@ public function testUpdateMedia(): void
         $this->assertStringEndsWith('.jpg', $updatedMedia->file_name);
     }
 
-    public function testDeleteMedia(): void
+    public function test_delete_media(): void
     {
         /** @var \Imahmood\FileStorage\Models\Media $media */
         $media = Media::factory()->create();
diff --git a/tests/ManipulatorTest.php b/tests/ManipulatorTest.php
@@ -12,44 +12,44 @@
 
 class ManipulatorTest extends TestCase
 {
-    public function testModifiersJobPushedAfterMediaCreated(): void
+    public function test_modifiers_job_pushed_after_media_created(): void
     {
         Queue::fake();
         config()->set('file-storage.queue_modifiers', true);
 
         $fileStorage = app(FileStorage::class);
         $fileStorage->create(
             type: TestDocumentType::AVATAR,
-            relatedTo: new TestUserModel(),
+            relatedTo: new TestUserModel,
             uploadedFile: UploadedFile::fake('jpg'),
         );
 
         Queue::assertPushed(RunModifiersJob::class);
     }
 
-    public function testModifiersJobNotPushedAfterMediaCreated(): void
+    public function test_modifiers_job_not_pushed_after_media_created(): void
     {
         Queue::fake();
         config()->set('file-storage.queue_modifiers', false);
 
         $fileStorage = app(FileStorage::class);
         $fileStorage->create(
             type: TestDocumentType::AVATAR,
-            relatedTo: new TestUserModel(),
+            relatedTo: new TestUserModel,
             uploadedFile: UploadedFile::fake('jpg'),
         );
 
         Queue::assertNotPushed(RunModifiersJob::class);
     }
 
-    public function testModifiersRunAfterMediaCreated(): void
+    public function test_modifiers_run_after_media_created(): void
     {
         config()->set('file-storage.queue_modifiers', false);
 
         $fileStorage = app(FileStorage::class);
         $media = $fileStorage->create(
             type: TestDocumentType::AVATAR,
-            relatedTo: new TestUserModel(),
+            relatedTo: new TestUserModel,
             uploadedFile: UploadedFile::fake('heic'),
         );
 

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ class DownloadController extends Controller`
`16`	`16`	`public function __invoke(string $disk, string $path): BinaryFileResponse`
`17`	`17`	`{`
`18`	`18`	`if (! Storage::disk($disk)->exists($path)) {`
`19`		`- throw new FileNotFoundException();`
	`19`	`+ throw new FileNotFoundException;`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`return response()->file(`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,5 @@ class AfterMediaSaved`
`13`	`13`
`14`	`14`	`public function __construct(`
`15`	`15`	`public readonly Media $media,`
`16`		`- ) {`
`17`		`- }`
	`16`	`+ ) {}`
`18`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,5 @@ class AfterMediaUploaded`
`13`	`13`
`14`	`14`	`public function __construct(`
`15`	`15`	`public readonly Media $media,`
`16`		`- ) {`
`17`		`- }`
	`16`	`+ ) {}`
`18`	`17`	`}`