ci: Add GitHub Actions workflow and fix lints

- Add CI workflow for test, lint, and docs
- Configure clippy pedantic lints with appropriate allows
- Fix unused import in discovery.rs
- Run cargo fmt for consistent formatting

Author: lilith

.github/workflows/ci.yml

@@ -0,0 +1,74 @@
+name: CI
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+env:
+  CARGO_TERM_COLOR: always
+  RUST_BACKTRACE: 1
+
+jobs:
+  test:
+    name: Test (${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, macos-latest, windows-latest]
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust
+        uses: dtolnay/rust-action@stable
+
+      - name: Cache cargo
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.cargo/bin/
+            ~/.cargo/registry/index/
+            ~/.cargo/registry/cache/
+            ~/.cargo/git/db/
+            target/
+          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
+
+      - name: Build
+        run: cargo build --all-targets
+
+      - name: Run tests
+        run: cargo test --all
+
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust
+        uses: dtolnay/rust-action@stable
+        with:
+          components: rustfmt, clippy
+
+      - name: Check formatting
+        run: cargo fmt --all -- --check
+
+      - name: Clippy
+        run: cargo clippy --all-targets -- -D warnings
+
+  docs:
+    name: Documentation
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Install Rust
+        uses: dtolnay/rust-action@stable
+
+      - name: Build docs
+        run: cargo doc --no-deps
+        env:
+          RUSTDOCFLAGS: -D warnings

Cargo.toml

@@ -54,5 +54,37 @@ tempfile.workspace = true
 unsafe_code = "warn"
 
 [lints.clippy]
-all = "warn"
-pedantic = "warn"
+all = { level = "warn", priority = -1 }
+pedantic = { level = "warn", priority = -1 }
+# Allow common false positives from pedantic
+missing_errors_doc = "allow"
+missing_panics_doc = "allow"
+must_use_candidate = "allow"
+items_after_statements = "allow"
+unreadable_literal = "allow"
+module_name_repetitions = "allow"
+doc_markdown = "allow"
+# Allow cast issues in stats code
+cast_precision_loss = "allow"
+cast_possible_truncation = "allow"
+cast_sign_loss = "allow"
+cast_lossless = "allow"
+# Allow these style choices
+if_not_else = "allow"
+redundant_closure_for_method_calls = "allow"
+option_if_let_else = "allow"
+map_unwrap_or = "allow"
+trivially_copy_pass_by_ref = "allow"
+match_same_arms = "allow"
+needless_raw_string_hashes = "allow"
+unused_self = "allow"
+uninlined_format_args = "allow"
+ref_option = "allow"
+unnecessary_map_or = "allow"
+collapsible_if = "allow"
+needless_pass_by_value = "allow"
+too_many_lines = "allow"
+struct_excessive_bools = "allow"
+cloned_instead_of_copied = "allow"
+stable_sort_primitive = "allow"
+manual_midpoint = "allow"

src/corpus/checksum.rs

@@ -35,6 +35,7 @@ pub fn compute_checksum(path: &Path) -> Result<String> {
 
 /// Compute a checksum for in-memory data.
 #[must_use]
+#[allow(dead_code)] // Used in tests, may be useful for API consumers
 pub fn compute_checksum_bytes(data: &[u8]) -> String {
     let mut hash: u64 = 0xcbf29ce484222325;
     const FNV_PRIME: u64 = 0x100000001b3;

src/corpus/discovery.rs

@@ -247,8 +247,6 @@ fn infer_categories(corpus: &mut Corpus) {
 
 #[cfg(test)]
 mod tests {
-    use super::*;
-
     #[test]
     fn test_png_dimensions() {
         // Minimal valid PNG header with 100x50 dimensions

src/lib.rs

@@ -54,6 +54,6 @@ pub use eval::{
 pub use import::{CsvImporter, CsvSchema, ExternalResult};
 pub use metrics::{MetricConfig, MetricResult, PerceptionLevel};
 pub use stats::{
-    generate_svg, ChartConfig, ChartPoint, ChartSeries, ParetoFront, RDPoint, Summary,
+    ChartConfig, ChartPoint, ChartSeries, ParetoFront, RDPoint, Summary, generate_svg,
 };
 pub use viewing::ViewingCondition;

src/metrics/butteraugli.rs

@@ -10,7 +10,7 @@
 //! - < 5.0: Noticeable difference
 //! - >= 5.0: Degraded
 
-use butteraugli_oxide::{compute_butteraugli, ButteraugliParams};
+use butteraugli_oxide::{ButteraugliParams, compute_butteraugli};
 
 use crate::error::{Error, Result};
 
@@ -128,7 +128,10 @@ mod tests {
         let data: Vec<u8> = (0..100 * 100 * 3).map(|i| (i % 256) as u8).collect();
         let score = calculate_butteraugli(&data, &data, 100, 100).unwrap();
         // Identical images should have score close to 0
-        assert!(score < 0.01, "Identical images should have score ~0, got {score}");
+        assert!(
+            score < 0.01,
+            "Identical images should have score ~0, got {score}"
+        );
     }
 
     #[test]
@@ -137,7 +140,10 @@ mod tests {
         let test_data: Vec<u8> = vec![200u8; 100 * 100 * 3];
         let score = calculate_butteraugli(&ref_data, &test_data, 100, 100).unwrap();
         // Very different images should have high score
-        assert!(score > 1.0, "Very different images should have high score, got {score}");
+        assert!(
+            score > 1.0,
+            "Very different images should have high score, got {score}"
+        );
     }
 
     #[test]
@@ -152,6 +158,9 @@ mod tests {
     fn test_custom_intensity() {
         let data: Vec<u8> = (0..100 * 100 * 3).map(|i| (i % 256) as u8).collect();
         let score = calculate_butteraugli_with_intensity(&data, &data, 100, 100, 250.0).unwrap();
-        assert!(score < 0.01, "Identical images should have score ~0 at any intensity");
+        assert!(
+            score < 0.01,
+            "Identical images should have score ~0 at any intensity"
+        );
     }
 }

src/metrics/ssimulacra2.rs

@@ -12,7 +12,7 @@
 //! - <= 50: Degraded
 
 use ssimulacra2::{
-    compute_frame_ssimulacra2, ColorPrimaries, Rgb as Ssim2Rgb, TransferCharacteristic,
+    ColorPrimaries, Rgb as Ssim2Rgb, TransferCharacteristic, compute_frame_ssimulacra2,
 };
 
 use crate::error::{Error, Result};
@@ -120,7 +120,10 @@ mod tests {
         let data: Vec<u8> = (0..100 * 100 * 3).map(|i| (i % 256) as u8).collect();
         let score = calculate_ssimulacra2(&data, &data, 100, 100).unwrap();
         // Identical images should have score close to 100
-        assert!(score > 99.0, "Identical images should have score ~100, got {score}");
+        assert!(
+            score > 99.0,
+            "Identical images should have score ~100, got {score}"
+        );
     }
 
     #[test]
@@ -129,7 +132,10 @@ mod tests {
         let test_data: Vec<u8> = vec![200u8; 100 * 100 * 3];
         let score = calculate_ssimulacra2(&ref_data, &test_data, 100, 100).unwrap();
         // Very different images should have low score
-        assert!(score < 80.0, "Very different images should have low score, got {score}");
+        assert!(
+            score < 80.0,
+            "Very different images should have low score, got {score}"
+        );
     }
 
     #[test]

src/stats/chart.rs

@@ -132,8 +132,14 @@ pub fn generate_svg(series: &[ChartSeries], config: &ChartConfig) -> String {
         return String::new();
     }
 
-    let all_x: Vec<f64> = non_empty.iter().flat_map(|s| s.points.iter().map(|p| p.x)).collect();
-    let all_y: Vec<f64> = non_empty.iter().flat_map(|s| s.points.iter().map(|p| p.y)).collect();
+    let all_x: Vec<f64> = non_empty
+        .iter()
+        .flat_map(|s| s.points.iter().map(|p| p.x))
+        .collect();
+    let all_y: Vec<f64> = non_empty
+        .iter()
+        .flat_map(|s| s.points.iter().map(|p| p.y))
+        .collect();
 
     let (min_x, max_x) = bounds_with_padding(&all_x, 0.05);
     let (min_y, max_y) = bounds_with_padding(&all_y, 0.05);
@@ -155,8 +161,7 @@ pub fn generate_svg(series: &[ChartSeries], config: &ChartConfig) -> String {
         if config.lower_is_better {
             f64::from(margin_top) + (v - min_y) / (max_y - min_y) * f64::from(plot_height)
         } else {
-            f64::from(margin_top)
-                + (1.0 - (v - min_y) / (max_y - min_y)) * f64::from(plot_height)
+            f64::from(margin_top) + (1.0 - (v - min_y) / (max_y - min_y)) * f64::from(plot_height)
         }
     };
 
@@ -251,7 +256,10 @@ pub fn generate_svg(series: &[ChartSeries], config: &ChartConfig) -> String {
     let _ = writeln!(
         svg,
         r#"<line x1="{}" y1="{}" x2="{}" y2="{}" class="axis"/>"#,
-        margin_left, margin_top, margin_left, height - margin_bottom
+        margin_left,
+        margin_top,
+        margin_left,
+        height - margin_bottom
     );
 
     // Tick labels

src/stats/mod.rs

@@ -6,7 +6,7 @@
 pub mod chart;
 mod pareto;
 
-pub use chart::{generate_svg, ChartConfig, ChartPoint, ChartSeries};
+pub use chart::{ChartConfig, ChartPoint, ChartSeries, generate_svg};
 pub use pareto::{ParetoFront, RDPoint};
 
 use serde::{Deserialize, Serialize};