Skip to content

Commit 2e5f2af

Browse files
committed
ci: fix msrv and coverage failures
- Fix msrv: Run cargo-hack per-package since features differ (jpegxl-src has no features, jpegxl-sys has vendored, jpegxl-rs has vendored,bench) - Fix coverage: Don't fail CI when CODECOV_TOKEN is not configured (e.g., in forks)
1 parent 479f01e commit 2e5f2af

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,8 @@ jobs:
8080
with:
8181
token: ${{ secrets.CODECOV_TOKEN }}
8282
files: lcov.info
83-
fail_ci_if_error: true
83+
# Don't fail CI if Codecov token is not configured (e.g., in forks)
84+
fail_ci_if_error: ${{ secrets.CODECOV_TOKEN != '' }}
8485

8586
sanitizers:
8687
name: Sanitizers
@@ -130,8 +131,12 @@ jobs:
130131
with:
131132
sweep-cache: true
132133
- uses: taiki-e/install-action@cargo-hack
133-
# Exclude conformance-tests feature (requires codec-eval which uses edition2024)
134-
- run: cargo hack check --rust-version --workspace --all-targets --ignore-private --features vendored,bench
134+
# Check each package individually to handle different feature sets
135+
# jpegxl-src has no features, jpegxl-sys has vendored, jpegxl-rs has vendored,bench
136+
- run: |
137+
cargo hack check --rust-version --all-targets -p jpegxl-src
138+
cargo hack check --rust-version --all-targets -p jpegxl-sys --features vendored
139+
cargo hack check --rust-version --all-targets -p jpegxl-rs --features vendored,bench
135140
136141
clippy:
137142
name: Clippy

0 commit comments

Comments
 (0)