Skip to content

Exposed username and password in javascript #2

@normkatz

Description

@normkatz

Wondering why you're exposing the sendgrid account username and password in javascript via the extension in the function "buildQuickForm" in class CRM_Sendgrid_Form_SendGrid in the file SendGrid.php on lines 32-35 at path sites/default/local/CRM/extensions/com.imba.sendgrid-2.0/CRM/Sendgrid/Form.

class CRM_Sendgrid_Form_SendGrid extends CRM_Core_Form {

function buildQuickForm() {
    require_once('CRM/Core/Resources.php');
    else $attr = null;

    $el = $this->add('text', 'username', ts('Username'), $attr);
    if (!$is_writable)
        $el->setSize(40);
    $el = $this->add($is_writable ? 'password' : 'text', 'password', ts('Password'), $attr);

Do you have any plans to refactor and eliminate this and use server-side credentials instead?

Is there a sendgrid component you recommend that supersedes this one?

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions