feat(validation): adds domain validation to client#42
Open
Conversation
BREAKING CHANGE: ImgixClient domains are now validated; must be passed in as a fully qualified domain name and without a protocol or path element
Features
Chore
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
sherwinski
approved these changes
Oct 21, 2022
Contributor
sherwinski
left a comment
sherwinski
left a comment
There was a problem hiding this comment.
LGTM
From offline: we're going to hold off on releasing this for a bit to give us a chance to package other potential breaking changes together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds domain validation to library.
Breaking Change
ImgixClient domains are now validated; must be passed in as a fully qualified domain name and without a protocol or path element.