Fix test and lint errors

Author: DarthSim

.rubocop.yml

@@ -1,5 +1,7 @@
 require:
   - standard/cop/block_single_line_braces
+
+plugins:
   - rubocop-rspec
 
 inherit_gem:
@@ -33,7 +35,5 @@ Style/TrailingCommaInArrayLiteral:
   Enabled: true
   EnforcedStyleForMultiline: comma
 
-RSpec/FilePath:
-  Enabled: false
 RSpec/SpecFilePathFormat:
   Enabled: false

docs/yard/fix_pictures.rb

@@ -7,17 +7,17 @@ module YARD
   # Replaces <picture> tags with <img> and relative src with absolute ones
   module ReplacePicture
     def html_markup_markdown(text)
-      text = text.gsub(%r{<picture>.*(<img [^>]*>).*</picture>}m) do
+      new_text = text.gsub(%r{<picture>.*(<img [^>]*>).*</picture>}m) do
         Regexp.last_match(1)
       end
 
-      text = text.gsub(/<img [^>]*src="(([^>?]+)(\?[^>]*)?)"[^>]*>/m) do |str|
+      new_text = new_text.gsub(/<img [^>]*src="(([^>?]+)(\?[^>]*)?)"[^>]*>/m) do |str|
         src = Regexp.last_match(1)
         next str unless URI.parse(src).relative?
         str.gsub(src, url_for_file(Regexp.last_match(2)))
       end
 
-      super(text)
+      super(new_text)
     end
   end
 

imgproxy.gemspec

@@ -38,7 +38,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "combustion", "~> 1.3"
   spec.add_development_dependency "rspec", "~> 3.12"
   spec.add_development_dependency "rspec-rails", "~> 6.0"
-  spec.add_development_dependency "rubocop-rspec", "~> 2.11"
+  spec.add_development_dependency "rubocop-rspec", "~> 3.6"
   spec.add_development_dependency "standard", "~> 1.0"
 
   spec.add_development_dependency "aws-sdk-s3", "~> 1.64"

lib/imgproxy/service_config.rb

@@ -73,39 +73,39 @@ class ServiceConfig < Anyway::Config
       :set_source_url_encryption_key, :set_raw_source_url_encryption_key
 
     def key=(value)
-      value = value&.to_s
-      super(value)
-      set_raw_key(value && [value].pack("H*"))
+      str_value = value&.to_s
+      super(str_value)
+      set_raw_key(str_value && [str_value].pack("H*"))
     end
 
     def raw_key=(value)
-      value = value&.to_s
-      super(value)
-      set_key(value&.unpack!("H*"))
+      str_value = value&.to_s
+      super(str_value)
+      set_key(str_value&.unpack!("H*"))
     end
 
     def salt=(value)
-      value = value&.to_s
-      super(value)
-      set_raw_salt(value && [value].pack("H*"))
+      str_value = value&.to_s
+      super(str_value)
+      set_raw_salt(str_value && [str_value].pack("H*"))
     end
 
     def raw_salt=(value)
-      value = value&.to_s
-      super(value)
-      set_salt(value&.unpack1("H*"))
+      str_value = value&.to_s
+      super(str_value)
+      set_salt(str_value&.unpack1("H*"))
     end
 
     def source_url_encryption_key=(value)
-      value = value&.to_s
-      super(value)
-      set_raw_source_url_encryption_key(value && [value].pack("H*"))
+      str_value = value&.to_s
+      super(str_value)
+      set_raw_source_url_encryption_key(str_value && [str_value].pack("H*"))
     end
 
     def raw_source_url_encryption_key=(value)
-      value = value&.to_s
-      super(value)
-      set_source_url_encryption_key(value&.unpack1("H*"))
+      str_value = value&.to_s
+      super(str_value)
+      set_source_url_encryption_key(str_value&.unpack1("H*"))
     end
   end
 end

lib/imgproxy/url_builders/processing.rb

@@ -24,7 +24,7 @@ class Processing < Base
       # @param [Hash] options Processing options
       # @see Imgproxy.url_for
       def initialize(options = {})
-        super(options)
+        super
 
         @format = @options.delete(:format)
       end

spec/rails_helper.rb

@@ -26,7 +26,6 @@ class User < ActiveRecord::Base
 active_storage_path = Gem::Specification.find_by_name("activestorage").gem_dir
 ActiveRecord::MigrationContext.new(
   File.join(active_storage_path, "db/migrate"),
-  ActiveRecord::SchemaMigration,
 ).migrate
 
 RSpec.configure do |config|