Skip to content

Commit 3d2d6ae

Browse files
committed
Add general timeout to click method
1 parent d191f9f commit 3d2d6ae

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

selenium/helper/Questionnaire.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def __init__(self, driver: WebDriver, navigation_helper: NavigationHelper):
6060

6161
def click_add_questionnaire_button(self):
6262
"""Clicks the 'Add Questionnaire' button."""
63-
self.utils.click_element(QuestionnaireSelectors.BUTTON_ADD_QUESTIONNAIRE)
63+
self.utils.click_element(QuestionnaireSelectors.BUTTON_ADD_QUESTIONNAIRE, 30)
6464

6565
def fill_questionnaire_details(self, questionnaire_name=None, description=None, language_code=None, localized_display_name=None,
6666
localized_welcome_text=None, localized_final_text=None, question_types=None):
@@ -195,7 +195,6 @@ def create_questionnaire_with_questions(self, questionnaire_name=None, questionn
195195

196196
# Navigate to "Manage Questionnaires"
197197
self.navigation_helper.navigate_to_manage_questionnaires()
198-
time.sleep(30)
199198

200199
# Create the questionnaire
201200
self.click_add_questionnaire_button()

selenium/helper/SeleniumUtils.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,13 @@ def __init__(self, driver, navigation_helper = None):
3535
self.driver = driver
3636
self.navigator = navigation_helper
3737

38-
def click_element(self, selector):
38+
def click_element(self, selector, timeout=20):
3939
"""
40+
:param timeout: timeout value to use
4041
:param selector: A tuple representing the element locator (e.g., (By.ID, "element_id")).
4142
"""
4243
try:
43-
element = WebDriverWait(self.driver, 10).until(EC.element_to_be_clickable(selector))
44+
element = WebDriverWait(self.driver, timeout).until(EC.element_to_be_clickable(selector))
4445
self.driver.execute_script("arguments[0].scrollIntoView(true);", element)
4546
element.click()
4647
except ElementClickInterceptedException:

0 commit comments

Comments
 (0)