fixed race condition

Author: jackbrookes

Assets/UXF/Scripts/Session.cs

@@ -332,7 +332,10 @@ public void Begin(string experimentName, string participantId, string baseFolder
             onSessionBegin.Invoke(this);
 
             // copy Settings to session folder
-            WriteDictToSessionFolder(settings.baseDict, "settings");
+            
+            WriteDictToSessionFolder(
+                new Dictionary<string, object>(settings.baseDict), // makes a copy
+                "settings");
         }
 
 

Assets/UXF/Scripts/Tests/Editor/TestMultithreading.cs

@@ -0,0 +1,81 @@
+using UnityEngine;
+using UnityEditor;
+using UnityEngine.TestTools;
+using NUnit.Framework;
+using System;
+using System.Collections;
+using System.Collections.Generic;
+using System.IO;
+
+namespace UXF.Tests
+{
+
+	public class TestMultithreading
+	{
+
+        GameObject gameObject;
+        Session session;
+        FileIOManager fileIOManager;
+        SessionLogger sessionLogger;
+
+        [SetUp]
+        public void SetUp()
+        {
+            gameObject = new GameObject();
+            fileIOManager = gameObject.AddComponent<FileIOManager>();
+            sessionLogger = gameObject.AddComponent<SessionLogger>();
+            session = gameObject.AddComponent<Session>();
+
+            session.AttachReferences(
+                fileIOManager,
+                sessionLogger
+            );
+
+            sessionLogger.AttachReferences(
+                fileIOManager,
+                session
+            );
+
+            sessionLogger.Initialise();
+
+            fileIOManager.debug = true;
+            fileIOManager.Begin();
+
+        }
+
+        [TearDown]
+        public void TearDown()
+        {
+            fileIOManager.End();
+            GameObject.DestroyImmediate(gameObject);
+        }
+
+        [Test]
+        public void AddSettingsDuringWriting()
+        {
+            string experimentName = "unit_test";
+            string ppid = "test_trials";
+            Settings settings = Settings.empty;
+
+            // initialise settings
+            for (int i = 0; i < 10000; i++)
+            {
+                string key = i.ToString();
+                settings[key] = i;
+            }
+
+            session.Begin(experimentName, ppid, "example_output", settings: settings);
+            
+            // add lots more during potential writing
+            for (int i = 0; i < 10000; i++)
+            {
+                string key = "_" + i.ToString();
+                settings[key] = i;
+            }
+
+            session.End();
+        }
+
+	}
+
+}

Assets/UXF/Scripts/Tests/Editor/TestMultithreading.cs.meta

@@ -1,2 +1,2 @@
 timestamp,log_type,message
-1.435732,Log,Joining FileIOManagerThread
+1.423677,Log,Joining FileIOManagerThread