Deduplication in shared albums

[LPkkjHD]

I have searched the existing issues, both open and closed, to make sure this is not a duplicate report.

• Yes

The bug

When a User B adds images to an shared album of user A there is no check for duplication.
This results in the exact same images (which therefore have the same hash) being duplicated in the shared album.

The expected behavior would be the duplicates not being added to the album.

There also does not appear to be a function to check for duplicates in shared folders - however, this would rather fit a feature request so this shall not be part of this issue report.

The OS that Immich Server is running on

k3s

Version of Immich Server

v1.129.0

Version of Immich Mobile App

not relevant

Platform with the issue

• Server
• Web
• Mobile

Your docker-compose.yml content

not applicable/relevant here

Your .env content

not applicable/relevant here

Reproduction steps

1. Create an Shared Album as user A
2. A adds Pictures (x.png, y.png, z.png) to the Album
3. Add user B to the Album
4. Badds Pictures (x.png, y.png, z.png) to the Album

Relevant log output

Additional information

Depending if the observed bug is confirmed/desiring a fix I would love to try my hand at this.

[bo0tzz]

This is currently working as expected, there is no cross-user deduplication.

[LPkkjHD]

Fair enough - thanks for the quick reply. Should I open a feature request for this then as I think this would a useful addition to immich?

[bo0tzz]

I've converted it.

[dyvyak]

This would be great feature if deduplication would work on shared albums. Me and my wife added to album same photos. She tak photo, upload to album, also she sent that photo via whatsapp to me and i upload the same photos because im syncing also whatsapp pictures to immich :)