Merge pull request #84 from PiotrTHOC/download-percentage-fix

malcommac · web-flow · commit bc92ce7b5449 · 2023-02-28T16:38:58.000+01:00
fix download percentage not always getting to 1 due to rounding errors
diff --git a/Sources/RealHTTP/Client/Internal/Other Structures/HTTPProgress.swift b/Sources/RealHTTP/Client/Internal/Other Structures/HTTPProgress.swift
@@ -84,8 +84,7 @@ public struct HTTPProgress: Comparable, Equatable {
         self.partialData = partialData
         
         if expectedLength != NSURLSessionTransferSizeUnknown, expectedLength != 0 {
-            let slice = Double(1.0)/Double(expectedLength)
-            self.percentage = slice*Double(currentLength)
+            self.percentage = Double(currentLength)/Double(expectedLength)
         } else {
             self.percentage = 0
         }

Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,7 @@ public struct HTTPProgress: Comparable, Equatable {`
`84`	`84`	`self.partialData = partialData`
`85`	`85`
`86`	`86`	`if expectedLength != NSURLSessionTransferSizeUnknown, expectedLength != 0 {`
`87`		`- let slice = Double(1.0)/Double(expectedLength)`
`88`		`- self.percentage = slice*Double(currentLength)`
	`87`	`+ self.percentage = Double(currentLength)/Double(expectedLength)`
`89`	`88`	`} else {`
`90`	`89`	`self.percentage = 0`
`91`	`90`	`}`