Merge pull request #236 from immobiliare/404_fix_2

fix: skip getLabel on 404

Author: simonecorsi

examples/nesting.js

@@ -34,7 +34,7 @@ app.register(plugin, {
         host: `udp://127.0.0.1:${udpPort}`,
         namespace: 'nesting_upd_test',
     },
-    routes: false
+    routes: false,
 });
 
 app.register(

index.js

@@ -225,7 +225,11 @@ module.exports = fp(
             fastify.decorateRequest(kMetricsLabel, '');
             fastify.decorateReply(kMetricsLabel, '');
             fastify.addHook('onRequest', function (request, reply, next) {
-                const label = getLabel.call(this, request, reply);
+                // For some reason, this request.is404 is false on 404s only in tests.
+                /* istanbul ignore next */
+                const label = request.is404
+                    ? ''
+                    : getLabel.call(this, request, reply);
                 request[kMetricsLabel] = label;
                 reply[kMetricsLabel] = label;
                 next();

tests/dynamic-mode.test.js

@@ -410,25 +410,25 @@ tap.test('custom getLabel and custom prefix', async (t) => {
         app,
         t
     );
+});
 
-    tap.test('404 test', async (t) => {
-        const server = await setup(
-            {
-                client: {
-                    namespace: '404_dynamic_mode_errors',
-                },
-                health: false,
+tap.test('404 test', async (t) => {
+    const server = await setup(
+        {
+            client: {
+                namespace: '404_dynamic_mode_errors',
             },
-            undefined,
-            t
-        );
-        t.teardown(async () => {
-            return server.close();
-        });
-        const response = await server.inject({
-            method: 'GET',
-            url: '/not-existing',
-        });
-        t.equal(404, response.statusCode);
+            health: false,
+        },
+        undefined,
+        t
+    );
+    t.teardown(async () => {
+        return server.close();
+    });
+    const response = await server.inject({
+        method: 'GET',
+        url: '/not-existingasdfasdfasdfasdfasdfasdfasd',
     });
+    t.equal(404, response.statusCode);
 });