Skip to content

Commit b5677c4

Browse files
committed
fix tests
1 parent 81394a8 commit b5677c4

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

client.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ func NewClient(gqlEndpoint string, opt *ClientOpts) *Client {
4343
}
4444

4545
var (
46-
ErrHTTPRedirect = errors.New("http request redirected")
47-
ErrHTTPRequestFailed = errors.New("http request failed")
46+
ErrHTTPRequestRedirect = errors.New("http request redirected")
47+
ErrHTTPRequestFailed = errors.New("http request failed")
4848
)
4949

5050
// Do performs a gql query and returns early if faced with a non-successful http status code.
@@ -60,9 +60,9 @@ func (c *Client) Do(ctx context.Context, q Queryable) (*bytes.Buffer, error) {
6060

6161
switch {
6262
case resp.StatusCode > 299 && resp.StatusCode < 399:
63-
err = fmt.Errorf("%w: %d", ErrHTTPRedirect, resp.StatusCode)
63+
err = fmt.Errorf("%w: %d", ErrHTTPRequestRedirect, resp.StatusCode)
6464
case resp.StatusCode > 399:
65-
err = fmt.Errorf("%w: %d", ErrHTTPFailedStatus, resp.StatusCode)
65+
err = fmt.Errorf("%w: %d", ErrHTTPRequestFailed, resp.StatusCode)
6666
}
6767

6868
return &respBytes, err

client_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,38 +46,38 @@ func TestDoClient(t *testing.T) {
4646
w.WriteHeader(http.StatusUnauthorized)
4747
w.Write([]byte(`{"error": {"message": "unauthorized"}}`))
4848
})),
49-
expectedErr: eywa.ErrHTTPFailedStatus,
49+
expectedErr: eywa.ErrHTTPRequestFailed,
5050
},
5151
{
5252
name: "A 401 status with no response",
5353
server: httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
5454
w.WriteHeader(http.StatusUnauthorized)
5555
})),
56-
expectedErr: eywa.ErrHTTPFailedStatus,
56+
expectedErr: eywa.ErrHTTPRequestFailed,
5757
},
5858
{
5959
name: "A 403 response",
6060
server: httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
6161
w.WriteHeader(http.StatusUnauthorized)
6262
w.Write([]byte(`{"error": {"message": "forbidden"}}`))
6363
})),
64-
expectedErr: eywa.ErrHTTPFailedStatus,
64+
expectedErr: eywa.ErrHTTPRequestFailed,
6565
},
6666
{
6767
name: "A 503 non-json response",
6868
server: httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
6969
w.WriteHeader(http.StatusServiceUnavailable)
7070
w.Write([]byte(`Service unavailable`))
7171
})),
72-
expectedErr: eywa.ErrHTTPFailedStatus,
72+
expectedErr: eywa.ErrHTTPRequestFailed,
7373
},
7474
{
7575
name: "A 301 Redirect",
7676
server: httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
7777
w.WriteHeader(http.StatusMovedPermanently)
7878
w.Write([]byte(`Moved Permanently`))
7979
})),
80-
expectedErr: eywa.ErrHTTPRedirect,
80+
expectedErr: eywa.ErrHTTPRequestRedirect,
8181
},
8282
}
8383

0 commit comments

Comments
 (0)