Merge pull request #11 from timonwong/add-more-bench

Add more benchmarks

Author: timonwong

README.md

@@ -13,7 +13,7 @@ High performance C99-compatible `strftime` formatter for Go.
 
 ## Performance
 
-Just for reference :P
+Comparision with the standard library `time.(*Time).Format()`:
 
 ```
 > go test -bench Bench -cpu 4 -benchmem .
@@ -27,6 +27,24 @@ PASS
 ok      github.com/imperfectgo/go-strftime      4.245s
 ```
 
+Comparision with other libraries:
+
+```
+> go test -bench Bench -cpu 8 -benchmem ./benchmark
+
+goos: darwin
+goarch: amd64
+pkg: github.com/imperfectgo/go-strftime/benchmark
+BenchmarkImperfectGo-8                   3000000               484 ns/op              64 B/op          1 allocs/op
+BenchmarkTebeka-8                         300000              4161 ns/op             272 B/op         20 allocs/op
+BenchmarkJehiah-8                        1000000              1719 ns/op             256 B/op         17 allocs/op
+BenchmarkFastly-8                        2000000               708 ns/op              85 B/op          5 allocs/op
+BenchmarkLestrrat-8                      1000000              1471 ns/op             240 B/op          3 allocs/op
+BenchmarkLestrratCachedString-8          3000000               496 ns/op             128 B/op          2 allocs/op
+PASS
+ok      github.com/imperfectgo/go-strftime/benchmark    10.605s
+```
+
 ## License
 
 This project can be treated as a derived work of time package from golang standard library.

benchmark_comp_test.go

@@ -0,0 +1,63 @@
+// Copyright 2018 Timon Wong. All rights reserved.
+
+// +build bench
+
+package strftime_test
+
+import (
+	"testing"
+	"time"
+
+	fastly "github.com/fastly/go-utils/strftime"
+	imperfectgo "github.com/imperfectgo/go-strftime"
+	jehiah "github.com/jehiah/go-strftime"
+	lestrrat "github.com/lestrrat-go/strftime"
+	tebeka "github.com/tebeka/strftime"
+)
+
+const (
+	benchfmt = `%A %a %B %b %d %H %I %M %m %p %S %Y %y %Z`
+)
+
+var (
+	now = time.Now().UTC()
+)
+
+func BenchmarkImperfectGo(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		imperfectgo.Format(now, benchfmt)
+	}
+}
+
+func BenchmarkTebeka(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		tebeka.Format(benchfmt, now)
+	}
+}
+
+func BenchmarkJehiah(b *testing.B) {
+	// Grr, uses byte slices, and does it faster, but with more allocs
+	for i := 0; i < b.N; i++ {
+		jehiah.Format(benchfmt, now)
+	}
+}
+
+func BenchmarkFastly(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		fastly.Strftime(benchfmt, now)
+	}
+}
+
+func BenchmarkLestrrat(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		lestrrat.Format(benchfmt, now)
+	}
+}
+
+func BenchmarkLestrratCachedString(b *testing.B) {
+	f, _ := lestrrat.New(benchfmt)
+	// This benchmark does not take into effect the compilation time
+	for i := 0; i < b.N; i++ {
+		f.FormatString(now)
+	}
+}

benchmark_test.go

@@ -1,17 +1,21 @@
 // Copyright 2018 Timon Wong. All rights reserved.
-// Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-package strftime
+package strftime_test
 
 import (
 	"testing"
 	"time"
+
+	"github.com/imperfectgo/go-strftime"
+)
+
+var (
+	now = time.Now().UTC()
 )
 
 func BenchmarkStdTimeFormat(b *testing.B) {
-	now := time.Now()
 	for i := 0; i < b.N; i++ {
 		now.Format(time.RFC3339Nano)
 	}
@@ -21,6 +25,6 @@ func BenchmarkGoStrftime(b *testing.B) {
 	const layout = "%Y-%m-%dT%H:%M:%S.%f%z"
 	now := time.Now()
 	for i := 0; i < b.N; i++ {
-		Format(now, layout)
+		strftime.Format(now, layout)
 	}
 }

example_test.go

@@ -1,18 +1,24 @@
-package strftime
+// Copyright 2018 Timon Wong. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package strftime_test
 
 import (
 	"fmt"
 	"time"
+
+	"github.com/imperfectgo/go-strftime"
 )
 
 func ExampleFormat() {
 	t := time.Date(2008, 9, 3, 20, 4, 26, 654321000, time.FixedZone("CST", 8*3600))
 
-	fmt.Println(Format(t, "%c"))
-	fmt.Println(Format(t, "%Y-%m-%dT%H:%M:%S.%f%z"))
-	fmt.Println(Format(t, "%A is day number %w of the week."))
-	fmt.Println(Format(t, "Last century was%n the %Cth century."))
-	fmt.Println(Format(t, "Time zone: %Z"))
+	fmt.Println(strftime.Format(t, "%c"))
+	fmt.Println(strftime.Format(t, "%Y-%m-%dT%H:%M:%S.%f%z"))
+	fmt.Println(strftime.Format(t, "%A is day number %w of the week."))
+	fmt.Println(strftime.Format(t, "Last century was%n the %Cth century."))
+	fmt.Println(strftime.Format(t, "Time zone: %Z"))
 
 	// Output:
 	// Wed Sep  3 20:04:26 2008

format.go

@@ -157,8 +157,8 @@ func AppendFormat(b []byte, t time.Time, layout string) []byte {
 			}
 			n = ((yday - n) / 7) + 1
 			b = appendInt(b, n, 2)
-		case stdDay:
-			b = appendInt(b, day, 0)
+		//case stdDay:
+		//	b = appendInt(b, day, 0)
 		case stdUnderDay:
 			if day < 10 {
 				b = append(b, ' ')

format_test.go

@@ -19,11 +19,13 @@
 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 // SOFTWARE.
 
-package strftime
+package strftime_test
 
 import (
 	"testing"
 	"time"
+
+	"github.com/imperfectgo/go-strftime"
 )
 
 var (
@@ -100,7 +102,7 @@ func TestFormat(t *testing.T) {
 
 	for i := range tc {
 		c := tc[i]
-		actual := Format(c.time, c.layout)
+		actual := strftime.Format(c.time, c.layout)
 		if actual != c.expected {
 			t.Errorf("Test layout `%s`: expected: %q; actual: %q", c.layout, c.expected, actual)
 		}

stdtime_unsafe.go

@@ -1,10 +1,10 @@
-// +build !appengine,!js
-
 // Copyright 2018 Timon Wong. All rights reserved.
 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
+// +build !appengine,!js
+
 package strftime
 
 import (

stdtime_unsafe.s

@@ -1,9 +1,9 @@
-// +build !appengine,!js
-
 // Copyright 2018 Timon Wong. All rights reserved.
 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 // Empty assembly file just make `go:linkname` work without "missing function body" error
 // See https://github.com/golang/go/issues/15006
+
+// +build !appengine,!js