Skip to content

Commit 98046c9

Browse files
V1.4.0 (#1047)
2 parents 9d6535f + 56152a0 commit 98046c9

File tree

10 files changed

+15
-39
lines changed

10 files changed

+15
-39
lines changed

apps/api/src/app/template/commands/update-destination.command.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,13 @@ export class BubbleIoDestinationObject {
4949
@ValidateIf((obj) => obj.destination === DestinationsEnum.BUBBLEIO)
5050
apiPrivateKey: string;
5151

52-
@IsString()
53-
@IsDefined()
54-
@ValidateIf((obj) => obj.destination === DestinationsEnum.BUBBLEIO)
55-
datatype: string;
56-
5752
/*
53+
*@IsString()
54+
*@IsDefined()
55+
*@ValidateIf((obj) => obj.destination === DestinationsEnum.BUBBLEIO)
56+
*datatype: string;
57+
*
58+
* /*
5859
* @IsEnum(BubbleDestinationEnvironmentEnum)
5960
* @IsDefined()
6061
* @ValidateIf((obj) => obj.destination === DestinationsEnum.BUBBLEIO)

apps/api/src/app/template/dtos/destination-response.dto.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,5 @@ export class DestinationResponseDto {
1212
bubbleio?: {
1313
bubbleAppUrl: string;
1414
apiPrivateKey: string;
15-
datatype: string;
1615
};
1716
}

apps/api/src/app/template/dtos/update-destination-request.dto.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,13 @@ class BubbleIoDestinationObject {
4848
@ValidateIf((obj) => obj.destination === DestinationsEnum.BUBBLEIO)
4949
apiPrivateKey: string;
5050

51-
@IsString()
52-
@IsDefined()
53-
@ValidateIf((obj) => obj.destination === DestinationsEnum.BUBBLEIO)
54-
datatype: string;
55-
5651
/*
52+
*@IsString()
53+
*@IsDefined()
54+
*@ValidateIf((obj) => obj.destination === DestinationsEnum.BUBBLEIO)
55+
*datatype: string;
56+
*
57+
* /*
5758
* @IsEnum(BubbleDestinationEnvironmentEnum)
5859
* @IsDefined()
5960
* @ValidateIf((obj) => obj.destination === DestinationsEnum.BUBBLEIO)

apps/queue-manager/src/consumers/send-bubble-data.consumer.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export class SendBubbleDataConsumer extends BaseConsumer {
7676

7777
await this.makeResponseEntry(
7878
response,
79-
{ bubbleAppUrl: cachedData.bubbleAppUrl, datatype: cachedData.datatype },
79+
{ bubbleAppUrl: cachedData.bubbleAppUrl },
8080
cachedData.name,
8181
cachedData.email
8282
);
@@ -173,7 +173,6 @@ export class SendBubbleDataConsumer extends BaseConsumer {
173173
bubbleAppUrl,
174174
chunkSize: 500,
175175
email: userEmail,
176-
datatype: bubbleDestination.datatype,
177176
name: templateData.name,
178177
_templateId: uploadata._templateId,
179178
recordFormat: uploadata.customRecordFormat,
@@ -185,7 +184,7 @@ export class SendBubbleDataConsumer extends BaseConsumer {
185184

186185
private async makeResponseEntry(
187186
data: Partial<WebhookLogEntity>,
188-
bubbleData: { datatype: string; bubbleAppUrl: string },
187+
bubbleData: { bubbleAppUrl: string },
189188
importName: string,
190189
userEmail: string
191190
) {
@@ -196,7 +195,6 @@ export class SendBubbleDataConsumer extends BaseConsumer {
196195
error: JSON.stringify(data.error, null, 2).replace(/\\+"/g, '"'),
197196
importName,
198197
time: data.callDate.toString(),
199-
datatype: bubbleData.datatype,
200198
bubbleAppUrl: bubbleData.bubbleAppUrl,
201199
importId: data._uploadId,
202200
},

apps/web/components/imports/destination/Destination.tsx

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,6 @@ export function Destination({ template }: DestinationProps) {
164164
{...register('bubbleIo.apiPrivateKey')}
165165
error={errors?.bubbleIo?.apiPrivateKey?.message}
166166
/>
167-
<Input
168-
required
169-
label="Datatype Name"
170-
placeholder="Datatype"
171-
{...register('bubbleIo.datatype')}
172-
error={errors?.bubbleIo?.datatype?.message}
173-
/>
174167
<Group>
175168
<Button loading={isUpdateImportLoading} type="submit">
176169
Test and Save

libs/dal/src/repositories/bubble-destination/bubble-destination.entity.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,5 @@ export class BubbleDestinationEntity {
55

66
apiPrivateKey: string;
77

8-
datatype: string;
9-
108
_templateId: string;
119
}

libs/dal/src/repositories/bubble-destination/bubble-destination.schema.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ const bubbleDestinationSchema = new Schema(
1515
apiPrivateKey: {
1616
type: Schema.Types.String,
1717
},
18-
datatype: {
19-
type: Schema.Types.String,
20-
},
2118
},
2219
{ ...schemaOptions }
2320
);

libs/services/src/email/email.service.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ interface IWebhookAlertEmailOptions {
99
importId: string;
1010
}
1111
interface IBubbleAlertEmailOptions {
12-
datatype: string;
1312
bubbleAppUrl: string;
1413
error: string;
1514
importName: string;
@@ -238,14 +237,7 @@ const EMAIL_CONTENTS = {
238237
</body>
239238
</html>
240239
`,
241-
ERROR_SENDING_BUBBLE_DATA: ({
242-
datatype,
243-
bubbleAppUrl,
244-
error,
245-
importName,
246-
time,
247-
importId,
248-
}: IBubbleAlertEmailOptions) => `
240+
ERROR_SENDING_BUBBLE_DATA: ({ bubbleAppUrl, error, importName, time, importId }: IBubbleAlertEmailOptions) => `
249241
<!DOCTYPE html>
250242
<html lang="en">
251243
<head>
@@ -315,7 +307,6 @@ const EMAIL_CONTENTS = {
315307
<ul>
316308
<li><strong>Import Name:</strong> ${importName}</li>
317309
<li><strong>URL:</strong> ${bubbleAppUrl}</li>
318-
<li><strong>Data Type:</strong> ${datatype}</li>
319310
<li><strong>Import Id:</strong> ${importId}</li>
320311
<li><strong>Time of Error:</strong> ${time}</li>
321312
</ul>

libs/shared/src/types/destination/destination.types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export interface IWebhookData {
2020
export interface IBubbleData {
2121
bubbleAppUrl: string;
2222
apiPrivateKey: string;
23-
datatype: string;
2423
}
2524

2625
export interface IDestinationData {

libs/shared/src/types/upload/upload.types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ export type SendBubbleCachedData = {
8282
name: string;
8383
page: number;
8484
email: string;
85-
datatype: string;
8685
chunkSize: number;
8786
bubbleAppUrl: string;
8887
apiPrivateKey: string;

0 commit comments

Comments
 (0)