Merge pull request #34 from MekDrop/improved-column-in-tests

Improved column in tests

Author: MekDrop

src/CriteriaCompo.php

@@ -5,7 +5,6 @@
 use Exception;
 use Imponeer\Database\Criteria\Enum\Condition;
 use IteratorAggregate;
-use Stringable;
 use Traversable;
 
 /**
@@ -109,12 +108,4 @@ public function render(bool $withBindVariables = false): ?string
 
         return $ret;
     }
-
-    /**
-     * @throws Exception
-     */
-    public function __toString(): string
-    {
-        return $this->render() . 'A';
-    }
 }

src/CriteriaElement.php

@@ -2,6 +2,7 @@
 
 namespace Imponeer\Database\Criteria;
 
+use Exception;
 use Imponeer\Database\Criteria\Traits\GroupByTrait;
 use Imponeer\Database\Criteria\Traits\OrderByTrait;
 use Imponeer\Database\Criteria\Traits\PartialResultsTrait;
@@ -89,4 +90,12 @@ public function __isset(string $name): bool
             default => false,
         };
     }
+
+    /**
+     * @throws Exception
+     */
+    public function __toString(): string
+    {
+        return $this->render(true) ?? '';
+    }
 }

src/CriteriaItem.php

@@ -232,12 +232,4 @@ private function isEmptyArrayButNotNullComparison(mixed $value): bool
                 ComparisonOperator::NOT_BETWEEN,
             ], true);
     }
-
-    /**
-     * @throws JsonException
-     */
-    public function __toString(): string
-    {
-        return $this->render();
-    }
 }

src/Traits/PartialResultsTrait.php

@@ -40,7 +40,6 @@ public function setLimit(int $limit = 0): self
      * Gets from what record number to return results (counting starts from 0)
      *
      * @noinspection MethodShouldBeFinalInspection
-     * @noinspection PhpDocSignatureInspection
      */
     public function getStart(): int
     {
@@ -53,7 +52,6 @@ public function getStart(): int
      * @param int $start Sets start position
      *
      * @noinspection MethodShouldBeFinalInspection
-     * @noinspection PhpDocSignatureInspection
      */
     public function setStart(int $start = 0): self
     {

tests/CriteriaItemTest.php

@@ -19,14 +19,14 @@ class CriteriaItemTest extends TestCase
      * Gets all possible comparison operators enums
      *
      * @return array<string, array{0: string, 1: mixed, 2: ComparisonOperator|string}>
-     * @throws RandomException
+     *
      * @throws JsonException
      */
     final public static function provideComparisonOperators(): array
     {
         $faker = Factory::create();
 
-        $column = $faker->sha1();
+        $column = 'field_' . $faker->word();
         $specialOperators = [
             ComparisonOperator::BETWEEN->name,
             ComparisonOperator::NOT_BETWEEN->name,