Skip to content

Commit f4f305b

Browse files
committed
[resolvers/node] [Refactor] use is-core-module directly
1 parent 4e83dcb commit f4f305b

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

resolvers/README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,16 +68,17 @@ If the resolver cannot resolve `source` relative to `file`, it should just retur
6868
Here is most of the [Node resolver] at the time of this writing. It is just a wrapper around substack/Browserify's synchronous [`resolve`]:
6969

7070
```js
71-
var resolve = require('resolve')
71+
var resolve = require('resolve');
72+
var isCoreModule = require('is-core-module');
7273
7374
exports.resolve = function (source, file, config) {
74-
if (resolve.isCore(source)) return { found: true, path: null }
75+
if (isCoreModule(source)) return { found: true, path: null };
7576
try {
76-
return { found: true, path: resolve.sync(source, opts(file, config)) }
77+
return { found: true, path: resolve.sync(source, opts(file, config)) };
7778
} catch (err) {
78-
return { found: false }
79+
return { found: false };
7980
}
80-
}
81+
};
8182
```
8283

8384
[Node resolver]: ./node/index.js

resolvers/node/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
'use strict';
22

33
const resolve = require('resolve');
4+
const isCoreModule = require('is-core-module');
45
const path = require('path');
56

67
const log = require('debug')('eslint-plugin-import:resolver:node');
@@ -11,7 +12,7 @@ exports.resolve = function (source, file, config) {
1112
log('Resolving:', source, 'from:', file);
1213
let resolvedPath;
1314

14-
if (resolve.isCore(source)) {
15+
if (isCoreModule(source)) {
1516
log('resolved to core');
1617
return { found: true, path: null };
1718
}

resolvers/node/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
"homepage": "https://github.com/import-js/eslint-plugin-import",
3131
"dependencies": {
3232
"debug": "^3.2.7",
33+
"is-core-module": "^2.11.0",
3334
"resolve": "^1.22.1"
3435
},
3536
"devDependencies": {

0 commit comments

Comments
 (0)