fix: disambiguate store save arity.

Author: outofcoffee

store/common/src/main/java/io/gatehill/imposter/store/core/AbstractStore.kt

@@ -65,7 +65,7 @@ abstract class AbstractStore(
             throw IllegalStateException("Cannot use deferred persistence for ephemeral store: $storeName of type: $typeDescription")
         }
         when (phase) {
-            ExchangePhase.REQUEST_RECEIVED -> save(key, value)
+            ExchangePhase.REQUEST_RECEIVED -> saveItem(key, value)
             ExchangePhase.RESPONSE_SENT -> deferSave(key, value)
             else -> throw IllegalStateException("Unsupported exchange phase for store persistence: $phase")
         }
@@ -74,9 +74,9 @@ abstract class AbstractStore(
     private fun deferSave(key: String, value: Any?) {
         logger.debug("Deferring persistence of item: $key to store: $storeName")
         deferredOperationService.defer("Write item: $key to store: $storeName") {
-            save(key, value)
+            saveItem(key, value)
         }
     }
 
-    abstract fun save(key: String, value: Any?)
+    abstract fun saveItem(key: String, value: Any?)
 }

store/common/src/main/java/io/gatehill/imposter/store/core/Store.kt

@@ -52,11 +52,11 @@ interface Store {
     val typeDescription: String
     val isEphemeral: Boolean
 
-    fun save(
-        key: String,
-        value: Any?,
-        phase: ExchangePhase = ExchangePhase.REQUEST_RECEIVED,
-    )
+    fun save(key: String, value: Any?, phase: ExchangePhase)
+
+    fun save(key: String, value: Any?) =
+        save(key, value, ExchangePhase.REQUEST_RECEIVED)
+
     fun <T> load(key: String): T?
     fun loadAsJson(key: String): String
     fun delete(key: String)

store/common/src/main/java/io/gatehill/imposter/store/inmem/InMemoryStore.kt

@@ -63,7 +63,7 @@ class InMemoryStore(
     private val store: MutableMap<String, Any> by lazy { ConcurrentHashMap() }
     override val typeDescription = "inmem"
 
-    override fun save(key: String, value: Any?) {
+    override fun saveItem(key: String, value: Any?) {
         LOGGER.trace("Saving item with key: {} to store: {}", key, storeName)
         modified = true
         value?.let { store[key] = value } ?: store.remove(key)

store/dynamodb/src/main/java/io/gatehill/imposter/store/dynamodb/DynamoDBStore.kt

@@ -79,7 +79,7 @@ class DynamoDBStore(
         logger.debug("Initialised DynamoDB store: $storeName using table: $tableName")
     }
 
-    override fun save(key: String, value: Any?) {
+    override fun saveItem(key: String, value: Any?) {
         logger.trace("Saving item with key: {} to store: {}", key, storeName)
         val valueAttribute = convertToAttributeValue(value)
 

store/redis/src/main/java/io/gatehill/imposter/store/redis/RedisStore.kt

@@ -79,7 +79,7 @@ class RedisStore(
         }
     }
 
-    override fun save(key: String, value: Any?) {
+    override fun saveItem(key: String, value: Any?) {
         LOGGER.trace("Saving item with key: {} to store: {}", key, storeName)
         if (null == value) {
             // can't save a null map value - remove existing if present