Skip to content

Commit 5cc8ddf

Browse files
Try migrating to modules again (#911)
1 parent 6a43460 commit 5cc8ddf

File tree

11 files changed

+554
-217
lines changed

11 files changed

+554
-217
lines changed

.circleci/config.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,9 @@ jobs:
2525
- run: sudo apt-get install unzip
2626
- run: . ./install-prototool.sh
2727
- run: echo 'export GOBIN=/go/bin' >> $BASH_ENV
28-
- run: go get -u golang.org/x/tools/cmd/goimports
29-
- run: go get -u github.com/robertkrimen/godocdown/godocdown
30-
- run: curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh
31-
- run: dep ensure
32-
- run: go install ./vendor/github.com/golang/protobuf/protoc-gen-go
33-
- run: export PATH=/go/src/github.com/improbable-eng/grpc-web/protobuf/bin:$PATH
28+
- run: go get golang.org/x/tools/cmd/goimports
29+
- run: go get github.com/robertkrimen/godocdown/godocdown
30+
- run: go install github.com/golang/protobuf/protoc-gen-go
3431
- run:
3532
command: |
3633
set +e
@@ -114,4 +111,4 @@ workflows:
114111
- BROWSER=ie11_win DISABLE_WEBSOCKET_TESTS=true
115112
- BROWSER=nodejs
116113
requires:
117-
- initial-unit-test-lint-prebuild
114+
- initial-unit-test-lint-prebuild

CONTRIBUTING.md

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,11 @@ The following steps guide you through a fresh checkout
88

99
```
1010
# Create a workspace
11-
cd ~/Projects/grpc-web # or wherever you want your checkout to live
12-
export GOPATH=$(pwd)
11+
cd ~/Projects/ # or wherever you want your checkout to live
1312
14-
# Checkout project sources into your new go workspace
15-
go get -u github.com/improbable-eng/grpc-web/go
16-
cd $GOPATH/src/github.com/improbable-eng/grpc-web
17-
18-
# Install go dependencies
19-
dep ensure
13+
# Checkout project sources
14+
git clone [email protected]:improbable-eng/grpc-web.git
15+
cd grpc-web
2016
2117
# Install NodeJS dependencies
2218
nvm use
@@ -25,7 +21,7 @@ npm install
2521

2622
Note you will also need to [install prototool](https://github.com/uber/prototool/blob/dev/docs/install.md) and add it to your `PATH` environment variable if you wish to re-generate the integration test proto files.
2723

28-
## Testing Prerequisites
24+
## Testing Prerequisites
2925
Before you run the tests for the first time, please follow these steps:
3026

3127
### Installing the Local Certificate
@@ -38,7 +34,7 @@ In order to run the Karma (Integration) tests, you will need to add the certific
3834
4. Select `misc/localhost.crt`
3935
5. Double click on the new `GRPC Web example dev server` certificate
4036
6. Expand the `Trust' section
41-
7. Change the `When using this certificate` option to `Always Trust`
37+
7. Change the `When using this certificate` option to `Always Trust`
4238
8. Close the certificate details pop-up.
4339

4440
Repeat the above process for `misc/localhostCA.pem`.
@@ -75,4 +71,4 @@ This is your prompt to open a web browser on https://localhost:9876 at which poi
7571
2. Update `CHANGELOG.md` by comparing commits to master since the last Github Release
7672
3. Raise a pull request for your changes, have it reviewed and landed into master.
7773
4. Switch your local checkout back to the master branch, pull your merged changes and run `./publish-release.sh`.
78-
5. Create the ARM binaries and attach them to the Github release.
74+
5. Create the ARM binaries and attach them to the Github release.

client/grpc-web-react-example/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
### Get started (with HTTP 1.1)
44

55
* `npm install`
6-
* The postinstall will run `npm run get_go_deps` to install Golang dependencies. [dep](https://github.com/golang/dep) is used for go dependency management.
76
* `npm start` to start the Golang server and Webpack dev server
87
* Go to `http://localhost:8081`
98

client/grpc-web-react-example/get_go_deps.sh

Lines changed: 0 additions & 11 deletions
This file was deleted.

client/grpc-web-react-example/go/Gopkg.lock

Lines changed: 0 additions & 138 deletions
This file was deleted.

client/grpc-web-react-example/go/Gopkg.toml

Lines changed: 0 additions & 46 deletions
This file was deleted.

client/grpc-web-react-example/go/exampleserver/exampleserver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414

1515
"strings"
1616

17-
library "github.com/improbable-eng/grpc-web/example/go/_proto/examplecom/library"
17+
library "github.com/improbable-eng/grpc-web/client/grpc-web-react-example/go/_proto/examplecom/library"
1818
"github.com/improbable-eng/grpc-web/go/grpcweb"
1919
"golang.org/x/net/context"
2020
)

client/grpc-web-react-example/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@
55
"scripts": {
66
"generate_cert": "cd ../misc ./gen_cert.sh",
77
"build:proto": "./protogen.sh",
8-
"get_go_deps": "./get_go_deps.sh",
9-
"postinstall": "npm run get_go_deps",
108
"webpack-dev:tls": "cd ts && export USE_TLS=true && webpack serve --watch --hot --inline --port 8082 --host 0.0.0.0 --output-public-path=https://localhost:8082/build/ --https --cert=../../../misc/localhost.crt --key=../../../misc/localhost.key",
119
"webpack-dev": "cd ts && webpack serve --watch --hot --inline --port 8081 --host 0.0.0.0 --output-public-path=http://localhost:8081/build/",
1210
"start:tls": "npm run build:proto && concurrently --kill-others \"go run go/exampleserver/exampleserver.go --enable_tls=true\" \"npm run webpack-dev:tls\"",

go.mod

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
module github.com/improbable-eng/grpc-web
2+
3+
go 1.16
4+
5+
require (
6+
github.com/desertbit/timer v0.0.0-20180107155436-c41aec40b27f
7+
github.com/golang/protobuf v1.4.3
8+
github.com/grpc-ecosystem/go-grpc-middleware v1.2.2
9+
github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0
10+
github.com/klauspost/compress v1.11.7 // indirect
11+
github.com/mwitkow/go-conntrack v0.0.0-20190716064945-2f068394615f
12+
github.com/mwitkow/grpc-proxy v0.0.0-20181017164139-0f1106ef9c76
13+
github.com/prometheus/client_golang v1.7.1
14+
github.com/prometheus/common v0.15.0 // indirect
15+
github.com/prometheus/procfs v0.3.0 // indirect
16+
github.com/rs/cors v1.7.0
17+
github.com/sirupsen/logrus v1.7.0
18+
github.com/spf13/pflag v1.0.5
19+
github.com/stretchr/testify v1.7.0
20+
golang.org/x/net v0.0.0-20210119194325-5f4716e94777
21+
golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c // indirect
22+
golang.org/x/text v0.3.5 // indirect
23+
google.golang.org/genproto v0.0.0-20210126160654-44e461bb6506 // indirect
24+
google.golang.org/grpc v1.32.0
25+
google.golang.org/protobuf v1.25.0 // indirect
26+
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
27+
nhooyr.io/websocket v1.8.6
28+
)

0 commit comments

Comments
 (0)