Skip to content

Commit 728d225

Browse files
committed
web: fix state_referenced_locally warnings with proper runes
1 parent c857054 commit 728d225

File tree

4 files changed

+16
-9
lines changed

4 files changed

+16
-9
lines changed

web/src/components/dialog/PickerItem.svelte

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,16 @@
2222
let imageLoaded = $state(false);
2323
let hideSkeleton = $state(false);
2424
25-
let validUrl = false;
26-
try {
27-
new URL(item.url);
28-
validUrl = true;
29-
} catch {}
25+
const validUrl = $derived.by(() => {
26+
try {
27+
new URL(item.url);
28+
return true;
29+
} catch {
30+
return false;
31+
}
32+
});
3033
31-
const isTunnel = validUrl && new URL(item.url).pathname === "/tunnel";
34+
const isTunnel = $derived(validUrl && new URL(item.url).pathname === "/tunnel");
3235
3336
const loaded = () => {
3437
imageLoaded = true;

web/src/components/misc/FileReceiver.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
onImport,
2424
}: Props = $props();
2525
26-
let selectorStringMultiple = maxFileNumber > 1 ? ".multiple" : "";
26+
const selectorStringMultiple = $derived(maxFileNumber > 1 ? ".multiple" : "");
2727
2828
let fileInput: HTMLInputElement;
2929

web/src/components/misc/SectionHeading.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
copyData = "",
2323
}: Props = $props();
2424
25-
const sectionURL = `${page.url.origin}${page.url.pathname}#${sectionId}`;
25+
const sectionURL = $derived(`${page.url.origin}${page.url.pathname}#${sectionId}`);
2626
2727
let copied = $state(false);
2828
</script>

web/src/components/save/OmniboxIcon.svelte

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,11 @@
88
99
let { loading }: Props = $props();
1010
11-
let animated = $state(loading);
11+
let animated = $state(false);
12+
13+
$effect(() => {
14+
animated = loading;
15+
});
1216
1317
/*
1418
initial spinner state is equal to loading state,

0 commit comments

Comments
 (0)