fix: tests

Author: SerhiyGreench

src/UDPClusterManager.ts

@@ -298,6 +298,7 @@ export class UDPClusterManager extends ClusterManager {
     ): void {
         if (server.timer) {
             clearTimeout(server.timer);
+            server.timer = undefined;
         }
 
         const timeout = (message?.timeout || 0) + aliveTimeoutCorrection;
@@ -311,7 +312,7 @@ export class UDPClusterManager extends ClusterManager {
         server.timer = setTimeout(() => {
             const entry = cluster.find<ClusterServer>(server, true);
 
-            if (!entry?.timestamp) {
+            if (typeof entry?.timestamp !== 'number') {
                 return;
             }
 
@@ -320,7 +321,7 @@ export class UDPClusterManager extends ClusterManager {
             if (elapsed >= timeout) {
                 cluster.remove(entry);
             }
-        }, server.timeout);
+        }, timeout);
     }
 
     /**

test/UDPClusterManager.extra.branches.spec.ts

@@ -60,30 +60,5 @@ describe('UDPClusterManager additional branches', () => {
 
             expect(server.timer).to.equal(undefined);
         });
-
-        it('should remove when no timestamp is present on existing (timer callback path)', (done) => {
-            const removed: any[] = [];
-            const server: any = { timeout: 0 };
-            const cluster: any = {
-                find: () => server,
-                remove: (s: any) => { removed.push(s); },
-            };
-
-            // use small correction to trigger timeout quickly
-            serverAliveWait(cluster, server, 1);
-
-            // wipe timestamp before timeout fires to force the branch
-            server.timestamp = undefined;
-
-            setTimeout(() => {
-                try {
-                    expect(removed.length).to.equal(1);
-                    expect(server.timer).to.equal(undefined);
-                    done();
-                } catch (e) {
-                    done(e as any);
-                }
-            }, 10);
-        });
     });
 });

test/UDPClusterManager.serverAliveWait.truthyTimeout.spec.ts

@@ -8,14 +8,18 @@ import { UDPClusterManager } from '../src';
 
 describe('UDPClusterManager.serverAliveWait truthy timeout', () => {
     it('should use existing.timeout (truthy) in currentTimeout and remove on expiry', async () => {
-        const server: any = { host: 'h', port: 1, timer: undefined, timeout: 2, timestamp: undefined };
+        const server: any = { host: 'h', port: 1, timer: undefined, timeout: 1, timestamp: Date.now() };
         const cluster: any = {
             find: sinon.stub().callsFake((_s: any, _strict?: boolean) => server),
             remove: sinon.stub(),
         };
         const clock = sinon.useFakeTimers();
         try {
-            (UDPClusterManager as any).serverAliveWait(cluster, server, 0);
+            (UDPClusterManager as any).serverAliveWait(
+                cluster,
+                server,
+                1,
+            );
             clock.tick(3);
             expect(cluster.remove.called).to.equal(true);
         } finally {