Skip to content

Commit 381cb70

Browse files
committed
Validate estimated time input and improve alert message for task creation
1 parent 89d09b7 commit 381cb70

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

index.html

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,8 @@ <h2 class="text-3xl font-bold mb-6 text-center text-gray-700">
128128
<input
129129
type="number"
130130
min="1"
131-
max="100"
132131
id="task-estimated-time"
133132
placeholder="e.g. 3"
134-
onkeydown="return false"
135133
class="w-full p-2 border border-gray-300 rounded-md focus:outline-none focus:ring-2 focus:ring-blue-500"
136134
/>
137135
</div>

src/tasks/tasksList.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ document.addEventListener('DOMContentLoaded', () => {
3232
const taskTitle = taskInputEl.value.trim()
3333
const deadline = new Date(taskDeadlineEl.value).getTime()
3434
const estimatedTime = parseInt(taskEstimatedTimeEl.value) // in hours
35-
if (taskTitle && deadline && estimatedTime) {
35+
if (taskTitle && deadline && estimatedTime && estimatedTime >= 1) {
3636
addTask(taskTitle, deadline, estimatedTime)
3737
} else {
38-
alert('Please fill in all fields')
38+
alert('Please fill in all fields with valid values.')
3939
}
4040
})
4141
})

0 commit comments

Comments
 (0)