Findbugs fixes

Author: ctmay4

build.gradle

@@ -56,8 +56,6 @@ jar {
 
 test {
     maxHeapSize = "1g"
-//    forkEvery = 50
-//    maxParallelForks = Runtime.runtime.availableProcessors()
 }
 
 checkstyle {
@@ -67,7 +65,7 @@ checkstyle {
 
 findbugs {
     ignoreFailures = true
-    effort = 'max'
+    //reportLevel = 'low'
     excludeFilter = file('config/findbugs/findbugs-exclude.xml')
 }
 

config/findbugs/findbugs-exclude.xml

@@ -1,6 +1,6 @@
 <FindBugsFilter>
     <Match>
-        <Bug category="MALICIOUS_CODE" />
+        <Bug category="MALICIOUS_CODE"/>
     </Match>
     <Match>
         <Bug pattern="OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE"/>
@@ -9,4 +9,11 @@
         <Class name="com.imsweb.staging.IntegrationUtils"/>
         <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
     </Match>
+    <Match>
+        <Bug pattern="EI_EXPOSE_REP"/>
+    </Match>
+    <Match>
+        <Bug pattern="EI_EXPOSE_REP2"/>
+    </Match>
+
 </FindBugsFilter>

src/main/java/com/imsweb/decisionengine/DecisionEngine.java

@@ -32,7 +32,7 @@ public class DecisionEngine {
     private static Pattern _TEMPLATE_REFERENCE = Pattern.compile("\\{\\{(.*?)\\}\\}");
 
     // string to use for blank or null in error strings
-    public static String _BLANK_OUTPUT = "<blank>";
+    public static final String _BLANK_OUTPUT = "<blank>";
 
     private DataProvider _provider;
 

src/main/java/com/imsweb/staging/Staging.java

@@ -6,6 +6,7 @@
 import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.Calendar;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Iterator;
@@ -36,7 +37,7 @@ public final class Staging {
     public static final String CTX_YEAR_CURRENT = "ctx_year_current";
 
     // list of all context keys
-    public static final List<String> CONTEXT_KEYS = Arrays.asList(CTX_ALGORITHM_VERSION, CTX_YEAR_CURRENT);
+    public static final List<String> CONTEXT_KEYS = Collections.unmodifiableList(Arrays.asList(CTX_ALGORITHM_VERSION, CTX_YEAR_CURRENT));
 
     private DecisionEngine _engine = null;
     private StagingDataProvider _provider = null;