Better handle tables with no rows.

There was an exception being thrown in getInvolvedTables when the table
had no rows.  There was no reason for this.

Author: ctmay4

build.gradle

@@ -8,7 +8,7 @@ plugins {
 }
 
 group = 'com.imsweb'
-version = '1.5-SNAPSHOT'
+version = '1.5'
 description = 'Java client library for staging calculations'
 
 println "Starting build using ${Jvm.current()}"

src/main/java/com/imsweb/decisionengine/DecisionEngine.java

@@ -354,20 +354,18 @@ protected Set<String> getInvolvedTables(Table table, Set<String> tables) {
         if (table == null)
             return tables;
 
-        if (table.getTableRows() == null || table.getTableRows().isEmpty())
-            throw new IllegalStateException("Table not initialized");
-
         tables.add(table.getId());
 
-        for (TableRow tableRow : table.getTableRows()) {
-            for (Endpoint endpoint : tableRow.getEndpoints()) {
-                if (endpoint != null && EndpointType.JUMP.equals(endpoint.getType())) {
-                    // if table has already been visited, don't call getInvolvedTables again; otherwise we could have infinite recursion
-                    if (!tables.contains(endpoint.getValue()))
-                        getInvolvedTables(getProvider().getTable(endpoint.getValue()), tables);
+        if (table.getTableRows() != null)
+            for (TableRow tableRow : table.getTableRows()) {
+                for (Endpoint endpoint : tableRow.getEndpoints()) {
+                    if (endpoint != null && EndpointType.JUMP.equals(endpoint.getType())) {
+                        // if table has already been visited, don't call getInvolvedTables again; otherwise we could have infinite recursion
+                        if (!tables.contains(endpoint.getValue()))
+                            getInvolvedTables(getProvider().getTable(endpoint.getValue()), tables);
+                    }
                 }
             }
-        }
 
         return tables;
     }
@@ -602,15 +600,13 @@ public Result process(Definition definition, Map<String, String> context) {
 
                 List<? extends Endpoint> endpoints = matchTable(lookup, context);
                 if (endpoints == null) {
-                    result.addError(new ErrorBuilder(Boolean.TRUE.equals(input.getUsedForStaging()) ? Type.INVALID_REQUIRED_INPUT : Type.INVALID_NON_REQUIRED_INPUT)
-                            .message("Invalid '" + input.getKey() + "' value (" + (value.isEmpty() ? _BLANK_OUTPUT : value) + ")")
-                            .key(input.getKey()).table(input.getTable())
-                            .build());
+                    result.addError(new ErrorBuilder(Boolean.TRUE.equals(input.getUsedForStaging()) ? Type.INVALID_REQUIRED_INPUT : Type.INVALID_NON_REQUIRED_INPUT).message(
+                            "Invalid '" + input.getKey() + "' value (" + (value.isEmpty() ? _BLANK_OUTPUT : value) + ")").key(input.getKey()).table(input.getTable()).build());
 
                     // if the schema error handling is set to FAIL or if the input is required for staging and the error handling is set to FAIL_WHEN_REQUIRED_FOR_STAGING,
                     // then stop processing and return a failure result
-                    if (Definition.StagingInputErrorHandler.FAIL.equals(definition.getOnInvalidInput()) ||
-                            (Boolean.TRUE.equals(input.getUsedForStaging()) && Definition.StagingInputErrorHandler.FAIL_WHEN_USED_FOR_STAGING.equals(definition.getOnInvalidInput())))
+                    if (Definition.StagingInputErrorHandler.FAIL.equals(definition.getOnInvalidInput()) || (Boolean.TRUE.equals(input.getUsedForStaging())
+                            && Definition.StagingInputErrorHandler.FAIL_WHEN_USED_FOR_STAGING.equals(definition.getOnInvalidInput())))
                         stopForBadInput = true;
                 }
             }
@@ -661,10 +657,8 @@ public Result process(Definition definition, Map<String, String> context) {
                                     String mapFromKey = key.getFrom();
 
                                     if (!context.containsKey(mapFromKey)) {
-                                        result.addError(new ErrorBuilder(Type.UNKNOWN_INPUT_MAPPING)
-                                                .message("Input mapping '" + mapFromKey + "' does not exist for table '" + tableId + "'")
-                                                .key(mapFromKey)
-                                                .table(tableId).build());
+                                        result.addError(new ErrorBuilder(Type.UNKNOWN_INPUT_MAPPING).message("Input mapping '" + mapFromKey + "' does not exist for table '" + tableId + "'").key(
+                                                mapFromKey).table(tableId).build());
                                         continue;
                                     }
 
@@ -715,10 +709,8 @@ else if (output.getTable() != null) {
                     List<? extends Endpoint> endpoints = matchTable(lookup, context);
                     if (endpoints == null) {
                         String value = context.get(output.getKey());
-                        result.addError(new ErrorBuilder(Type.INVALID_OUTPUT)
-                                .message("Invalid '" + output.getKey() + "' value (" + (value.isEmpty() ? _BLANK_OUTPUT : value) + ")")
-                                .key(output.getKey()).table(output.getTable())
-                                .build());
+                        result.addError(new ErrorBuilder(Type.INVALID_OUTPUT).message("Invalid '" + output.getKey() + "' value (" + (value.isEmpty() ? _BLANK_OUTPUT : value) + ")").key(
+                                output.getKey()).table(output.getTable()).build());
                     }
                 }
             }
@@ -742,17 +734,15 @@ protected boolean process(String mappingId, String tableId, TablePath path, Resu
 
         Table table = getProvider().getTable(tableId);
         if (table == null) {
-            result.addError(new ErrorBuilder(Type.UNKNOWN_TABLE)
-                    .message("The processing of '" + path.getId() + "' contains a reference to an unknown table: '" + tableId + "'")
-                    .table(tableId).build());
+            result.addError(new ErrorBuilder(Type.UNKNOWN_TABLE).message("The processing of '" + path.getId() + "' contains a reference to an unknown table: '" + tableId + "'").table(tableId)
+                    .build());
             return true;
         }
 
         // track the path history to make sure no table is reached twice
         if (stack.contains(tableId)) {
-            result.addError(new ErrorBuilder(Type.INFINITE_LOOP)
-                    .message("The processing of '" + path.getId() + "' has entered an infinite recursive state.  Table '" + tableId + "' was accessed multiple times.")
-                    .table(tableId).build());
+            result.addError(new ErrorBuilder(Type.INFINITE_LOOP).message(
+                    "The processing of '" + path.getId() + "' has entered an infinite recursive state.  Table '" + tableId + "' was accessed multiple times.").table(tableId).build());
             return true;
         }
 
@@ -765,8 +755,8 @@ protected boolean process(String mappingId, String tableId, TablePath path, Resu
         // look for the match in the mapping table; if no match is found, used the table-specific no_match value
         List<? extends Endpoint> endpoints = matchTable(table, result.getContext());
         if (endpoints == null)
-            result.addError(new ErrorBuilder(Type.MATCH_NOT_FOUND).message("Match not found in table '" + tableId + "' (" + getTableInputsAsString(table, result.getContext()) + ")")
-                    .table(tableId).build());
+            result.addError(new ErrorBuilder(Type.MATCH_NOT_FOUND).message("Match not found in table '" + tableId + "' (" + getTableInputsAsString(table, result.getContext()) + ")").table(tableId)
+                    .build());
         else {
             for (Endpoint endpoint : endpoints) {
                 if (EndpointType.STOP.equals(endpoint.getType()))

src/test/java/com/imsweb/decisionengine/DecisionEngineTest.java

@@ -999,6 +999,37 @@ public void testInvolvedTables() {
         Assert.assertTrue(tables.contains("table_exclusion1"));
     }
 
+    @Test
+    public void testInvolvedTablesWhenEmpty() {
+        BasicDataProvider provider = new BasicDataProvider();
+
+        // add empty table
+        BasicTable table = new BasicTable("table1");
+        table.addColumnDefinition("a", ColumnType.INPUT);
+        provider.addTable(table);
+
+        // add another empty table
+        table = new BasicTable("table2");
+        table.addColumnDefinition("b", ColumnType.INPUT);
+        provider.addTable(table);
+
+        BasicDefinition def = new BasicDefinition("def1");
+        def.setOnInvalidInput(Definition.StagingInputErrorHandler.FAIL);
+        def.addInput("a");
+        def.addInput("b");
+        BasicMapping mapping = new BasicMapping("m1");
+        mapping.setTablePaths(Arrays.asList(new BasicTablePath("table1"), new BasicTablePath("table2")));
+        def.addMapping(mapping);
+        provider.addDefinition(def);
+
+        DecisionEngine engine = new DecisionEngine(provider);
+
+        Set<String> tables = engine.getInvolvedTables("def1");
+        Assert.assertEquals(2, tables.size());
+        Assert.assertTrue(tables.contains("table1"));
+        Assert.assertTrue(tables.contains("table2"));
+    }
+
     @Test
     public void testInvolvedTableRecursion() {
         Set<String> tables = _ENGINE.getInvolvedTables("starting_recursion");