Merge pull request #5 from imsweb/segment-pos-order-4

Segment pos order (#4)

Author: ctmay4

src/main/java/com/imsweb/x12/reader/X12Reader.java

@@ -562,13 +562,19 @@ private boolean validateLines(List<String> segments, String loopId, Separators s
         int[] segmentCounter = new int[format.size()];
         boolean lineMatchesFormat = false;
 
+        String previousPos = null;
         for (String segment : segments) {
             int i = 0;
             for (SegmentDefinition segmentConf : format) {
                 String[] tokens = segment.split(Pattern.quote(separators.getElement().toString()));
                 if (tokens[0].equals(segmentConf.getXid()) && codesValidated(tokens, segmentConf)) {
+                    String currentPos = segmentConf.getPos();
+                    if (previousPos != null && Integer.parseInt(previousPos) > Integer.parseInt(currentPos))
+                        _errors.add("Segment " + segmentConf.getXid() + " in loop " + loopId + " is not in the correct position.");
+
                     segmentCounter[i]++;
                     lineMatchesFormat = true;
+                    previousPos = currentPos;
                     break;
                 }
                 i++;

src/test/java/com/imsweb/x12/reader/X12ReaderTest.java

@@ -531,4 +531,17 @@ private void validateMultipleSTLoops(Loop loop) {
         Assert.assertEquals("AN INSURANCE COMPANY", loop.getLoop("ST_LOOP", 1).getLoop("2010BB", 1).getSegment("NM1").getElementValue("NM103"));
     }
 
+    @Test
+    public void testSegmentsNotInOrder() throws Exception {
+        URL url = this.getClass().getResource("/837_5010/x12_segments_out_of_order.txt");
+        X12Reader reader = new X12Reader(FileType.ANSI837_5010_X222, new File(url.getFile()));
+
+        List<String> errors = reader.getErrors();
+
+        System.out.println(errors);
+        Assert.assertEquals(2, errors.size());
+
+        Assert.assertTrue(errors.contains("Segment N4 in loop 2010AA is not in the correct position."));
+        Assert.assertTrue(errors.contains("Segment N3 in loop 2010AB is not in the correct position."));
+    }
 }

src/test/resources/837_5010/x12_segments_out_of_order.txt

@@ -0,0 +1,45 @@
+ISA*00*          *01*SECRET    *ZZ*SUBMITTERS.ID  *ZZ*RECEIVERS.ID   *030101*1253*U*00501*000000905*1*T*:~
+GS*HC*SENDER CODE*RECEIVER CODE*19991231*0802*1*X*005010X222A1~
+ST*837*987654*005010X222A1~
+BHT*0019*00*0123*19960918*0932*CH~
+NM1*41*2*ANGELASZEK MEDICAL*****46*999999999~
+PER*IC*DAVID ANGELASZEK*TE*3016809770*EX*123~
+NM1*40*2*HEALTH RECEIVER*****46*111222333~
+HL*1**20*1~
+NM1*85*2*MEDICAL GROUP*****XX*1234567890~
+N3*3901 CALVERTON BLVD~
+REF*EI*123456789~
+N4*CALVERTON*MD*20705~
+PER*IC*JANE JONES*TE*3022893453~
+PER*IC*JANE JANES*TE*3012833053*EX*201~
+NM1*87*2~
+N4*GREENBELT*MD*20770~
+N3*227 LASTNER LANE~
+HL*2*1*22*1~
+SBR*P**SUBSCRIBER GROUP******CI~
+NM1*IL*1*DOE*JOHN*T**JR*MI*123456~
+NM1*PR*2*HEALTH INSURANCE COMPANY*****PI*11122333~
+CLM*A37YH556*500***11:B:1*Y*A*Y*I*P~
+HI*BK*8901*BF*87200*BF:5559~
+LX*1~
+SV1*HC:99211:25*12.25*UN*1*11**1**Y~
+DTP*472*RD8*20050314-20050325~
+HL*2*3*22*1~
+SBR*P**SUBSCRIBER GROUP TWO******CI~
+NM1*IL*1*DOE*DAVID*J**JR*MI*123456~
+NM1*PR*2*HEALTH INSURANCE COMPANY TWO*****PI*11122333~
+CLM*A37YH667*500***11:B:1*Y*A*Y*I*P~
+HI*BK*1987*BF*4134*BF:5559~
+LX*2~
+SV1*HC:478331:25*12.25*UN*1*11**1:2:3**Y~
+DTP*472*RD8*20050322-20050325~
+SE*25*987654~
+GE*1*1~
+IEA*1*000000905~
+
+
+
+
+
+
+